From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CADC3DA4A for ; Fri, 16 Aug 2024 10:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEAE98D005A; Fri, 16 Aug 2024 06:11:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9A826B0306; Fri, 16 Aug 2024 06:11:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3B958D005A; Fri, 16 Aug 2024 06:11:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A33D36B0305 for ; Fri, 16 Aug 2024 06:11:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3D3BC121A75 for ; Fri, 16 Aug 2024 10:11:51 +0000 (UTC) X-FDA: 82457692422.09.6B838D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 0AB6C10000E for ; Fri, 16 Aug 2024 10:11:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WJmEOGZz; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723803036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m6Hfpfu8wijeS0qwen2zTNuZPfA+GXTSJLsDs6t5NsE=; b=AoK/PCrZp+XzuNr8c5IY8jD/l1YP7FNgw+fUK7IiCbeN2ksIc6IVbj1T6ZveVwm20FOrDx TXSj9lNR/wN8wzPLe4nJVxKItKKQ78RV5h4H2gvg0RPl6+XH0fSILl+Nip3D6GgKJ7u0zL 1HHxsCqZyqWk7k4c56QSEH8w49zI1rM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723803036; a=rsa-sha256; cv=none; b=QxZAG40cZCo20Vjio58hOrhZminp6b+r2qQhCcRC9bbczfYbIwH2tXodGoWoNJr1POU5eW FTJ+gXNQAfUDl7my7vl/TyfI0NdLx+5ZzXScVWPdBj4Xj1G37ciTn3kS+EgpLJXaXDxXYQ AXoBK99CLe1Cmwl8kEZ8GIS29Qlow+0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WJmEOGZz; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723803108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=m6Hfpfu8wijeS0qwen2zTNuZPfA+GXTSJLsDs6t5NsE=; b=WJmEOGZzrs8HDhi8v3NqebyhW9smQ2fQgkkoIi8IkpT+AlgMRvZ9rvWM4CEjMIHiyq1zv4 EgCCfJdk3bJtr2ZnO//QgjmwBn6tBLbaObApKgk1jKggCERgBAKdYIKwAjRSpRnUFRpVih 2VA7M44YR6fTeBMxxWt8UbvysSO75m4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-Hi03gtcwNsy7GxeHnSWdmA-1; Fri, 16 Aug 2024 06:11:46 -0400 X-MC-Unique: Hi03gtcwNsy7GxeHnSWdmA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3718c0b4905so654760f8f.2 for ; Fri, 16 Aug 2024 03:11:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723803105; x=1724407905; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=m6Hfpfu8wijeS0qwen2zTNuZPfA+GXTSJLsDs6t5NsE=; b=MCCyqZBvdOPBASEKNE4TiTV7f6iVbmByiVyZR4UA7UtUTmhHEbsCeWnAPvvSLkXj/G /kZQSqEJza+mQcOGWAx2WDBBnkF7i0ZP7ZFR+I9lGG/COT4YAhh03KKqn8BJ0HpJX8Tq DYcf+GIYZr+OHlYSSSmk5V4v7vudYO8mrBR874O4qR6CBFnsS9jQxnyY4Ik7QJkAe0hl NyW4/Kqu2ePy8AWkU4GlNtqjqC8IUFmIZ9cpGIfsJfE0Wxu3Y91kJtPnfWsB5VGkM1Pb AZVd5U9RDnOEcQJ5t8dXP/g9x3iTPyv8EET9rsQ90fpEg6QdWjRbZ8w6YqoDNrxtTm4I E4tg== X-Gm-Message-State: AOJu0YztflBWVed3pX+kXQvh/UDIzXQFQGHAu9kxFbt5xpv+acI3YWki w5EAMFta1gZauu4h4WuEGBw1iey4Hkq5FtOT1DOdkTVUELLZ7KZzepKSvM+hfWcIVNuYxudYWQe 2vPDRx8Oa0On1AeImidky02WiaYcZymCkATr2zC9WoGQDUObR X-Received: by 2002:adf:e3cf:0:b0:368:747c:5a04 with SMTP id ffacd0b85a97d-37194649c71mr1516287f8f.25.1723803105596; Fri, 16 Aug 2024 03:11:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH8uzk80zBFfCQU/E8hUp3z4AO+vmkEX0meNJtBW90LKxj4NrCCv7tCvnu266xMYJ6dswg2eQ== X-Received: by 2002:adf:e3cf:0:b0:368:747c:5a04 with SMTP id ffacd0b85a97d-37194649c71mr1516265f8f.25.1723803105104; Fri, 16 Aug 2024 03:11:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c721:b900:4f34:b2b7:739d:a650? (p200300cbc721b9004f34b2b7739da650.dip0.t-ipconnect.de. [2003:cb:c721:b900:4f34:b2b7:739d:a650]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3718983a31csm3290455f8f.17.2024.08.16.03.11.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2024 03:11:44 -0700 (PDT) Message-ID: Date: Fri, 16 Aug 2024 12:11:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove migration for HugePage in isolate_single_pageblock() To: Kefeng Wang , Andrew Morton , Oscar Salvador , Zi Yan Cc: linux-mm@kvack.org, Matthew Wilcox References: <20240816040625.650053-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240816040625.650053-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0AB6C10000E X-Stat-Signature: bgmifyi99x58cnumfhau5g9pzsehderh X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723803108-836639 X-HE-Meta: U2FsdGVkX18z60c10hVOjW9Xs30y9GjIYOqOOyvzKf74q/z5zGsmEJtyCF8IB9xL4wPCfqtCQRjLx8/TzPovODrGD0HlndhoQLTOMSpY0RoJSju7ZzRPWLZESWVp+eIgnG0HCOu2O2+BgwtCUOEKjymCdnZJgjnbSfC9cWxBEWO2kFvDf2mN70u0vRMGUfnZOE9C48qqMeLlpdrYdy9B3Xm2jAEcuG2NhVm3/uRP4GDi+BQVj/hiAQhQzMwp9nzvw/ZO37X4gN63Z7lPxpXmb9FYUQaW/P68P51mJSIZaqoFvO3fK7ATewbZpAVy4p5H3nXs5F0qlRNJb3NmjaJK13H9qhz0a+xhgcdj+rbemhnKXDGPeGRoQkGXzJz8GLSr0e804cefCWaYcr999n1m1+ix9Lnq1+Ms7IfOZOUEEHj8m66p76iF/IC2BMJ9WUadmv4pa8WPah8+uxMgy4gF2yXN3TmNM4/l4DxDM9wGca+5p/6T1CrEtJvBZNgGWgRdNYM9ApS/UQeLGXTC624ooxLimCATK4Tw3BeOnG8eEmYZuw9hkG4oW8JP7ae9VLvtf1Jirpk6wgCqsGGlFNYVMgzq8umXg1FNrza3uwNNHUqTlF+UGXdCclssXTZY6ARFwhA5WLu0qjD+wfkhMDC09mQP8Xuewj5oRr49ouNgkIrOF9iA3XRn55To7PzN9I9F8gpeGpJ7n2xykpsdUF4iSjXej7pEPwcWbl/rpszO9uAecfQzC555D0Xs59vEe5oEq3lVBOBwJb2YWAIeEMmH8vzZd4qUqzfv9jl72ng5fPzU/Dy2yiPEqHun1iXFX/JQdGjd2AO/PSbBF/Wahn9fvVMYreA7m+UhEF+MZT7L4M8EQ6FJGZhqbRib+PZhdp2hQ9wXGsmkMpQ83FopjCD0tCYZFPcIWzbY9Iis4rfzVxxSqa1/EF8SPb5v7FfD/cQzh29pKnn6BKYpZfeHOTv fCsVayuH CqMj7sdfE2N63nN+kt91PSotHkZZFoELf1z4TdWKWuhWjt8h7+6AxSSFtFfvpkUPMep+unpVCSUSg5d66VjmcAbshwlVKeXNuJSd7POMH/D/9YNRGgL9eO/HLNKj6vjPJro/EbpD0i+/oog6+djYDzdweuIm9ZWPS5sQZ7zbsiy7ulOsyraYKNpjheUXmf+w8T+bIFZa0rZLC4RZPw48dbDESSBMP+dCY0wTYabLK9DKZS9E4FLEqtnf132H9gFVUpmVycgXaKpbVowfvZWjjmvAz7AdZpur9Y1V3H7USv1tlqTqot5V66dxrGPb+J4ic5IPR4lbxycJupqhOaYlg1Yw2tbnYPvblnmnSrLU7G3w0GX0kTnad5XfwmyZDauR3QdRodAVQwj1ezOpkgnGASqB15EdaS2DqZFvuUu58Ks0p91VEpR9O+7p2lA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 06:06, Kefeng Wang wrote: > The gigantic page size may larger than memory block size, so memory > offline always fails in this case after commit b2c9e2fbba32 ("mm: make > alloc_contig_range work at pageblock granularity"), > > offline_pages > start_isolate_page_range > start_isolate_page_range(isolate_before=true) > isolate [isolate_start, isolate_start + pageblock_nr_pages) > start_isolate_page_range(isolate_before=false) > isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock > __alloc_contig_migrate_range > isolate_migratepages_range > isolate_migratepages_block > isolate_or_dissolve_huge_page > if (hstate_is_gigantic(h)) > return -ENOMEM; > > In fact, we don't need to migrate page in page range isolation, for > memory offline path, there is do_migrate_range() to move the pages. > For contig allocation, there is another __alloc_contig_migrate_range() > after isolation to migrate the pages. So fix issue by skipping the > __alloc_contig_migrate_range() in isolate_single_pageblock(). > > Fixes: b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock granularity") > Signed-off-by: Kefeng Wang > --- > mm/page_isolation.c | 28 +++------------------------- > 1 file changed, 3 insertions(+), 25 deletions(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 39fb8c07aeb7..7e04047977cf 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -403,30 +403,8 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, > unsigned long head_pfn = page_to_pfn(head); > unsigned long nr_pages = compound_nr(head); > > - if (head_pfn + nr_pages <= boundary_pfn) { > - pfn = head_pfn + nr_pages; > - continue; > - } > - > -#if defined CONFIG_COMPACTION || defined CONFIG_CMA > - if (PageHuge(page)) { > - int page_mt = get_pageblock_migratetype(page); > - struct compact_control cc = { > - .nr_migratepages = 0, > - .order = -1, > - .zone = page_zone(pfn_to_page(head_pfn)), > - .mode = MIGRATE_SYNC, > - .ignore_skip_hint = true, > - .no_set_skip_hint = true, > - .gfp_mask = gfp_flags, > - .alloc_contig = true, > - }; > - INIT_LIST_HEAD(&cc.migratepages); > - > - ret = __alloc_contig_migrate_range(&cc, head_pfn, > - head_pfn + nr_pages, page_mt); > - if (ret) > - goto failed; But won't this break alloc_contig_range() then? I would have expected that you have to special-case here on the migration reason (MEMORY_OFFLINE). I remember some dirty details when we're trying to allcoate with a single pageblock for alloc_contig_range(). Note that memory offlining always covers pageblocks large than MAX_ORDER chunks (which implies full pageblocks) but alloc_contig_range() + CMA might only cover (parts of) single pageblocks. Hoping Zi Yan can review :) -- Cheers, David / dhildenb