From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1322FC5B549 for ; Fri, 6 Jun 2025 09:14:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87E406B008C; Fri, 6 Jun 2025 05:14:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 855DF6B0092; Fri, 6 Jun 2025 05:14:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76BC96B0093; Fri, 6 Jun 2025 05:14:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 539356B008C for ; Fri, 6 Jun 2025 05:14:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E7E7A1608F4 for ; Fri, 6 Jun 2025 09:14:47 +0000 (UTC) X-FDA: 83524415814.07.52CB9D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 7A222C0004 for ; Fri, 6 Jun 2025 09:14:45 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZC3ILgMc; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749201285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oCj6+Sxcxs0auBfeuChSwk33Y3pn/sByOGMCDkMC3UA=; b=jGixx6b/WAVsE4f2lD43r04ugdaXVPufdktZKUbkXQ2kPMR1G+YuU0JudFyJexEbxw5HUZ MNJ1OYQryZPaZuncO5gzegDoGC4Q+n+81g01lIKLtRfpFdfY9nmqEcFjNbXpJuY/CaRnj8 pac7jLOrX/5Y3xfYhCLMwl486BrZkvc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZC3ILgMc; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749201285; a=rsa-sha256; cv=none; b=ofEW5lQO8yuQaD6hmYznV1HGeN7wTIdWZdx1KW5MJvCQlWcP8Elsp67kCjpSdpJwapZMxY RFUZra7RblopUi+YPPvATW9aRZbdjOzisTv0HHv2kxArd6CW+uDVwYNvU2bAWtFEZUumad SaYHijuoG8IcoLuNxJwxuFmcK/PIbLA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749201284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oCj6+Sxcxs0auBfeuChSwk33Y3pn/sByOGMCDkMC3UA=; b=ZC3ILgMcGmv1AAnKhsXEdJwARFnLNsAWvVr2PTEbH3gSDLDQH5+qBhHm6G8Wgc4lgB9Kzy WpP4V5a3Z2Sgne5RcvpLTiaKrMcPZvTQMe2tOkGd9o+ZROlTMIjSMQXG3FJqQdIduLBwlm PY2VVUhz1CVezESrHw8anXGIkVG5DSs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-OftwgwVPMD2sn1lKnFYEiQ-1; Fri, 06 Jun 2025 05:14:41 -0400 X-MC-Unique: OftwgwVPMD2sn1lKnFYEiQ-1 X-Mimecast-MFC-AGG-ID: OftwgwVPMD2sn1lKnFYEiQ_1749201280 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-451deff247cso13961635e9.1 for ; Fri, 06 Jun 2025 02:14:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749201280; x=1749806080; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=oCj6+Sxcxs0auBfeuChSwk33Y3pn/sByOGMCDkMC3UA=; b=CZHZ05V/4qWoq1IshWQEHh0C15Ooctdf9RzTosSb/DIKo01Kn9KnkqhvKcPU063y+N qHVUxzqVOPX03Uef28nQQQVAL+SBs/wBAJiQdU/fMYG77ZmYvnjdE5Ocij8vqot60keU peXYc3F30rQjc8MlVSPswj2VYNxFgz5hgc2af2Cv+kcKeE9YV+Ribl6EXS44sNZSsSYR 0ricXLs6VMON8lz4QtbcsefK/HEiM9CTQ/qTCOJ3Grvvpre347P7Ulu6t6JR6xJr31fL mqjoeg/4v2waUW93gB2dozRASN2yxOyhWujs4u5TDZY2lrpbYDsuQP/uYBlaRe2IB2W/ D+tw== X-Forwarded-Encrypted: i=1; AJvYcCWk5VwL4+llKr+AxWU7sMHm4QosrcnXdWUxdzlNOCXY/ieDy/NrPlzU+mhEC15UIk19EzcpQy1Zww==@kvack.org X-Gm-Message-State: AOJu0YyA060ymFlGb3ZAm+/ZhcYrKeB9ncHanxc6bJsyZm4T/hcX/D1n Rf9ucmWUF6XktpcwwBEQM4J0Q3Fr7oL9HSOECdmLkZ7gZB+Gs2n7GQxmP7Qto5mUhLn+nHLC+LF /n6cD8tvRqK2OTVXPGBgwIePTI/3Gpd/+6VeNlNf5WTkc6JJeJ8l2DHLW7p6I X-Gm-Gg: ASbGncv6xOWR5IDEFHXrH0mwflx2vMAjooo7tqyUzAtNIPpW5BPc9jLZ+qoSkj2yx9e wDfeBqPv+Ohv9GqLyvUDJoh2xqKLOyQuIHnjtJdas0dsak1WqKcEMKV8OusPGcB7apcwCu5B8Ii Fyfuy9Xr7aw6dtzw3938/jk3p9koGO8HCy47ouarjQB5Dtj5uKNU6/Tiz94qxei/xBVA0j4u3u+ mPcRuFNXS6a82gBIzjjnPuHIPuWdk1aKFvBk8sUrwooUq0XVoOIZsmYcUHmv6sY3evew6GRA+iX gwoOlD/FHMfmdcQetrTtgPteboxfEWwGmi543f+OKzsvrwjw4Lj6WE0vhLlVd9gczsCtThqT5NV N+Z+2WZ6PC1WMk5bOQX3Y4SwDbRt7O16/mXqoAEC59g== X-Received: by 2002:a05:600c:3510:b0:43c:f509:2bbf with SMTP id 5b1f17b1804b1-451f88d836amr75147595e9.15.1749201280316; Fri, 06 Jun 2025 02:14:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkpLXinHXWxiSI+4PvEC2BPCocHHNYP7TvdS/sSVKr19ttFoE6Pj4byntHDslgrPmFOZSX+A== X-Received: by 2002:a05:600c:3510:b0:43c:f509:2bbf with SMTP id 5b1f17b1804b1-451f88d836amr75147145e9.15.1749201279824; Fri, 06 Jun 2025 02:14:39 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce1afasm17541465e9.10.2025.06.06.02.14.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 02:14:39 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 11:14:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 11/18] KVM: x86: Consult guest_memfd when computing max_mapping_level To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250605153800.557144-1-tabba@google.com> <20250605153800.557144-12-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605153800.557144-12-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gNuedjF59psTqzbLvxRvX33Yk2kINTq14xbT70or2hE_1749201280 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: tuxtrwdpqf8th6eecoezk3mcocww8myu X-Rspamd-Queue-Id: 7A222C0004 X-Rspamd-Server: rspam11 X-HE-Tag: 1749201285-887827 X-HE-Meta: U2FsdGVkX19hkq0qKN70prK6pr0DPHlh6roh9d4WDaMBwEJU9gVx/AsfLRqebq458fMyN/BUtRjYJDxcpjwanmZtJLwkth10rCjTi5TFChlz7fT9PRKsOV07+7vKIe8yoqg84F6wvzuPIbrQEDR6bbSyrkRx715+Ag78yZSipq7T8T5lg40BvvFd/5gVA+Z2U180Qayg7NzfvW8AWYBEibHfydjxwlDWS+fmft3rwoj1cc/zBTEc/r0On2SHkzaXIxjuhpGg88lJPDuxgTsSY85OtTtaNySQL/nsSK4V31yPXNGgwwcl7dL5ASPegi46xSEe5LOfGwoJxdfRY8pU4y1uvC0KWDSc3vov8WkD5FaIgnqzjKrw0W87aTJjzSBIW6bX16F43LbJCVqaT/mOvgryfXAPltSUKjxtYP0z6s+M7yZMJ1o1KkboI+AuO++pRCl1vsMMCli+67D+NJ/3sDrquzFslasxEAF13jlvB9wDPt1M9SUYD4QCuZbZOojTabHOe6wW/FwkmSTbsyt366TX6lBxhQZZxJmuvwmWydQWqGPubjhxv/yiXh0vw2RnN3i0HmC4MzDYPqF/GmpGBC80Wm27c1X7sJwO2AtYs5lyji7qkr9t7lxmc75sAhUoEpEUU/1wGTM+jXLJbs9zZ6gedovRD2N0G+Jyjf1jf31vjTPD+XSco4j8+fAFjkuRd31y3EBgcmh5BPj9m/lcpIaBdezfwkJMas5JEpDBn+Qf60wAosuCc7+2lVu0HDUVHHiPdr3++WweVEdcRIA4ETnct4Cl7p4mfq6VwWAEY2tl2LG+GpwMqLYt5ttWLF2tT8yEZm+c3RV4cqywblWXzkVSxVP/Wyu0R+H8EjzmkZ87Beq38xlidPUHmEaZp4eYUeX6ESTHKNKaFeOZXl94w7apOmdAlbzUy+fdrrPG1UTSnhkK8UK1wBFTStJZbN2/ChlSe2he8ri3oNfC7bM tB3lQBJq mngpnsJ57lyxO7srUtkgzDxnTumfL5huEAwb0/7trixocxEa/SCCvzhT8HIADg1r31q/ZmYhMUspzDg8HT5eLUOVF163ega/jh7umKJnhn/FkJCL6Bd8ONlY41/qRoSjCU/xFdvfytmbGTmInS4bbPyqnQFh9PxPyYIhWpQM4mQVKCk1yCjEqpOUqz/cGPBaQujzNGTJ6U7TpaRBHFwLPqS0DoyhAr95+Ttslj8uqmeSXxHto3LJ0VXQoty0pMCNg/3GEM7mxRfHNpMIBUeL8htyETcg11lYToYBcVJ/ioe+KZ0uDldozj1jmLHxoA6C7OSJlNnUC3+ZjBZ5P4qKha8jFDMuz05vp5MEmBDEmrin1arJ0zerTFk+Z8qQ0pDAHlpkAxa4PMx3m6uYIi9k/BpafZZYfpO+7BI4K/neoAVUFomnuJsxdep/HQBAsrMad3Vu13z8IV8K1pJ58tM9cU3AYPcKw6Lq10kAauq62Jq2cqkCBaEYOpYGLWfneoxtuFJGS8EewX/ceBjr+mtJXYRIZUiMHYMorT7SvY+QpdCDBh0Pkh9ec+ebCGAwqWmmkOin6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 17:37, Fuad Tabba wrote: > From: Ackerley Tng > > This patch adds kvm_gmem_max_mapping_level(), which always returns > PG_LEVEL_4K since guest_memfd only supports 4K pages for now. > > When guest_memfd supports shared memory, max_mapping_level (especially > when recovering huge pages - see call to __kvm_mmu_max_mapping_level() > from recover_huge_pages_range()) should take input from > guest_memfd. > > Input from guest_memfd should be taken in these cases: > > + if the memslot supports shared memory (guest_memfd is used for > shared memory, or in future both shared and private memory) or > + if the memslot is only used for private memory and that gfn is > private. > > If the memslot doesn't use guest_memfd, figure out the > max_mapping_level using the host page tables like before. > > This patch also refactors and inlines the other call to > __kvm_mmu_max_mapping_level(). > > In kvm_mmu_hugepage_adjust(), guest_memfd's input is already > provided (if applicable) in fault->max_level. Hence, there is no need > to query guest_memfd. > > lpage_info is queried like before, and then if the fault is not from > guest_memfd, adjust fault->req_level based on input from host page > tables. > > Signed-off-by: Ackerley Tng > Co-developed-by: Fuad Tabba > Signed-off-by: Fuad Tabba > --- [...] > static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) > { > return false; > @@ -2561,6 +2565,7 @@ static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) > int kvm_gmem_get_pfn(struct kvm *kvm, struct kvm_memory_slot *slot, > gfn_t gfn, kvm_pfn_t *pfn, struct page **page, > int *max_order); > +int kvm_gmem_mapping_order(const struct kvm_memory_slot *slot, gfn_t gfn); > #else > static inline int kvm_gmem_get_pfn(struct kvm *kvm, > struct kvm_memory_slot *slot, gfn_t gfn, > @@ -2570,6 +2575,12 @@ static inline int kvm_gmem_get_pfn(struct kvm *kvm, > KVM_BUG_ON(1, kvm); > return -EIO; > } > +static inline int kvm_gmem_mapping_order(const struct kvm_memory_slot *slot, > + gfn_t gfn) > +{ > + BUG(); > + return 0; As raised, no BUG(). If this is unreachable for these configs, BUILD_BUG() might do. Apart from that Acked-by: David Hildenbrand -- Cheers, David / dhildenb