From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AAB8CA9EBE for ; Fri, 25 Oct 2019 08:24:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 404CF21872 for ; Fri, 25 Oct 2019 08:24:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="Kf2QBuVD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 404CF21872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CE79F6B0008; Fri, 25 Oct 2019 04:24:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBE946B000A; Fri, 25 Oct 2019 04:24:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B88746B000C; Fri, 25 Oct 2019 04:24:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 9A0996B0008 for ; Fri, 25 Oct 2019 04:24:50 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 2AB03181AF5C6 for ; Fri, 25 Oct 2019 08:24:50 +0000 (UTC) X-FDA: 76081621140.23.teeth65_8169ef9c2d324 X-HE-Tag: teeth65_8169ef9c2d324 X-Filterd-Recvd-Size: 5746 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Oct 2019 08:24:49 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id a11so1253652wra.6 for ; Fri, 25 Oct 2019 01:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QJej2zrE0QBqg+iZe6C/nm9jF4Wofv1H//Qo71L/Lag=; b=Kf2QBuVDRfq6+w0N7DCDZImKcWFxzkw3pvVhiEdnzg1XkUgGeTTSWLT/AXDil240QQ hoyIRS/bK4lqFnlz87IYHANGs4Xws7dB93EvJssGohry3bsXOshEno6Dqk4BPaPnfpRY MW1z665u1spkHgC4bGahdMT464TLw+1YH8Z8lmyJ1nskaMZZ46OQsKn2jmmBRxe0Ncvr RfQX4whxGZGnyVjXC+tZgkm3LVXnhyuhXcBmsUKSK8o7DckMmoVIGMkNC1lf4WASjicO /1VKnZn2qgrQn2r3sA6XsMoV6YvwKEEDchmOtm6V2itNyqrXRr+3KxQQLEV90vCR7S6U 0kew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QJej2zrE0QBqg+iZe6C/nm9jF4Wofv1H//Qo71L/Lag=; b=eloEdJ9MBUid5chlV873gX0AkTy3lmszHFzvfDJy8vmdMhkIDFYlaw7a321A2e8gd6 8RlzOXmVy9Cj1LxVoojaEJ0fchRMfF/SUI6wffXSqC/LhFA0l2GeLnl03t/OpoviFNLK xUjnre6K3WKBCg1x5jVOtWXjd4DFrDsJzQ/2VQtcUXaqZfJPKvMsCDFj7WkItnkXkX5m FtqUWkmyMl1Ud381d3mmGwRMvn52x2w6rnKVh2jcmzDyq+JKVhlYeIzOW4+KAJm4dOKl Ht+dvdlQuE08M9pC/3n9xGAx1UgXmrrHq7LnweZRH3rtSrzu8M8wmN289QtCfKfxu8ya uJ7g== X-Gm-Message-State: APjAAAUuTNAxMkPIvbdG5ytCQo8mn9gs3nwAXagdCaQsVQw5UHyQDxsQ yLo4bs+FFsK+c5iyqt2O03fjkA== X-Google-Smtp-Source: APXvYqyVbVYhcUVjlWsHAWMsNSTmIYOz09PiXSzKL+kucF3259sySENSkNokb9u6ffLnyHFkS8YN/A== X-Received: by 2002:a5d:4aca:: with SMTP id y10mr1692223wrs.292.1571991887824; Fri, 25 Oct 2019 01:24:47 -0700 (PDT) Received: from [66.102.1.109] ([149.199.62.131]) by smtp.gmail.com with ESMTPSA id b5sm1290058wmj.18.2019.10.25.01.24.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Oct 2019 01:24:47 -0700 (PDT) Subject: Re: [PATCH 06/12] microblaze: use pgtable-nopmd instead of 4level-fixup To: Mike Rapoport , linux-mm@kvack.org Cc: Andrew Morton , Anton Ivanov , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Richard Weinberger , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, sparclinux@vger.kernel.org, Mike Rapoport References: <1571822941-29776-1-git-send-email-rppt@kernel.org> <1571822941-29776-7-git-send-email-rppt@kernel.org> From: Michal Simek Message-ID: Date: Fri, 25 Oct 2019 10:24:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1571822941-29776-7-git-send-email-rppt@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On 23. 10. 19 11:28, Mike Rapoport wrote: > From: Mike Rapoport > > microblaze has only two-level page tables and can use pgtable-nopmd and > folding of the upper layers. > > Replace usage of include/asm-generic/4level-fixup.h and explicit definition > of __PAGETABLE_PMD_FOLDED in microblaze with > include/asm-generic/pgtable-nopmd.h and adjust page table manipulation > macros and functions accordingly. > > Signed-off-by: Mike Rapoport > --- > arch/microblaze/include/asm/page.h | 3 --- > arch/microblaze/include/asm/pgalloc.h | 16 ---------------- > arch/microblaze/include/asm/pgtable.h | 32 ++------------------------------ > arch/microblaze/kernel/signal.c | 10 +++++++--- > arch/microblaze/mm/init.c | 7 +++++-- > arch/microblaze/mm/pgtable.c | 13 +++++++++++-- > 6 files changed, 25 insertions(+), 56 deletions(-) I have take a look at this and when this is applied on the top of 5.4-rc2 there is not a problem. But as was reported by 0-day there is compilation issue on the top of mmotm/master tree and I am able to replicate it. It means there are other changes in Andrew's tree which are causing it. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs