From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7231C71136 for ; Thu, 12 Jun 2025 08:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77E6E6B008C; Thu, 12 Jun 2025 04:52:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7567E6B0092; Thu, 12 Jun 2025 04:52:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 644D46B0096; Thu, 12 Jun 2025 04:52:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 448BF6B008C for ; Thu, 12 Jun 2025 04:52:49 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D784C80732 for ; Thu, 12 Jun 2025 08:52:48 +0000 (UTC) X-FDA: 83546133216.08.6E18C18 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 4834D140004 for ; Thu, 12 Jun 2025 08:52:46 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AL9tPpRE; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749718366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XJuvG2JJZRiHxpRJjWPMD39SwnDPt0ynaH02llGXsIg=; b=FBe20pu4tHWGhiSSGxFKxuSH6ILCBKnIkjAwapd9QZcMrLYOqH5FY2J2rYxglwk4NJBYat XAwUfAWw7OsCmzy6uV3s9p8whXMXinz0z5N3jApN1DHFqy3SoG7znXLdr2VgzW1SFMFw18 BpGbddtc3x9GmsFLweeuudwbmdSCenQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AL9tPpRE; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749718366; a=rsa-sha256; cv=none; b=Rc0bXHGJNvic21zpw+LhlSYrp+o+dp22EuO8UW5VIif2GOlamA17C6jgm6WvICIdXba+xl L33DiD5AEFVTE4hNHqrBe2zApR86lM3KsBmuc5fRTkQbG+4FGFDzU6HVUCTgpeyEhyGFkP LkO+hldv6lOa7wt/xOPqsRVC3utE4tc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749718365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XJuvG2JJZRiHxpRJjWPMD39SwnDPt0ynaH02llGXsIg=; b=AL9tPpREc/0+3bgtscLo6mV8UOIkGv5pXLHKBLlM13Zjwq3mv55sUf6vxm3A+UIjLkNCyp UjU+zUt/mQJqfC1784AUAnwPSe2ZSmTTUQy33eBg6xa0c0UG9f+g7wJKCGjb6ng0DQhgzh qjH3v/dnTOjDgI0P/uyoKL8y/JDYAow= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-ZomymzO-MaGD6z886__AHg-1; Thu, 12 Jun 2025 04:52:44 -0400 X-MC-Unique: ZomymzO-MaGD6z886__AHg-1 X-Mimecast-MFC-AGG-ID: ZomymzO-MaGD6z886__AHg_1749718363 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43eed325461so3706885e9.3 for ; Thu, 12 Jun 2025 01:52:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749718363; x=1750323163; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XJuvG2JJZRiHxpRJjWPMD39SwnDPt0ynaH02llGXsIg=; b=j/iQh6zeH3Bfw6RE0ZuVvDk/inqa0ugZUnB4mlnvpCLmj+n+5JN3ZC562iIBl6SErJ MFWNTqoD2lp1+MvEkkxAwXn7iVqC6Sysr9Fpo7INLTAMbYDGw0ZD/CcRNlTE0wIKFSX4 dvYVcL99aIULOy+XNFjY5NXtymYKizSbC2gHjdE15dfzoHya2wesblUKCnH1nQ3fvhhB Rr00EjaAAutHarqALhTIPaGuW0ovWNRz3feRTdyBIxNnK+2D49GZP0QdIelllVQ0x2Gc lHwqXRPhGWH5z12Io8kHGCoDxnKSK9iFPbN7ov7RsDsDExT22TZvk6PqegoY+rp8QOqD M+hg== X-Forwarded-Encrypted: i=1; AJvYcCXZASeBL6cdLePYeL7eJqdG38GoMDwQPZJsAjn0CfqRIdip10gvmCwix++xUATCkw7OqucwIZJIiw==@kvack.org X-Gm-Message-State: AOJu0YzVRx09IDDE7p5aHSMtcJOZuxI+D9lXydI59OnGnrn1C/OEcU7B Xr+Rtvn60Z/hD/6a1E+0rgArj2NgJ8CcqpcQ0sEY/RvtkooT5VBgLMfpBKcYI/gfhJxU85x1dVc Btxh2g50rDDUeLO8RfPUAcBXtRrpizEgMB/3ew3vBhxR9xjTMpsfX X-Gm-Gg: ASbGncsx2laFocAkRVWIunBshf0EngECHLscV3ZTrn0d2jJArzMoJj/E1005tYyvdlu 1C/FH7KxKT3ZMLkTXGD8Sbp5/ZKDsBGbiLY68V3GkrOwaS4jXE4vez3TeyaBfE3aOPau6x/WnJY RoMP3tv00ZIQyjYAKKFW4pM7ndDgZ1zXFoWekaEGLB4wXXCGMMUktILoU/29h1dUse/YsfIdNWR 5cWKgW+cY+mX6UEHpd2FcXEg43E/JhkCtyhn+SC6P6j2/22C/sBptDh+TaP9eNDhgpUYTmwFQqP MeKTtsELeK2C7vs/RLkbqYm65Z6kKu0RmhnZbewCgLwOgXiccpazTVgywDuQEP3cpIFlFgLgR3j NIesNOWwwqTl8PJr3mMzua+COA/pa+eK6T6AjPb9T0W0oa1F2Sg== X-Received: by 2002:a05:600c:a414:b0:43b:ca39:6c7d with SMTP id 5b1f17b1804b1-4532c12f9c9mr23458875e9.3.1749718362973; Thu, 12 Jun 2025 01:52:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFE0UUZO5fe73LnEJW9DyXc3CItxnfe3KlSS5UEV4EfLKbabjV+SyYwjLpst9ExqQ+P0ZohAQ== X-Received: by 2002:a05:600c:a414:b0:43b:ca39:6c7d with SMTP id 5b1f17b1804b1-4532c12f9c9mr23458505e9.3.1749718362504; Thu, 12 Jun 2025 01:52:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e2446b0sm13430145e9.21.2025.06.12.01.52.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 01:52:42 -0700 (PDT) Message-ID: Date: Thu, 12 Jun 2025 10:52:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled To: Dev Jain , Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8eefb0809c598fadaa4a022634fba5689a4f3257.1749109709.git.baolin.wang@linux.alibaba.com> <1ec368c4-c4d8-41ea-b8a3-7d1fdb3ec358@redhat.com> <2ff65f37-efa9-4e96-9cdf-534d63ff154e@linux.alibaba.com> <40d859c8-f083-4b25-8785-c1023da1c6d8@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <40d859c8-f083-4b25-8785-c1023da1c6d8@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8z8oo9MctnosNr6WSl684XwMiynKAlwAlyM0VPE4PB4_1749718363 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: stcdq3uftagopufwn46mr3q6xmjyxk44 X-Rspamd-Queue-Id: 4834D140004 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749718366-92162 X-HE-Meta: U2FsdGVkX18GEDUvj2WZvMtsXxdwWjHw/zr6bbHOvplXmwctXFBRdxTWsyr2CpnwTluVQisCheVAbm/7STGS1IzUlgVLnirb+vpQg7mT/NhzUrFZsImMc7rfPOO/rbd2tw3/uw8b/ERT8ZeV7v+NGpjg6xK48BIxrK3g1mnUgg2vs++VSzpfEYCV/Nt6eJwHQWNOT32n6ISEyF94C1I93D2l/h5KFAS0Caiq2phBgSG9nmUl/YQXbhHbeltMpmwsr8a03+hy7JeA6EyyyX3P6IqziOL5luPK748i+NAzAWZbvVs3CLtt8y0hfscDc4HCbzyIe89KYHjzLjvVmWPlS3tq415PbfnfcT4V6Vf4lAwX1IRwnJlCI7nVChVIbwnZW07AhxKIWnFZXmDfxgq1q/X82XVI5wXYMGcqVlvVVKhOZfaac2xbEZQtlyxTqfWEH49paP9yrm6qjM4fzSBC2sFrSqjLG3QgUemvamVz+ltRUivms2C527G7faFVEt9McCSG+LQ1PbmyrGL2VSVyo5GmWObnqrsAyH9HZrSU3JwWVqvKMLfdDAzoCRkvLPUg1OgO6Xj/J4ptzxX0giQSR4NTK1Lb0nYxJNGQEiRI7FaVVIFGA1RKFxVyO8c+ew8jo8vjQWKxS5O5oQh2Vx2zxMz2VSD3PEbPbYNL5KBZsyKWVooae3bqAgZPXkjkEVL9EVKt2QSxQQUkM3ZGBBaceMteNaH+b+z3Y4+xuRpbs2mHl/PKNnn+PjcN1tJ1HTc2Ruj+scu3Hcb32pkOgUEm6i8Bg9leil+bWNge82R2VTwS9C9zIv2QmuV5xbGysyQcsOceqTKuKK/3rNM4IugJKrfzd/M00qICq83iOmi1Vf7A8A5EUyjJghjS5i9TQC+5u0BMMKTHWBq2S7cwzcCeL5AqDwAdrJO7CgIahDcYE1mLASCEuvDaTw4vVMfWuaaTKgZlVhXVMdY2IBfR1oS 33eLQTR8 R8MjiG/DBSIrSdFhmnZggX9/v32MHWy99/jzNwguL1Lt5XsBwOJmRRr9UHM4sQtF6OjbXuiKAMiwR2W5hTtNCkZsr01PiTpPNfmwsaQnTdJO4J4yXaJTQuggL+QVTHz85V8SYk0RT00/OYfcDDmtXjtUupkH9Wa6N7+g5pvy+p3bPs6qsLdufZeCju0JfGbRmhzcx9SHvC3Yx5LNPtjQYe1PYtBmUcdNNtIHBBzRDiy33VMNUvYrPsFbCzY2Q4tMwnpR6RCCdqzihg/Q583pKcW3Emi+912+vfjkHt+zRSgNbIbKCoj1323wHcREYxhiPPxswZ+Fs3vLi6LWsUArCnZA4HpMle8r5O0l4rdAKgvI1EpPz4gVkZLFiwIytfJ1lV4tBlUc+I1xf/ZFOXDduVQADieexJU5CeFYJlWqYeWzZlbobhiehoYXRwndRscanSRIGafTjpMGDPNPYYjRpe8Ca1SsZr5FXasMU4pUTdsW4aaOvtaKirEFdjktEfPXEcvykDckJt0pbL8cIVEGe/WVMvBUWp1J6Aohv5nMypg/M4hfZB+O9bnZ9yurMAOOL3RvU+sZyy9SZUl6C67uMV8pLqxHt4n8sMA/yqflWwPUL3UwTEhNA887svXxYg0ly2BCvVq8M/aOSQM4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 10:46, Dev Jain wrote: > > On 12/06/25 1:21 pm, Baolin Wang wrote: >> >> >> On 2025/6/11 20:34, David Hildenbrand wrote: >>> On 05.06.25 10:00, Baolin Wang wrote: >>>> The MADV_COLLAPSE will ignore the system-wide Anon THP sysfs >>>> settings, which >>>> means that even though we have disabled the Anon THP configuration, >>>> MADV_COLLAPSE >>>> will still attempt to collapse into a Anon THP. This violates the >>>> rule we have >>>> agreed upon: never means never. >>>> >>>> Another rule for madvise, referring to David's suggestion: “allowing >>>> for collapsing >>>> in a VM without VM_HUGEPAGE in the "madvise" mode would be fine". >>>> >>>> To address this issue, should check whether the Anon THP >>>> configuration is disabled >>>> in thp_vma_allowable_orders(), even when the TVA_ENFORCE_SYSFS flag >>>> is set. >>>> >>>> In summary, the current strategy is: >>>> >>>> 1. If always & orders == 0, and madvise & orders == 0, and >>>> hugepage_global_enabled() == false >>>> (global THP settings are not enabled), it means mTHP of that orders >>>> are prohibited >>>> from being used, then madvise_collapse() is forbidden for that orders. >>>> >>>> 2. If always & orders == 0, and madvise & orders == 0, and >>>> hugepage_global_enabled() == true >>>> (global THP settings are enabled), and inherit & orders == 0, it >>>> means mTHP of that >>>> orders are still prohibited from being used, thus madvise_collapse() >>>> is not allowed >>>> for that orders. >>>> >>>> Reviewed-by: Zi Yan >>>> Signed-off-by: Baolin Wang >>>> --- >>>>   include/linux/huge_mm.h | 23 +++++++++++++++++++---- >>>>   1 file changed, 19 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>>> index 2f190c90192d..199ddc9f04a1 100644 >>>> --- a/include/linux/huge_mm.h >>>> +++ b/include/linux/huge_mm.h >>>> @@ -287,20 +287,35 @@ unsigned long thp_vma_allowable_orders(struct >>>> vm_area_struct *vma, >>>>                          unsigned long orders) >>>>   { >>>>       /* Optimization to check if required orders are enabled early. */ >>>> -    if ((tva_flags & TVA_ENFORCE_SYSFS) && vma_is_anonymous(vma)) { >>>> -        unsigned long mask = READ_ONCE(huge_anon_orders_always); >>>> +    if (vma_is_anonymous(vma)) { >>>> +        unsigned long always = READ_ONCE(huge_anon_orders_always); >>>> +        unsigned long madvise = READ_ONCE(huge_anon_orders_madvise); >>>> +        unsigned long inherit = READ_ONCE(huge_anon_orders_inherit); >>>> +        unsigned long mask = always | madvise; >>>> + >>>> +        /* >>>> +         * If the system-wide THP/mTHP sysfs settings are disabled, >>>> +         * then we should never allow hugepages. >>>  > +         */> +        if (!(mask & orders) && >>> !(hugepage_global_enabled() && (inherit & orders))) >>>> +            return 0; >>> >>> I'm still trying to digest that. Isn't there a way for us to work >>> with the orders, >>> essentially masking off all orders that are forbidden globally. >>> Similar to below, if !orders, then return 0? >>> /* Orders disabled directly. */ >>> orders &= ~TODO; >>> /* Orders disabled by inheriting from the global toggle. */ >>> if (!hugepage_global_enabled()) >>>      orders &= ~READ_ONCE(huge_anon_orders_inherit); >>> >>> TODO is probably a -1ULL and then clearing always/madvise/inherit. >>> Could add a simple helper for that >>> >>> huge_anon_orders_never >> >> I followed Lorenzo's suggestion to simplify the logic. Does that look >> more readable? >> >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >> index 2f190c90192d..3087ac7631e0 100644 >> --- a/include/linux/huge_mm.h >> +++ b/include/linux/huge_mm.h >> @@ -265,6 +265,43 @@ unsigned long __thp_vma_allowable_orders(struct >> vm_area_struct *vma, >>                                          unsigned long tva_flags, >>                                          unsigned long orders); >> >> +/* Strictly mask requested anonymous orders according to sysfs >> settings. */ >> +static inline unsigned long __thp_mask_anon_orders(unsigned long >> vm_flags, >> +                               unsigned long tva_flags, unsigned long >> orders) >> +{ >> +       unsigned long always = READ_ONCE(huge_anon_orders_always); >> +       unsigned long madvise = READ_ONCE(huge_anon_orders_madvise); >> +       unsigned long inherit = READ_ONCE(huge_anon_orders_inherit); >> +       bool inherit_enabled = hugepage_global_enabled(); >> +       bool has_madvise =  vm_flags & VM_HUGEPAGE; > > Let us name this honour_madvise to indicate that this VMA must honour > the madvise setting. Not clear, because there is also "VM_NOHUGEPAGE" :/ See my reply where we maybe (if I got it right) only need a single check and can just avoid a confusing temporary variable completely. -- Cheers, David / dhildenb