From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com,
Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
dev.jain@arm.com, ziy@nvidia.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mm: shmem: disallow hugepages if the system-wide shmem THP sysfs settings are disabled
Date: Mon, 9 Jun 2025 14:34:22 +0800 [thread overview]
Message-ID: <aa6aa559-431e-43c0-bd24-828e6558bac3@linux.alibaba.com> (raw)
In-Reply-To: <b455db10-f129-4603-a087-43a1b52ff09c@lucifer.local>
On 2025/6/7 20:17, Lorenzo Stoakes wrote:
> On Sat, Jun 07, 2025 at 01:14:41PM +0100, Lorenzo Stoakes wrote:
>> On Thu, Jun 05, 2025 at 04:00:59PM +0800, Baolin Wang wrote:
> [snip]
>>>
>>> Another rule for madvise, referring to David's suggestion: “allowing for collapsing
>>> in a VM without VM_HUGEPAGE in the "madvise" mode would be fine".
>>
>> Hm I'm not sure if this is enforced is it? I may have missed something here
>> however.
>
> Oh right actually I think it is implicitly - if TVA_ENFORCE_SYSFS is not
> specified in tva_flags, then we don't bother applying an madvise filter at all
> anyway, and we account for that in our 'enabled' check in
> thp_vma_allowable_orders().
>
> But I don't think this patch changes anything, I actually _think_ we can just
> drop this one.
See my previous replies. Shmem mTHP sysfs settings are different from
Anonymous pages.
Thanks for reviewing.
next prev parent reply other threads:[~2025-06-09 6:34 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 8:00 [PATCH v2 0/2] fix MADV_COLLAPSE issue if THP " Baolin Wang
2025-06-05 8:00 ` [PATCH v2 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs " Baolin Wang
2025-06-06 16:49 ` Dev Jain
2025-06-06 18:47 ` Dev Jain
2025-06-09 5:57 ` Baolin Wang
2025-06-07 11:55 ` Lorenzo Stoakes
2025-06-07 12:21 ` Lorenzo Stoakes
2025-06-09 6:18 ` Baolin Wang
2025-06-09 15:12 ` Lorenzo Stoakes
2025-06-09 6:10 ` Baolin Wang
2025-06-09 15:17 ` Lorenzo Stoakes
2025-06-11 6:59 ` Baolin Wang
2025-06-08 18:37 ` Nico Pache
2025-06-09 6:36 ` Baolin Wang
2025-06-11 12:34 ` David Hildenbrand
2025-06-12 7:51 ` Baolin Wang
2025-06-12 8:46 ` Dev Jain
2025-06-12 8:52 ` David Hildenbrand
2025-06-12 8:51 ` David Hildenbrand
2025-06-12 12:45 ` Baolin Wang
2025-06-12 13:05 ` David Hildenbrand
2025-06-12 13:25 ` Baolin Wang
2025-06-12 13:40 ` Baolin Wang
2025-06-12 13:27 ` Lorenzo Stoakes
2025-06-12 13:29 ` Lorenzo Stoakes
2025-06-12 14:13 ` Baolin Wang
2025-06-12 14:16 ` David Hildenbrand
2025-06-12 14:20 ` Lorenzo Stoakes
2025-06-12 14:09 ` David Hildenbrand
2025-06-12 14:49 ` Lorenzo Stoakes
2025-06-13 2:07 ` Baolin Wang
2025-06-13 5:18 ` Lorenzo Stoakes
2025-06-12 13:07 ` Lorenzo Stoakes
2025-06-12 13:13 ` David Hildenbrand
2025-06-12 13:31 ` Lorenzo Stoakes
2025-06-05 8:00 ` [PATCH v2 2/2] mm: shmem: disallow hugepages if the system-wide shmem " Baolin Wang
2025-06-07 12:14 ` Lorenzo Stoakes
2025-06-07 12:17 ` Lorenzo Stoakes
2025-06-09 6:34 ` Baolin Wang [this message]
2025-06-09 19:30 ` Lorenzo Stoakes
2025-06-09 6:31 ` Baolin Wang
2025-06-09 15:33 ` Lorenzo Stoakes
2025-06-11 7:02 ` Baolin Wang
2025-06-07 12:28 ` [PATCH v2 0/2] fix MADV_COLLAPSE issue if THP " Lorenzo Stoakes
2025-06-11 7:05 ` Baolin Wang
2025-06-13 14:23 ` Usama Arif
2025-06-13 14:29 ` Lorenzo Stoakes
2025-06-13 14:39 ` Usama Arif
2025-06-13 14:42 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6aa559-431e-43c0-bd24-828e6558bac3@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox