From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53A8FC83F17 for ; Fri, 11 Jul 2025 01:57:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA48A8D0008; Thu, 10 Jul 2025 21:57:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E55438D0001; Thu, 10 Jul 2025 21:57:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44B18D0008; Thu, 10 Jul 2025 21:57:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C2C888D0001 for ; Thu, 10 Jul 2025 21:57:34 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9FC981A12D8 for ; Fri, 11 Jul 2025 01:57:34 +0000 (UTC) X-FDA: 83650322028.11.63C27A5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id E7F6C4000B for ; Fri, 11 Jul 2025 01:57:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AmQHu3Fm; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of alx@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752199053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f7V0UXpqm2+kx37h0QSk+F+9RqgBVa4RJTJIm9NL4M8=; b=xMuJc68sGArbqu7jepcOoSUW85DCut8FtaDgujuQdE1kY9JOjbD5OH1KwsTX7mFc/pnHQV Ezf+h8rKhOW1Uh16QXaJsnDTD59mFCHa5hk/75QjxgCuxyQn38bkXBItneMsZQmXdZZwk9 +3E+i4B1QRRdXhond7xElW8MLBAIcOg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AmQHu3Fm; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of alx@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752199053; a=rsa-sha256; cv=none; b=WO0uQfAxfYGBlo15xlIJolPFbS+kncW9Z3tm8gTk1gysOolyStKmW75IZGYmMEuHntYtt1 K9dT7TgwaRS/DiWzpu3WUpjBVsszt+0QzvMBp/ZWlTzdhLA+PDh1RhCq/Oq7KQ51sddfjz qZQNvuWcoK0lijZFOO9aJz4lbeJd0E0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 133855C6F23; Fri, 11 Jul 2025 01:57:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A25DC4CEE3; Fri, 11 Jul 2025 01:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752199051; bh=VJYVfYb5aKbK4eQQkUA5lmVUT/3A2ehIMDd21vB14NU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AmQHu3FmSKNE0tW16KCLyS8PJ9u6i78loWUZWX6+tH+CUGh4xEzytl97R4ZQpudFK BrdiZKCqo+h8P1sBvWX5rVtOFes4MXbSKzp9Kn/DVBNAQVW/hByQhmwtso4NBaUJRF LjjQIdOxVuXrdr5qARCLtddx5TbJfIGpbN4OlKK7AYuuhcL24ILD05MUwFly7Hkgg0 Z8mVmdu2tAMjeHqOnFhnS+nnSTpH+Grgp4h60slJPRmHHO5GJGbHwh21zrMr6LBrwW JwHXpV18Bu/u7hdCNe6C0kAA5VWZW7mKF5H4R2mJUSnrcnxULXhcw6FAfOeqA0qx4U gFl9a2897/KEw== Date: Fri, 11 Jul 2025 03:57:25 +0200 From: Alejandro Colomar To: linux-mm@kvack.org, linux-hardening@vger.kernel.org Cc: Alejandro Colomar , Kees Cook , Christopher Bazley , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Rasmus Villemoes , Michal Hocko , Linus Torvalds , Al Viro , Martin Uecker , Sam James , Andrew Pinski Subject: [RFC v6 8/8] mm: Use [v]sprintf_array() to avoid specifying the array size Message-ID: X-Mailer: git-send-email 2.50.0 References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E7F6C4000B X-Stat-Signature: ih98esi4ed5ck4zmsptrzp5bfpr1896j X-Rspam-User: X-HE-Tag: 1752199052-188989 X-HE-Meta: U2FsdGVkX1+zHGTkgmbBG5TiIMwysVDpPpK8rfGVg5feLq9WSHqW9RH4CWjw94WM2r04WINtllGi6VyOusQTjsHSSUkBaJLdMemSJrxtL7+Zmyl8ACNP8hQkpMqFQxsp7FH7uHe1WK2PS0vQgZ6a7ZzdYA1Ttcd9AxNDUxIgkXARSB1sL+UYiVgkQRnEzusbSmAjWLZF7wG12MKiH5CNn5kJVoH+nB1Wb4DlLmRIxD/ytCzlCyT70WVn1bI/dbijub1UaVpPq1pPziupOJnJCf7bhFX5+sKFRaS1WobHjIt1C7lZVkB/stl3oxM1Kjku6FxWG3et7YVNfqHeHAIR1i/Zi7eFJlvX185LutXRdRtdOXTOclq/cGn9MggJBshZjnHkGv45BHF5RsOaMVPaZnN3jNht7CJMZn8yjXaSKbSF1eRBkNEhHrj/43o3ZANsWQTP/KVokyyGUSRSiQve6T2kmOYNOzewNFcX+C/VQZSdGEwCJ3I0UWyVSBHhvlMjmCZYZInjX2XfmTamhtbnKKGODiiNMxfhE8NggpN4BD0qXbtWQvq2elUu6YSo8TV5wYiejA7X+AmHkATEnXKaS9OgjOFA48/lvQbmS5ns+0VfH7sshrO8M52HhqRCrlDKi8A4HE/DsW1ULw6JM1aKujGhEsOrE7i8dnIZ/u7E5hoTB0bSrHFKQ3BHtN4rtZ64DBLHBcn+AhwAgwx05Lz/kUn0WWGhbuXbpsLjYYzEP63LDytCohKAGRhcVWPtiUq3qnECV5aYtYPWIKoXoMlHWLavI7zm1i0lMggUB0IGUN2gVoXs/0nwPYFBk3AYsSRTEBHxkTlMjUBGKiLkA8CrmZ3eMSzUZIBXdOn67/GzjssKNqNXAhdX8JKbM9B/8AuMgqU/8H1APE+QmXbC62iWcmiGQ2sliuHPaDT0qTZLsIA+RnrcTmG2NU+cJC+zGUsZYokqkYAMUpcuhvnQy6l Mcox05yJ BuO3JelJXyO7Yyy+iUvqiNNWgl+oWOJKSXHj4DKcFm/wdz2nayei8x2MdAwqHpAm+Du9bCr2t2qmzJVj6CuQ9xVDrRlh0LiH7+nXCDnqJbAIOQtmSVpYaEV6ZnEPRFTN7T6PG5P9SuueBefLww7G/I0dkKu3/nnNvOcyinpbjfJ8d6rh9IyykCGTfynnxUOP9yv9kKwvvzR/WRcG//iw0Ql/GUWqfIIFgGLYFjcxyl2vAkvx00uLXxMfNJUibNQHmzqUmJr1qLXjlKECCkEHXMDOYzrrdG78FF6XwXKgP9coS0wZYJCVk8mkP27n4zRKM5lJ9iBWu5cxiM/cAjdG2WnspsbJ4AVv3HLMfrqmvRnRLOXc7pZUfspXQXRNhSTnNmkrpuJOA0OSKL4UE7djijGq11UON7V2vtf5jVqhUus61Zrt9sxQEV9VnHc7vxtEpb7q4RJL1LhYzhEfxddjbdihhQy6ar2sqFlOF9SealwnKBuSpnWdQhvAh1MCBI48mwLE2Z+ZfbiKCmYbjoe4Ord65oEf8pc7czBevvnrROYYwvsCWkwbXrU552j0+vk/w+WCQmICO3yI49oH6UFI5rV6WOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Cc: Rasmus Villemoes Cc: Marco Elver Cc: Michal Hocko Cc: Linus Torvalds Cc: Al Viro Signed-off-by: Alejandro Colomar --- mm/backing-dev.c | 2 +- mm/cma.c | 4 ++-- mm/cma_debug.c | 2 +- mm/hugetlb.c | 3 +-- mm/hugetlb_cgroup.c | 2 +- mm/hugetlb_cma.c | 2 +- mm/kasan/report.c | 3 +-- mm/memblock.c | 4 ++-- mm/percpu.c | 2 +- mm/shrinker_debug.c | 2 +- mm/zswap.c | 2 +- 11 files changed, 13 insertions(+), 15 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index 783904d8c5ef..c4e588135aea 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -1090,7 +1090,7 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args) if (bdi->dev) /* The driver needs to use separate queues per device */ return 0; - vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args); + vsprintf_array(bdi->dev_name, fmt, args); dev = device_create(&bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name); if (IS_ERR(dev)) return PTR_ERR(dev); diff --git a/mm/cma.c b/mm/cma.c index c04be488b099..61d97a387670 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -237,9 +237,9 @@ static int __init cma_new_area(const char *name, phys_addr_t size, cma_area_count++; if (name) - snprintf(cma->name, CMA_MAX_NAME, "%s", name); + sprintf_array(cma->name, "%s", name); else - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); + sprintf_array(cma->name, "cma%d\n", cma_area_count); cma->available_count = cma->count = size >> PAGE_SHIFT; cma->order_per_bit = order_per_bit; diff --git a/mm/cma_debug.c b/mm/cma_debug.c index fdf899532ca0..751eae9f6364 100644 --- a/mm/cma_debug.c +++ b/mm/cma_debug.c @@ -186,7 +186,7 @@ static void cma_debugfs_add_one(struct cma *cma, struct dentry *root_dentry) rangedir = debugfs_create_dir("ranges", tmp); for (r = 0; r < cma->nranges; r++) { cmr = &cma->ranges[r]; - snprintf(rdirname, sizeof(rdirname), "%d", r); + sprintf_array(rdirname, "%d", r); dir = debugfs_create_dir(rdirname, rangedir); debugfs_create_file("base_pfn", 0444, dir, &cmr->base_pfn, &cma_debugfs_fops); diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 6a3cf7935c14..70acc8b3cbb8 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4780,8 +4780,7 @@ void __init hugetlb_add_hstate(unsigned int order) for (i = 0; i < MAX_NUMNODES; ++i) INIT_LIST_HEAD(&h->hugepage_freelists[i]); INIT_LIST_HEAD(&h->hugepage_activelist); - snprintf(h->name, HSTATE_NAME_LEN, "hugepages-%lukB", - huge_page_size(h)/SZ_1K); + sprintf_array(h->name, "hugepages-%lukB", huge_page_size(h)/SZ_1K); parsed_hstate = h; } diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c index 58e895f3899a..0953cea93759 100644 --- a/mm/hugetlb_cgroup.c +++ b/mm/hugetlb_cgroup.c @@ -822,7 +822,7 @@ hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft, for (i = 0; i < tmpl_size; cft++, tmpl++, i++) { *cft = *tmpl; /* rebuild the name */ - snprintf(cft->name, MAX_CFTYPE_NAME, "%s.%s", buf, tmpl->name); + sprintf_array(cft->name, "%s.%s", buf, tmpl->name); /* rebuild the private */ cft->private = MEMFILE_PRIVATE(idx, tmpl->private); /* rebuild the file_offset */ diff --git a/mm/hugetlb_cma.c b/mm/hugetlb_cma.c index e0f2d5c3a84c..bae82a97a43c 100644 --- a/mm/hugetlb_cma.c +++ b/mm/hugetlb_cma.c @@ -211,7 +211,7 @@ void __init hugetlb_cma_reserve(int order) size = round_up(size, PAGE_SIZE << order); - snprintf(name, sizeof(name), "hugetlb%d", nid); + sprintf_array(name, "hugetlb%d", nid); /* * Note that 'order per bit' is based on smallest size that * may be returned to CMA allocator in the case of diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 8357e1a33699..3b40225e7873 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -486,8 +486,7 @@ static void print_memory_metadata(const void *addr) char buffer[4 + (BITS_PER_LONG / 8) * 2]; char metadata[META_BYTES_PER_ROW]; - snprintf(buffer, sizeof(buffer), - (i == 0) ? ">%px: " : " %px: ", row); + sprintf_array(buffer, (i == 0) ? ">%px: " : " %px: ", row); /* * We should not pass a shadow pointer to generic diff --git a/mm/memblock.c b/mm/memblock.c index 0e9ebb8aa7fe..3eea7a177330 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2021,7 +2021,7 @@ static void __init_memblock memblock_dump(struct memblock_type *type) flags = rgn->flags; #ifdef CONFIG_NUMA if (numa_valid_node(memblock_get_region_node(rgn))) - snprintf(nid_buf, sizeof(nid_buf), " on node %d", + sprintf_array(nid_buf, " on node %d", memblock_get_region_node(rgn)); #endif pr_info(" %s[%#x]\t[%pa-%pa], %pa bytes%s flags: %#x\n", @@ -2379,7 +2379,7 @@ int reserve_mem_release_by_name(const char *name) start = phys_to_virt(map->start); end = start + map->size - 1; - snprintf(buf, sizeof(buf), "reserve_mem:%s", name); + sprintf_array(buf, "reserve_mem:%s", name); free_reserved_area(start, end, 0, buf); map->size = 0; diff --git a/mm/percpu.c b/mm/percpu.c index b35494c8ede2..a467102c2405 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -3186,7 +3186,7 @@ int __init pcpu_page_first_chunk(size_t reserved_size, pcpu_fc_cpu_to_node_fn_t int upa; int nr_g0_units; - snprintf(psize_str, sizeof(psize_str), "%luK", PAGE_SIZE >> 10); + sprintf_array(psize_str, "%luK", PAGE_SIZE >> 10); ai = pcpu_build_alloc_info(reserved_size, 0, PAGE_SIZE, NULL); if (IS_ERR(ai)) diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c index 20eaee3e97f7..f529ac29557c 100644 --- a/mm/shrinker_debug.c +++ b/mm/shrinker_debug.c @@ -176,7 +176,7 @@ int shrinker_debugfs_add(struct shrinker *shrinker) return id; shrinker->debugfs_id = id; - snprintf(buf, sizeof(buf), "%s-%d", shrinker->name, id); + sprintf_array(buf, "%s-%d", shrinker->name, id); /* create debugfs entry */ entry = debugfs_create_dir(buf, shrinker_debugfs_root); diff --git a/mm/zswap.c b/mm/zswap.c index 204fb59da33c..e66b5c5b1ecf 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -271,7 +271,7 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor) return NULL; /* unique name for each pool specifically required by zsmalloc */ - snprintf(name, 38, "zswap%x", atomic_inc_return(&zswap_pools_count)); + sprintf_array(name, "zswap%x", atomic_inc_return(&zswap_pools_count)); pool->zpool = zpool_create_pool(type, name, gfp); if (!pool->zpool) { pr_err("%s zpool not available\n", type); -- 2.50.0