From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7277C77B7C for ; Tue, 25 Apr 2023 17:45:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 343376B0071; Tue, 25 Apr 2023 13:45:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F2B76B0072; Tue, 25 Apr 2023 13:45:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E28A6B0074; Tue, 25 Apr 2023 13:45:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0EE0D6B0071 for ; Tue, 25 Apr 2023 13:45:27 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5442C02CD for ; Tue, 25 Apr 2023 17:45:26 +0000 (UTC) X-FDA: 80720640252.06.A37BB5A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 1C405C0021 for ; Tue, 25 Apr 2023 17:45:23 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HvLIP+2X; spf=pass (imf10.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682444724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G0CBe2FuGLKiF6+7JwAoMc/gjfgOjJWrWMRZVPEMSv8=; b=UZqXEZQPJs46ieVSIkbPvr4SgWr6K6gDNFOE2yX44LIcEPa0Y9AeNT7k5gHMvg3KKWERs8 abUABqetWHczcawK7Ij7muCSL0IGq5AF47os27LEtoq7NnTCm/nGI1KmkKR5IoVFd9jJqu FsqNeJXOfMw/v/r7hZP6DTq12ANCBrU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HvLIP+2X; spf=pass (imf10.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682444724; a=rsa-sha256; cv=none; b=ZZml6TzHx8mdPzV+adrJTdjil2b1kNL3e+3NKb+y1/KJOq/OjcVSO++Sfv+Fh/1PsOYvl6 KaXv6WbTHeZhyycq5vg0MzoDqS4ZI+xkzp4PSbNF38RIqWwQRQHsnlQt2S2sR5CMGefSOW U95XwaZYXIEnOaNfKYUL45TOjX2V2fY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0191760FE5; Tue, 25 Apr 2023 17:45:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 086B6C433EF; Tue, 25 Apr 2023 17:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682444722; bh=UetGMwdP/tJrV8Yar8w3RMh5cMJTojk25/r7z2kcvRU=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=HvLIP+2XBMjvYn4QXFyN8ilV9wqrHd8tSi2COur0+kfILmSIGtIutF9kne4MM5yjY G5hUsYOpqizVtkL9O9FT3G8B1OGIe8ep4V3SfdGBLLEkEmgYUSedAc81RFyFbryW3c f5z+iilG2EcmnGH6LaChNt21Wm8OlGjUw8J1P5JcowZAZjVi8wF1czTA8JxvXsoDSM XZt+K3PB/fgOG7oktH+1iCZrVeOazyhiekMbfQkA7NWiovV4ugbexbSHZ88n7acfWl KC4Y5PvwicwYLcAbql/jy0qtE34PWuU9tiyDRD/OWzCEjHIJTz2DFzg+Axj3tkl0fv V7nFvWGdknCSQ== Message-ID: Subject: Re: [PATCH v2 1/3] fs: add infrastructure for multigrain inode i_m/ctime From: Jeff Layton To: NeilBrown Cc: Alexander Viro , Christian Brauner , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , Dave Chinner , Chuck Lever , Jan Kara , Amir Goldstein , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Date: Tue, 25 Apr 2023 13:45:19 -0400 In-Reply-To: <168237601955.24821.11999779095797667429@noble.neil.brown.name> References: <20230424151104.175456-1-jlayton@kernel.org> , <20230424151104.175456-2-jlayton@kernel.org> , <168237287734.24821.11016713590413362200@noble.neil.brown.name> , <404a9a8066b0735c9f355214d4eadf0d975b3188.camel@kernel.org> <168237601955.24821.11999779095797667429@noble.neil.brown.name> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0 (3.48.0-1.fc38) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1C405C0021 X-Stat-Signature: a9xh6ywfpbioyyfeqj86i713ijyr8w9y X-HE-Tag: 1682444723-28931 X-HE-Meta: U2FsdGVkX1/zckLG0a6UEYQ2FWL7uAOGvuRDos+x1VZjHZCek5Ih8fhRvm+1TVZR5CYFgNbrjYzsPqz0DO7lwzKInuSwO7CgxbfE6QKiNWzl3879KKAasQfFs8PwBrCgxATTImqeVhvfN3Z+LzhnAZAWpsvOfUUWTG77NrLZBSvwR4+VrqdyHzyl0ZXCQlf+nEOUGZ/4FJGrbZdh2RqFNxb5usvsKBMp79COHzXpvX3P4ay6hwB37JsAG3+CB8v2fJi+xb4TZOGn9eGncHsXQ69ooNtrHJoF1j2BEIQanEVVLMNkGxj0Mgerschg2y9pTh6Kc6293odu2+3nBLPAmShAnUSx3jEfXFQqG5l52+wR/V86KE9wUkhBQuuXvndX0McE3gD6DoZt7l/LXiPLw71HsIf0DfB8vaPovm6mD/eVrWCqAzdinJvV8Cxkwz4DUzaue9oYt0AmxTZWatqn5NIb3XPRVxkau0hrk1LBQySwQha0c09Yri90E4SJU6cAVeBDgwYaTQvEy90ULMXSWiU0BJBBCk094QqejOecY1eUmJJ5zxwLEqICusc56wsQ9tD66PVTVGV+MBqGdrNMc6R8cfy6npY1aFOvVdy47k9WjqLuSpeYC+yirU4hmY4MaZY8L0E+e7p7Y9m/Dg6i5IpGO9haLSGgONe48kw4WqIBrLhw3NrryeCoFILiOeKEvXN/CMbiJvYdslhCMb7DPsF0VvHgtl6XBtsbdmER/OqHQFKhLdK6+Wd8GzmXmAVZ3sbGR2Mj6wsRxCUzIbqQ4k0ViqU/6IVfmIitXHzag7hrHc6O89LBeC9g8RqqhFj4LSUEdv9MgIxuDrQCcnkgx55m+8d3+8mDoQUHMYfFGqXVqoFSMZH+uQbrItO7jfOUIp5rFkpolrufPQXFLufSatWGCNlHRgTycJa/NqrQRG9IPOKnobf/TNk7fSixEZrfjdc8mtvR2IvBqbnEXr2 PEwFsLLo 75FYPERGOTvr5EOwFDaTt3yXfjikbphNQSb7yRtzBUpu21wUM0cx+d3JUEX+l+m+KeeJi6V77fNhsOAWPc8wZ99odztg5kA5q4Fxr8mTwlMeLXtZy3BLeCCWaaF76E0BSWGOrdO0r3DscsX9MGF+tcwR1Z3xq6EaZEYoG8ZpP+lPDDT1d1MnOP5/BF6lj3Hy34a4epSkTo9HVzkNQ9faYJK0IyuHPIDFHFXiyqD3+O9/yTNsWM85O47yPfgYjTW5WMd77HQBqISoEPsTfp2+LwNwbyBMLxxch0kJVKO2Q5BCuhXnQNUHQYiND5b8veKdFgGTGJw1kn8IjDK3SjKJMCxxeV0zj1Vvm9/1FJFVSgTnuptSWj+R/rKKT3RSqYgUBI04Uzg5oTsYzqdo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2023-04-25 at 08:40 +1000, NeilBrown wrote: > On Tue, 25 Apr 2023, Jeff Layton wrote: > > On Tue, 2023-04-25 at 07:47 +1000, NeilBrown wrote: > > > On Tue, 25 Apr 2023, Jeff Layton wrote: > > > > + /* > > > > + * Warn if someone sets SB_MULTIGRAIN_TS, but doesn't turn down t= he ts > > > > + * granularity. > > > > + */ > > > > + return (sb->s_flags & SB_MULTIGRAIN_TS) && > > > > + !WARN_ON_ONCE(sb->s_time_gran =3D=3D 1); > > >=20 > > > Maybe=20 > > > !WARN_ON_ONCE(sb->s_time_gran & SB_MULTIGRAIN_TS); > > > ?? > > >=20 > >=20 > > I'm not sure I understand what you mean here. >=20 > That's fair, as what I wrote didn't make any sense. > I meant to write: >=20 > !WARN_ON_ONCE(sb->s_time_gran & I_CTIME_QUERIED); >=20 > to make it explicit that s_time_gran must leave space for > I_CTIME_QUERIED to be set (as you write below). Specifically that > s_time_gran mustn't be odd.=20 > =20 Erm...it may be an unpopular opinion, but I find that more confusing than just ensuring that the s_time_gran > 1. I keep wondering if we might want to carve out other low-order bits too for some later purpose, at which point trying to check this using flags wouldn't work right. I think I might just stick with what I have here, at least for now. --=20 Jeff Layton