From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA78EC54E94 for ; Wed, 25 Jan 2023 14:32:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDEEC6B0071; Wed, 25 Jan 2023 09:32:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D90206B0072; Wed, 25 Jan 2023 09:32:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C092B6B0073; Wed, 25 Jan 2023 09:32:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B10126B0071 for ; Wed, 25 Jan 2023 09:32:12 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 67867160C4F for ; Wed, 25 Jan 2023 14:32:12 +0000 (UTC) X-FDA: 80393561304.22.867F43E Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf16.hostedemail.com (Postfix) with ESMTP id 33E58180019 for ; Wed, 25 Jan 2023 14:32:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=6TUazUJS; spf=pass (imf16.hostedemail.com: domain of axboe@kernel.dk designates 209.85.216.41 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674657130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TSv8WpaqrU88nGheGtiai7Y/5wRVY8MkM9KRN4G+ukg=; b=2RHDj0oMT91PDSMbrNkRvE/SSbc1uwC/YuJqoVNwlbiAc66RRImhJ/rn2k8CHAccATZuZw Awy0viTlMxag0OrEd4/IQc6SPjwEEyVsIjzx+SPNhraUEB5yK/YEiYqNCaSD8CoMr4lJf/ Hj9e2onOnJD9t5l9N+KiEY6G3taSxaY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=6TUazUJS; spf=pass (imf16.hostedemail.com: domain of axboe@kernel.dk designates 209.85.216.41 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674657130; a=rsa-sha256; cv=none; b=C3mX8WAVCB+2gpltbJ3HxVhWkTiGWFw16ssTqrTJmkeFKOINDyiYf3JTXoqD81K1xd4PEu 5MlhpU72kHhMjIjiFXqvj/bpuixg1o9wAtDRQgpyvERIen33FMdeALkN9/kL7z7DI6Yn6G kudvbzsk95klI3THJZrlgUyep2RLugg= Received: by mail-pj1-f41.google.com with SMTP id b24-20020a17090a551800b0022beefa7a23so2191621pji.5 for ; Wed, 25 Jan 2023 06:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TSv8WpaqrU88nGheGtiai7Y/5wRVY8MkM9KRN4G+ukg=; b=6TUazUJSiXGMCc9BZgnJ+ncR58zGFe+HwYOk/rr3xHuxMwoEBSZXgJ8YDUrwx+QrDs 0yoqVhDUylo/qQV9t9vD7a48v/MA1BWUmvM1KIIeVhk9zteWjxsufEqEqKwKSefrLD53 rSSTFz/23fiMM4UZHT7qYjhZz0GkfpM88GDQ7GMPWjY7hn8sbVgZTMjZHU1pL4UXDB98 mK4uNvSGO4tCZYMv3DSy8Y3aHSj87MDVVD6wat1ztVKQ+06I9/6tzukHWdAci17SsAz8 ApNiiBU/qtAwtuPS0o1YadtuehG3+LqSVZvQM9bAhT/U2JtZKE9mLtINVYY4tX9+UwFG PNHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TSv8WpaqrU88nGheGtiai7Y/5wRVY8MkM9KRN4G+ukg=; b=M53GrQ65ULZg7IU/rqVtwSphbfi6MK7filYwDaVQwkz+iwlyh1pg/0Z4E0+RgO7Aze 6p5IUKWEAkRYSp/c5XAnE452jJn6UDSbF8ITdT78wrrTQLORH1dZewPwzz89jH+YAJiv 8LCS2oQZShUqeckELexzIeNmk+GfcFZyvY7oTK33KbEIblUtubiucflTaek6awe8FNW2 +mBYiA3bGh3FUOE/azsaqBacVfLGHcS586dJjJ+A1M4PfBfjccquuez6jxXfSIUtYagA USy60VVneDGe3JL21+U5tmW87MogRsfWaKdlmVkLD4CsR80C4EfZABnxItnfsR+IwDXp MLMA== X-Gm-Message-State: AFqh2kq6et7LU2vj5AT5V7q0qcfE5yX0dgnhop5OxlZbfeVbTh5BjXnJ oyz3yW06L6FiQ/XBSAgnOytQBg== X-Google-Smtp-Source: AMrXdXtSjhgXq/ti77BjIjNmng+Rkvj5Dbfyvd4sgmo3FggcVSTo6y9uVmruhdChTgf8/MyBasa0Dw== X-Received: by 2002:a17:902:b591:b0:18f:a0de:6ac8 with SMTP id a17-20020a170902b59100b0018fa0de6ac8mr7903292pls.2.1674657128759; Wed, 25 Jan 2023 06:32:08 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id bb2-20020a170902bc8200b0018bc4493005sm3664530plb.269.2023.01.25.06.32.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 06:32:08 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 07:32:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: remove ->rw_page To: Christoph Hellwig , Minchan Kim , Sergey Senozhatsky , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny Cc: Andrew Morton , linux-block@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20230125133436.447864-1-hch@lst.de> Content-Language: en-US From: Jens Axboe In-Reply-To: <20230125133436.447864-1-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 33E58180019 X-Stat-Signature: j8jqckcmqmpfq3yop1ccwmbrorkobn7h X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674657130-730486 X-HE-Meta: U2FsdGVkX19sd2uH/8rQKk6RyU9hI7lRBAMPB5aAmqdV240/j3qgeD0kQDQD1pXgPInX1td7vcKkgYFLxFXP8+nUfIVuMfV+rpKbts4b9IVZxqoxHpPbtGy+w27ujmqUNCz5Xg0oq343lhPlAqOVGFstUX07h9EVYtAfCUoLhFyMtXnh7w/5JSeoGUqJe8BrP3g9FvVorqQLW5CEEs0Xu4/qZHLT1c9FRvtbYJYnVoK/N9G8KpGNPLxQtnI3bwkXf9HiRzZEzD4ivKUizJj4HwITyVBFVUZYSwE4w0Lyi/yKVzy180lliglo4sKoGVdZKhYuftBAiISQYrLSxVN1H/5kKAb9ah1c9/JNVqHeoS8Cn12CzzfjizXUJ8vh3q1gvLxaoYqRzWmUaIy3uHzK07oLzws679piTSnOwgJUtXddV9cPThG5bBdYjwOUaOY6cp2NiQLoTpnYa8UEIM43UtoF04VJkmbJwXceJ+UauNsGbGP6Jj6x9Cj4PjyVjBwTN9YnA9Ljsnu3cwYhsuMe49s0Mkyd6uwLdXaRgDBVMLGmMUWW4eNfmDDmsyLnITOTnC7LYspuv8RgqvsnNNK1AM1+kyO9hwzXxR9V2jPSELPG/bBJggifcUiGiBoUUm9R6J1o8O0I2VqxeeOpSl780JuTyxfuZtWFupIzCmP/LTBvh8FpjppQC1oALMiDoPA+UmYoZiXHyu/N7y6qOmeyFas7lT2vaVhoe/gmVB4iDToDGHPQPpQ14qxnr720NXhwAem+qBw48YK4LJa7eTaQuISkre86DqV3HZHMl9rk4vYWE28VREXdtGqhWNkNx8rATCnok5IzFjn786v6F5j50RIhZDh29NPudzvMh6CAqX95BmqVNZWJW0GPyIsCt0sugnGZK2vYf4xCSWAQ42Q8iy+QPdavkcbSDAaiMI9Iv1jF+s74qkjYk1cRCzPvG6gOsNo8wx4dIVM1xxgyY7M 7ztr10Bo TCaJN9J8Zp9X3JqkESvK0R+3eCALHmA6UmkNLWgLu1JJe7i6f5Sd+ruedSuc9S8wDdbseh8twDYxNVrEs+INUwZcLW8csNztxTwPuAvYACFsj4c6BqyRhjrn1cqr/IJifZWmu1pGV/b3PMoSHN8gOPMzQFQIajir1frPpfcbrABO9YEmfZ7QT/GlUtHVdRdkW1TpCb8N1On4Znwf1qBUw62HrqlGpcubz8WrO0qnnwnEa6rPSKqtw1tA7ADTDy7kXzvMv9sTmhc0C4Xn+05nmWmFDP3fLhZB2idMhXyVgGN94fpI15xQPxX2oCSUz6i5zAvqhYKuOJHuLSVQTF3mfYpbVpM838w9ThGOXLdkTOmUaC0+YpypW0BtsFAdkUNijy+HeWkm2j041x8hy0fzEfABnYJPRos4bg/PfxH+kq/BODUHfPprNAn7sN3gbTZUkHHpNEqAIV4A4ToE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/25/23 6:34 AM, Christoph Hellwig wrote: > Hi all, > > this series removes the ->rw_page block_device_operation, which is an old > and clumsy attempt at a simple read/write fast path for the block layer. > It isn't actually used by the fastest block layer operations that we > support (polled I/O through io_uring), but only used by the mpage buffered > I/O helpers which are some of the slowest I/O we have and do not make any > difference there at all, and zram which is a block device abused to > duplicate the zram functionality. Given that zram is heavily used we > need to make sure there is a good replacement for synchronous I/O, so > this series adds a new flag for drivers that complete I/O synchronously > and uses that flag to use on-stack bios and synchronous submission for > them in the swap code. This is great, thanks for doing it. There's no reason for this weird rw_page interface to exist. -- Jens Axboe