From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E56C5321D for ; Mon, 26 Aug 2024 07:00:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4642F6B0453; Mon, 26 Aug 2024 03:00:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EC2F6B0512; Mon, 26 Aug 2024 03:00:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B36B6B0513; Mon, 26 Aug 2024 03:00:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0E8106B0453 for ; Mon, 26 Aug 2024 03:00:25 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ACA05A8D4F for ; Mon, 26 Aug 2024 07:00:24 +0000 (UTC) X-FDA: 82493497968.17.4DFFD21 Received: from omr08.pc5.atmailcloud.com (omr08.pc5.atmailcloud.com [54.252.57.79]) by imf29.hostedemail.com (Postfix) with ESMTP id 09DCD120011 for ; Mon, 26 Aug 2024 07:00:21 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=westnet.com.au header.s=202309 header.b=Hqw5WX4a; dmarc=pass (policy=reject) header.from=westnet.com.au; spf=pass (imf29.hostedemail.com: domain of gregungerer@westnet.com.au designates 54.252.57.79 as permitted sender) smtp.mailfrom=gregungerer@westnet.com.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724655559; a=rsa-sha256; cv=none; b=LSIL1rmb848CgayuIvYrZ07xw+FOL9JPF2QAjzZbHLEXneY7WltPnMuTDIlBDvsg3D4JNg bHlaRRTWCGhW40Y6Jj+c+k6QaD9dN4eE3WWFJ5Huzr7YT3WIZbW/HbCNcvqWsjEw2gDgbX 9gymUX1U+RRajuFaqG7iJ0nW7c7fHAQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=westnet.com.au header.s=202309 header.b=Hqw5WX4a; dmarc=pass (policy=reject) header.from=westnet.com.au; spf=pass (imf29.hostedemail.com: domain of gregungerer@westnet.com.au designates 54.252.57.79 as permitted sender) smtp.mailfrom=gregungerer@westnet.com.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724655559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6tTKEaM8sdRBiX5y2fo+cH7GFaEbUFd+8Q0elSOPc0A=; b=yBbYOJPUYWRNnKqoFDLgOvHhUIFBc+BEkvhpH5wYbpgmGmnEZJ+zrc87xxi++q09PL63ze rjEMfDsTgK0H9f+tNxzFHYVAVSNHuCSwEFvz1LWCjWtACP1MIWRiYmVJTwOlUUVs1Now3K s27SzIAvvlOCu3LCRcydymZIdFoPzpk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=westnet.com.au; s=202309; h=Content-Type:From:To:Subject:MIME-Version:Date: Message-ID; bh=6tTKEaM8sdRBiX5y2fo+cH7GFaEbUFd+8Q0elSOPc0A=; b=Hqw5WX4asG6LLE qMnfahpCSjBz9bCq2gLidqsBim9VUx1ErvMMazAhWX4PV0mZ86iRV1d58GQTBaGplo+tR0SXfI2TH g2IAb4I0aTdMDsICR3QpbHUaktggeu/dVrEyvvOqptB/0a9fmOAjMlaiFIVmqqENZKGGbuqxn8+Dm zIzG5KEk2A1Uzys7WRu6E8pCMX8XrMFQs199TU7lBRKlZ2FM4as5aCIvfvl1Jb4DdmhGpGB/Hl6YW eu3X4eSRD6jA58iRx32QYJ5NDPLybBIGSqIoMYyn9n4KI+/ReonLE7TNQO/zTkwhPehjI0mS58zw6 gQckQNzVVtLLUFntZ83g==; Received: from CMR-KAKADU04.i-041f7649e5739ea40 by OMR.i-0e5869b43dfedcea0 with esmtps (envelope-from ) id 1siTi5-0000xB-Sa; Mon, 26 Aug 2024 07:00:17 +0000 Received: from [202.125.30.52] (helo=[192.168.0.22]) by CMR-KAKADU04.i-041f7649e5739ea40 with esmtpsa (envelope-from ) id 1siTi5-0004jR-0q; Mon, 26 Aug 2024 07:00:17 +0000 Message-ID: Date: Mon, 26 Aug 2024 17:00:13 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] binfmt_elf_fdpic: fix AUXV size calculation when ELF_HWCAP2 is defined To: Max Filippov , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , stable@vger.kernel.org References: <20240826032745.3423812-1-jcmvbkbc@gmail.com> Content-Language: en-US From: Greg Ungerer In-Reply-To: <20240826032745.3423812-1-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Atmail-Id: gregungerer@westnet.com.au X-atmailcloud-spam-action: no action X-Cm-Analysis: v=2.4 cv=H9/dwfYi c=1 sm=1 tr=0 ts=66cc2801 a=7K0UZV/HFv9j2j1oDe/kdQ==:117 a=7K0UZV/HFv9j2j1oDe/kdQ==:17 a=IkcTkHD0fZMA:10 a=yoJbH4e0A30A:10 a=80-xaVIC0AIA:10 a=x7bEGLp0ZPQA:10 a=VwQbUJbxAAAA:8 a=8-D65JXZAAAA:8 a=pGLkceISAAAA:8 a=IAVgKGYuzIukzJpoevsA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 X-Cm-Envelope: MS4xfAEQRyZOM7Ozk2Q30aT2s8+z5DSkcoTMnkpPaNgnkdmyxjHDCcOXh/ehMGleTLiP+Ky4uEwbkGP5ldYJHOzoQ/6yNr65xYwz4W4DbXCnREQN+zb3rj2c Qd64FsCwD8ebrOp90dVjYxlWAzbKDeZwfBftLayC7ZN8re8eamhmSdKAmGM/exVui2lf1wMiZYH5lw== X-atmailcloud-route: unknown X-Rspamd-Queue-Id: 09DCD120011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3yfqm5aw1kbpdok7dizntp3h9b1nx3ke X-HE-Tag: 1724655621-737865 X-HE-Meta: U2FsdGVkX1+Rrkd1f34TCSikIhIpjWc8EgL856/dht/bNe0ML+vsOMfPjTGP4rcpARm5t8XM0MqfcyWpx66KA8Plhjss3dnmIp21638+mhOvV6xkJpfngd/qvU9k+HbEA4GCo6i5o0byrmw9Zt1VkYUlT8jN/hyZrLo0Av+lrqHP1Zlchr8iSVpCcVYRe+AvgvYkbLdAh8zpEVJlSzpsPYX4ruFRTPGAUxxcwvl+ZPrDAUdDPAMCYyD3cmfbFZGv/2r/qBhIvMEisTWS/nqjbhBfRXVhzfMfIIdXmZLXJczmivFfgMj9ty17wehEADCy+wFu7WU9HkktrcF5UrfrMyRKXv6ozVPajTE34XEboUfFbWvcTq9gFYtmoNDHprRmkLhehQPdnBGGGDXndGnTvDgYpdGaL+tK7Iri1Iy2F8zolBMa8COA9H4k28KiIvcNZrvf12pgHlcisuDEysKivIvpv+6k9M2lcBQHz2piQBt+dgBLVXhLLGCByaXKFFmQIc0DQvxa+5JqjI5wVl0Ot1YQtkL5Mt5DRTqa0BRUIx4EbjBtFbH+FJQgMnEDxbgKIsaPpcNRjOvLTkwOSo0x7wWpUxDPsljkURsj/d2Nzb+bZGzVKTCr8AjUtmhpoR1IJw8WehAyFfyhQ+bLu36yCpKiv0Ulu7SF37H3vTRQMAt4GPhZYmtAGs7UXDGCozt4F3c5eZshHI5nu1KbLvlzyqttyHe0IN81ZCbmYW8HPsiGFB8W7aSaDD5vWqwauGYggqgMkTOyil1IOUcRk6VnfzALUfZUk6XTUabsriHNnBRZ32QmpgAJNmxUxklQvrec/cSLIA2ka39qHkhTR4zFDmGasazQjyGiE9vpmakGhZ/seNrwzMUMiQ1hldDnzT4M6PvQp/1RQbJaMjIEVkIlYLjVljrzE002NVLQj0JM9JKny9ffRVWZAUe5fwMbTMnPzMujplw4gWGr+Mbc9rg 7cGYk6ti idXNQWcmbG6BAfE+gacQAlVwE49Nj+ariVX16ar1Xn7tizF2SlfC0Ci5jFk26LYwr8QY0x9hCOspxXP7bgtLm+VNxQX+W68E4tX23huVj090Eyh9XbHGbc6xlB2qUBdnsxI6KEaPMi75IpjEZEyTms8Zm6eKNG74MnrJ5SxHwFDM0v7vcX+j23sqZ+afNZ5GdABFUZQ1FB7NrSXcgnkUKTYqy6raDQP9NGaZ+PLA1cOE18mijdGH47aUcDUnkMrfZq4C5gbvaXuvJMWk08FhaYwXG0dLlW4pSTOmlNvJn9Ni1WICjkiSaYCE8woaqr3Ld8RxISTqIDYA5JAgsf9KdVEF4gb09Z25zvvOeVh/ylIka2lqj5hwz4vbtSu6+HH3CRkXNnlZBdWdOLwdXtmy8ajLdvPiU95rDifaq6+7kYIhGpZU2kjZF+QlGtgDdXSbeOhzsa7QwWHd9ZoxdspkM1di8Q/xKw+ftC8eb0oPjDLW4xszfntTWTyn+CiBNPzOmuc4VGC2Cyvaj9wED3XF6IdRcoMzfMTMemeGM X-Bogosity: Ham, tests=bogofilter, spamicity=0.008970, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Max, On 26/8/24 13:27, Max Filippov wrote: > create_elf_fdpic_tables() does not correctly account the space for the > AUX vector when an architecture has ELF_HWCAP2 defined. Prior to the > commit 10e29251be0e ("binfmt_elf_fdpic: fix /proc//auxv") it > resulted in the last entry of the AUX vector being set to zero, but with > that change it results in a kernel BUG. > > Fix that by adding one to the number of AUXV entries (nitems) when > ELF_HWCAP2 is defined. > > Fixes: 10e29251be0e ("binfmt_elf_fdpic: fix /proc//auxv") > Cc: stable@vger.kernel.org > Reported-by: Greg Ungerer Feel free to use my gerg@kernel.org email for this. > Closes: https://lore.kernel.org/lkml/5b51975f-6d0b-413c-8b38-39a6a45e8821@westnet.com.au/ > Signed-off-by: Max Filippov Certainly fixes it for all my failing test cases, so: Tested-by: Greg Ungerer Thanks for looking into it and the fix. Regards Greg > --- > fs/binfmt_elf_fdpic.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c > index c11289e1301b..a5cb45cb30c8 100644 > --- a/fs/binfmt_elf_fdpic.c > +++ b/fs/binfmt_elf_fdpic.c > @@ -594,6 +594,9 @@ static int create_elf_fdpic_tables(struct linux_binprm *bprm, > > if (bprm->have_execfd) > nitems++; > +#ifdef ELF_HWCAP2 > + nitems++; > +#endif > > csp = sp; > sp -= nitems * 2 * sizeof(unsigned long);