From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F61C433DB for ; Thu, 11 Mar 2021 06:01:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2AAEB64FCE for ; Thu, 11 Mar 2021 06:01:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AAEB64FCE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9D29A8D0272; Thu, 11 Mar 2021 01:01:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 95D238D0250; Thu, 11 Mar 2021 01:01:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D4798D0272; Thu, 11 Mar 2021 01:01:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 6096D8D0250 for ; Thu, 11 Mar 2021 01:01:17 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1842B181AF5CA for ; Thu, 11 Mar 2021 06:01:17 +0000 (UTC) X-FDA: 77906545794.09.3F26BAE Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf01.hostedemail.com (Postfix) with ESMTP id 6B75920053C3 for ; Thu, 11 Mar 2021 06:01:16 +0000 (UTC) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DwyvG47QmzrTjr; Thu, 11 Mar 2021 13:59:22 +0800 (CST) Received: from [10.174.177.134] (10.174.177.134) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Thu, 11 Mar 2021 14:01:09 +0800 Subject: Re: [PATCH 0/3] Add support for free vmemmap pages of HugeTLB for arm64 To: "Bodeddula, Balasubramaniam" , Muchun Song , "will@kernel.org" , "akpm@linux-foundation.org" , "david@redhat.com" , "osalvador@suse.de" , "mike.kravetz@oracle.com" , "rientjes@google.com" CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "duanxiongchun@bytedance.com" , "Umesh Sargur, Gautam" References: <20210310071535.35245-1-songmuchun@bytedance.com> <3eae8b3e-d6e0-83c8-e9c6-5420767788d5@huawei.com> From: Chen Huang Message-ID: Date: Thu, 11 Mar 2021 14:01:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" X-Originating-IP: [10.174.177.134] X-CFilter-Loop: Reflected X-Stat-Signature: hjewzee97m3pp7cotqgqzyrsieh8dm5p X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6B75920053C3 Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=szxga05-in.huawei.com; client-ip=45.249.212.191 X-HE-DKIM-Result: none/none X-HE-Tag: 1615442476-882290 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2021/3/11 13:00, Bodeddula, Balasubramaniam =E5=86=99=E9=81=93: > Chen, is your testing steps documented somewhere, can you please point = us to the same. I followed some steps for testing the x86 patches, just w= anted to make sure I am covering your tests as well. We are actively work= ing on building and testing these patches for ARM. >=20 > =EF=BB=BFOn 11/03/21, 9:44 AM, "Chen Huang" wro= te: >=20 > CAUTION: This email originated from outside of the organization. Do= not click links or open attachments unless you can confirm the sender an= d know the content is safe. >=20 >=20 >=20 > =E5=9C=A8 2021/3/10 15:15, Muchun Song =E5=86=99=E9=81=93: > > This patchset is based on the series of "Free some vmemmap pages = of HugeTLB > > page". More details can refer to the below link. > > > > https://lkml.kernel.org/r/20210308102807.59745-1-songmuchun@byt= edance.com > > > > I often received some feedback (We want to test this feature on a= rm64) before. > > Because the previous code has been reviewed for 18 versions and i= s merged > > into mm tree, I think that it is time to release this patchset. I= f you want > > to test then you can start now :-). And I also hope someone can r= eview this. > > > > Thanks. > > > > Muchun Song (3): > > mm: bootmem_info: mark register_page_bootmem_info_section __ini= t > > mm: hugetlb: introduce arch_free_vmemmap_page > > arm64: mm: hugetlb: add support for free vmemmap pages of HugeT= LB > > > > arch/arm64/mm/mmu.c | 5 +++++ > > arch/x86/mm/init_64.c | 5 +++++ > > fs/Kconfig | 4 ++-- > > mm/bootmem_info.c | 4 ++-- > > mm/sparse-vmemmap.c | 9 +++++++-- > > 5 files changed, 21 insertions(+), 6 deletions(-) > > >=20 > Tested-by: Chen Huang >=20 > I have tested the patch and the result is same as the last time. >=20 The test work is that: I set the total memory of 40G, and use 10G for hug= epages. First I reserve 10G hugepages from the command line and the result is tha= t: -------------------------------------------------------------------------= ----------------------- 2M page | 1G pa= ge | ----------------------|------------------------|----------------------|--= ----------------------| enable | disable | enable | = disable | ----------------------|------------------------|----------------------|--= ----------------------| total | used | free | total | used | free |total | used | free | t= otal | used | free | 39,697 | 10279 |29,415| 39580 | 10279 | 29,297=E2=80=AC|39,739 | 10279 |= 29,455| 39580 | 10279 | 29,296| -------------------------------------------------------------------------= ----------------------- For 2M hugepage, we can save 118M memory which is correspoinding to the e= xpected 120M memory. For 1G hugepage, we can save 159M memory which is correspoinding to the e= xpected 160M memory. Then I alloc 10G hugepages using "echo XX > /sys/kernel/mm/hugepages/huge= pages-XXkB/nr_hugepages", and get the result: -------------------------------------------------------------------------= ----------------------- 2M page | 1G pa= ge | ----------------------|------------------------|----------------------|--= ----------------------| enable | disable | enable | = disable | ----------------------|------------------------|----------------------|--= ----------------------| total | used | free | total | used | free |total | used | free | t= otal | used | free | 39,699 | 10279 |29,415| 39580 | 10279 | 29,297=E2=80=AC=E2=80=AC|39,739 = | 10279 |29,455| 39580 | 10279 | 29,296| -------------------------------------------------------------------------= ----------------------- For 2M hugepage, we can save 118M memory which is correspoinding to the e= xpected 120M memory. For 1G hugepage, we can save 159M memory which is correspoinding to the e= xpected 160M memory.