From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A75BC3ABDA for ; Wed, 14 May 2025 09:32:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D60496B011D; Wed, 14 May 2025 05:32:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D10E76B011F; Wed, 14 May 2025 05:32:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD8136B0120; Wed, 14 May 2025 05:32:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9F8DF6B011D for ; Wed, 14 May 2025 05:32:05 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 54FECC0A64 for ; Wed, 14 May 2025 09:32:05 +0000 (UTC) X-FDA: 83440997010.20.17DA6F1 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf21.hostedemail.com (Postfix) with ESMTP id 4461C1C000B for ; Wed, 14 May 2025 09:32:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=rLxeku9c; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747215123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m84ZrpRX8wUn6cktbK0GovgX94fveVNM8unrjnB/2Qg=; b=fFn6N3iNUL9eghvuPFZQXnFjzCmogrNB7yWQC0CEGtgpJHWhv19HOuzUm83EaSumd5T9h1 6AVcJOswLacyWLX+dtgMG8wxwdCAhRxw/13j+86qKxofEJosFKO7cSp5ppiXslnlMdak8H 1WBWpv+jOhl2t5XhnnL8iHUjJ6T9+ak= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747215123; a=rsa-sha256; cv=none; b=Bb9N6bH4oy4mPde9gxXX0jbvQyMmfDJIejQXbJPJdeG43fGNvuy1cpPwO/J2S0PGH9zBUE 5LegqMXjIA447KGWpJV30nt4p+oeIeGeyBdPTuGOcGgMjK3KxkRPaCnxYUQq/4NMROwkGE P+wMcK8+SN9B+4Z7KH5WKBu+4zPR61I= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=rLxeku9c; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1747215120; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=m84ZrpRX8wUn6cktbK0GovgX94fveVNM8unrjnB/2Qg=; b=rLxeku9csZ2/xRQUuDHulNg13JubZb9jMB/LkxVui7G5UhF754Bnscel/4/J44V5d6MHWVXV5fZn8rHNmYKdOd74l7BuOM6XrypThFfHMnoSTC+pcCw0o5aQBQyhi9njIyYWnnZpbErl0Vu3HanTDnW9hHBb8D/DAYd8s3kaTH0= Received: from 30.74.144.106(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WalQuJ0_1747215116 cluster:ay36) by smtp.aliyun-inc.com; Wed, 14 May 2025 17:31:57 +0800 Message-ID: Date: Wed, 14 May 2025 17:31:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] mm/shmem: remove unneeded xa_is_value() check in shmem_unuse_swap_entries() To: Kemeng Shi , hughd@google.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250514165047.946884-1-shikemeng@huaweicloud.com> <20250514165047.946884-6-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20250514165047.946884-6-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4461C1C000B X-Stat-Signature: tgbj5f7qkseoxbr3jgunb4984s7o8eh1 X-Rspam-User: X-HE-Tag: 1747215122-126280 X-HE-Meta: U2FsdGVkX1/089zAGUy2rw7wNW+IoO1gRmarFBQezc2H1c8Aq/Sdofzxv5WbDhGi05mRFBDipIaM75PeDKHb9pQFHHbAwnbPE6TeuJ/6rba39EdRtUCMzXFgstM9pPP3JTuSIRqienX+Fe1XYe6fBBTs6dsuzAcvgACm+Ct+D3CCBwGbPQ5toUzzw497m8VP8twOHYuolt+H5g004XvzORG2VsZq+Gz96I9qJM02KQZW/ox9xsKpqcfcICbmGqnIUnz5g/d3Weus9Mg9EgLmCV9MNuRfNXaOknqqavZDM6j33tGtV4duxC6afQbxwemk+t48KaFLe8i/kcONPi4yOCQRSADpzzd62mYY/rNyMVyz9ZHZdtmEsQNJ2K+nCQn1JiUPpPx2UuOOdDpzWRcPeJEAKtAKlBT8zPM4pH77/SPEEaqDO+U+xsY34ZCl+oInMPOqMtRB8+KjUiQm7YM8w2n4VenOTJH9N5uGvfl05QNGllli8rAE846yn3QjRpfv70oUyBPcT//U0YbkwXdEUPafb3pMuNmf5q4UT3MwLhEjqc2dT7sdCIaniMAf5cFgDD1gLfQbls076SvQYfvClUY9XczO8FeXZZoHXPj0hrqpo/6VWg02+fgc23f/8D2orEgOXFgcqKKbXZmpSznYR5r9bc+XAGiE8KBFZ4TphqZqhx9tpqtTfY2w8wc3I6ezNhXhzdKtjK+ZkvBVmQ3m0/0U9d9ajdJ3qpjfJnjn+Bq/qOrut1PHHf1IqksJ5XHZ79eudUFPjWrfKIujfYYYcwEvGIOZYmx/DgZNbQgnSo2Cde92syIaGWd7w6I0wI+MBPAmg9LMkmddmI+iKMixFhXbfv7W5FdbKQ07j1DwB0RVFNJ0dA4SkNLYOxtIl7qHkQXLcE8/xS0sAxFLidZXwBpsXJADikHSArQAv+SBKRbN26VrJPY1fy9KNnMKx/35pHtfQ2WW2jw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/15 00:50, Kemeng Shi wrote: > As only value entry will be added to fbatch in shmem_find_swap_entries(), > there is no need to do xa_is_value() check in shmem_unuse_swap_entries(). > > Signed-off-by: Kemeng Shi LGTM. Reviewed-by: Baolin Wang > --- > mm/shmem.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index dfd2f730833c..f1d45fcff5e8 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1446,8 +1446,6 @@ static int shmem_unuse_swap_entries(struct inode *inode, > for (i = 0; i < folio_batch_count(fbatch); i++) { > struct folio *folio = fbatch->folios[i]; > > - if (!xa_is_value(folio)) > - continue; > error = shmem_swapin_folio(inode, indices[i], &folio, SGP_CACHE, > mapping_gfp_mask(mapping), NULL, NULL); > if (error == 0) {