From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DF1C5479D for ; Fri, 6 Jan 2023 13:59:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F38488E0003; Fri, 6 Jan 2023 08:59:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE6D98E0001; Fri, 6 Jan 2023 08:59:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD6408E0003; Fri, 6 Jan 2023 08:59:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D082B8E0001 for ; Fri, 6 Jan 2023 08:59:38 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AAEF41A020A for ; Fri, 6 Jan 2023 13:59:38 +0000 (UTC) X-FDA: 80324532036.29.6AF96E4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 8EF1A4000A for ; Fri, 6 Jan 2023 13:59:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="AyGlxaR/"; spf=pass (imf27.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673013575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ld6skC87Efg95aZaTh35h3rM1PWHruwrzm5wBeouCCo=; b=gaANjOGWCwTBYP5BLTtzBvV/pDFOuvunDkB47ULFiXiUp2Ub/fKe/uOjEKENPzed1ZfRx9 HEmQdZzhP460suJDp67tEo/ycRcx6L+rpvJkT14/1BoWB5HgUdY9n8/acBm62oQDbCo09+ ZbhZvRiMjXn1jf56Z9e2Wz8lfwFkHhs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="AyGlxaR/"; spf=pass (imf27.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673013575; a=rsa-sha256; cv=none; b=krm8GVMN36kS/xITgm7ZsQPm0AgXkL5LGOmYQ0RdoLSm/ajyx5lYNeZUxoDduBPSXO9xzJ AiN7rZiyKH1lMWvdAN4j0eHoI3yJxNMKYA31UtGkgFTeDq0s4iG4ZLpa/yukkjXYnvJTvJ q6WcUZRucenTvKGsk/IWOAR+clfYW+k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673013574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ld6skC87Efg95aZaTh35h3rM1PWHruwrzm5wBeouCCo=; b=AyGlxaR/dAvn99JECx2oSlIUAAF2Sfz+vP3ymfVoamTCFP7twro97uVKtPl1nY9xRBgU4u 4trsk9+nN0te7mw3IdBVcqYCc/PZ0+n4lqemhp+UYP3uvJVRbviyK0pQ9O7khNVZwY3wgv ubDuOjtx3uYK6fssWbvJoc4VFTAZcMs= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-547--3tewx85OV2_ODezBzRIpQ-1; Fri, 06 Jan 2023 08:59:33 -0500 X-MC-Unique: -3tewx85OV2_ODezBzRIpQ-1 Received: by mail-ed1-f69.google.com with SMTP id m7-20020a056402510700b00488d1fcdaebso1270084edd.9 for ; Fri, 06 Jan 2023 05:59:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ld6skC87Efg95aZaTh35h3rM1PWHruwrzm5wBeouCCo=; b=NJorPnknfF9NBcImN13Exnx6uWa9RrxNSLwI/RBTPxN96cftzy/KeS4knjFPoGZR2X 1Exf3TFSSGZGEyT1Hek8Jk3wnEb2cdk1maiv7xGCEoW+d0ATFvPcXvEsLQdplo9Iummo TS0QwUmwdJ9D7JYpE2fad2+0nPlmB4IkpLqUiKw9s++T7mhN9AOYEX1HUUXS93hATE6K Zu1ZwvYZRpABCqiq+7P84iESkxvhVdvjs8KqBY8AbkpH2hfC3IgcafAAfBhRzBho+d3o sj2/Z0Jj+Q1/uJUGEXoA13MRtHmuTdN6tr9WVCdqjFUeplV20t0GNt2hHxZzQEgRUQmA 1fFA== X-Gm-Message-State: AFqh2krf904a+ZeN5HrUNJGgPvAQlbvrkc1tuk0OhzdigQgxOxAZjgPP 7bp7/xap1KKjV3e3sQB+gHsg+jOSDhwCNkd/rtxasGTv6YP+DuTaHvO7EXfbVpvx5kZ7A6HGhzW bfWfC6iCjurc= X-Received: by 2002:a17:906:8d03:b0:83f:743e:86d with SMTP id rv3-20020a1709068d0300b0083f743e086dmr6820254ejc.14.1673013572497; Fri, 06 Jan 2023 05:59:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXu/Ypg+zVVXXcX8tORlQQl+nbyb1LpahzhTJUDXGoEF4RRfu4eIbH86RVlS/sA+tygbzZ5Dag== X-Received: by 2002:a17:906:8d03:b0:83f:743e:86d with SMTP id rv3-20020a1709068d0300b0083f743e086dmr6820247ejc.14.1673013572296; Fri, 06 Jan 2023 05:59:32 -0800 (PST) Received: from [192.168.42.222] (nat-cgn9-185-107-15-52.static.kviknet.net. [185.107.15.52]) by smtp.gmail.com with ESMTPSA id sb25-20020a1709076d9900b0084c6581c16fsm432981ejc.64.2023.01.06.05.59.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 05:59:31 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: Date: Fri, 6 Jan 2023 14:59:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Cc: brouer@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 05/24] page_pool: Start using netmem in allocation path. To: "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , Ilias Apalodimas References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-6-willy@infradead.org> In-Reply-To: <20230105214631.3939268-6-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8EF1A4000A X-Rspam-User: X-Stat-Signature: wc7uejba6zrjxb8i4skxk9wmwyr1rwdd X-HE-Tag: 1673013575-378180 X-HE-Meta: U2FsdGVkX18mKyiodMJJ/phnw38yj1BLfrpBvHapqT9npyR5VJEAe9RqE9O1DTL0L3iJO5DzMAlJPDvDUg8E3aX8r/GwdYj+qBzZ7YInhUk8cf4eeMNk1aDUHzhOKdJgX+IdhPyMkgZkSOF9DDKJ7AgV8RpTW2tZWc+bSlwXBn4+KP36ytnblEJPGuFdXuGLQzNzKp/jAYmdGn2ESIjznNwiMmPfLF2utIqcDIWb7QakKXFJJy/tStTuDblQ0LXWJu0EcA+eDFItCDdrS/DyJc0ENFLs12fF2OKh76k4W6pTs8htMSnrOCX9R28FLPWGZ3SXvyFRCP9H2V/bBuzSqkfqgHkie8D4SQa4rOFIznzU18c+7HZKrR3UShMbflzVG21ibmj6iDNSHoZvj7pDOBM/ki6MUX+hxvMOmrCct23E4ImAkJbHiuIH9nIb6cIsAkerO8+DanMlOs/8ixrLcJ15VIES/SaYSMmmUSGboAVw55ULYM2uFS2N4p65i4yb2bN5tEQ8/bYpKnRycRmjIhh4RQF654U0s6HcVf7TQDLjjNdVoWLmdjn4M2lDInXxOuduhbN0JAFgAdIAu5KY1unSIOo6uZOjWYRUNRryVn/3i9mJjJUt8R4kpltX4Lp9T2HeFMd1qNYqwaksHZY1qa3TtSHfBVMzXNb/d7rWZGaAuSNvVAdJZfNO9rDCwPPO13diFwatwXf7W3GC0P2RLwUT1IWS9mOxi3SJ6Tn5GOF3muoYj3Y0E0uak1ngOR2dyjWw/h2KJOof01DoUo5wOEzwnXg1NIZgoY3sORiU0KqBb1rUJ4eGebOkuwHNdwq/6SCrB+25T6QXOqn5vnYu/1Xq+XM5314zwU6cGaV0/Tv0NcdgesqAnzf1fAZ6ikSvKoC0wQogI7E31XzbtiipoMe1X//ygomRGci06k14sd0jnMmQ5jJFGMTHsInxD6jMxXoNuMvhGf6TVRthOCn gkjfxjii vv+8G4u3ApIX1I729MSYVKSc2rlpush1k9mL74OrIaTJi03SB+bVQdCxvjmWnavqAXMbC1V5m/E+36NiW8HdXfjUt1W3nsMKNxOaOlWv419jnnqUCbovi2Ir1IRq7a9N6BWrXqBQ79y0mEXtFcN/ONGT0kw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/01/2023 22.46, Matthew Wilcox (Oracle) wrote: > Convert __page_pool_alloc_page_order() and __page_pool_alloc_pages_slow() > to use netmem internally. This removes a couple of calls > to compound_head() that are hidden inside put_page(). > Convert trace_page_pool_state_hold(), page_pool_dma_map() and > page_pool_set_pp_info() to take a netmem argument. > > Saves 83 bytes of text in __page_pool_alloc_page_order() and 98 in > __page_pool_alloc_pages_slow() for a total of 181 bytes. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/trace/events/page_pool.h | 14 +++++------ > net/core/page_pool.c | 42 +++++++++++++++++--------------- > 2 files changed, 29 insertions(+), 27 deletions(-) Acked-by: Jesper Dangaard Brouer Question below. > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 437241aba5a7..4e985502c569 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c [...] > @@ -421,7 +422,8 @@ static struct page *__page_pool_alloc_pages_slow(struct page_pool *pool, > page = NULL; > } > > - /* When page just alloc'ed is should/must have refcnt 1. */ > + /* When page just allocated it should have refcnt 1 (but may have > + * speculative references) */ > return page; What does it mean page may have speculative references ? And do I/we need to worry about that for page_pool? --Jesper