From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EEFCC001E0 for ; Thu, 20 Jul 2023 02:38:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A43E52800A9; Wed, 19 Jul 2023 22:38:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F3A728004C; Wed, 19 Jul 2023 22:38:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BC042800A9; Wed, 19 Jul 2023 22:38:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7C90828004C for ; Wed, 19 Jul 2023 22:38:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 36B771604C4 for ; Thu, 20 Jul 2023 02:38:50 +0000 (UTC) X-FDA: 81030432420.30.21B8A3D Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf20.hostedemail.com (Postfix) with ESMTP id 072FA1C0006 for ; Thu, 20 Jul 2023 02:38:46 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=none (imf20.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689820728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xxPr0FTEC9Tgmf93aiM3hqbwwnBi2MkT51SvSK7ol3o=; b=QNXRrKSOVjY9U/XGUFB0WuqGYJREer3bkYNJ0fhDyoZaKUjOI8Ex5CO+Vyj5tZiGcYq/AL o63OzM9RrgszcRFOWmHPwAmYaZgnWVg3mgu8X71dN61zbdtC3QsjzoUtuIP+cIB4utAU/u hdMxAFJ5MNF3UyGubLGGy3HkPMDtvwE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689820728; a=rsa-sha256; cv=none; b=QjFYifO1zEKfUVgW+ElC9+Nm2yeukuXyteN7nXBLFhhVzzqirkhIZ3dDrSF92lquflLj5V 8xs1ULNfmtk4mLN26izBqFIXGpsw3cQizFMgi0EEuTy14pH4C3FP3OFJetK89P2jQICqBu u3yymi7aRyGLqKWrmGYmf42VoKljC8Y= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=none (imf20.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4R5xhJ10mzz4f3mW1 for ; Thu, 20 Jul 2023 10:38:40 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP4 (Coremail) with SMTP id gCh0CgBnHLAvnrhkPIJ+OQ--.56340S2; Thu, 20 Jul 2023 10:38:40 +0800 (CST) Subject: Re: [PATCH 0/3] add page_ext_data to get client data in page_ext To: Mike Rapoport Cc: akpm@linux-foundation.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230718145812.1991717-1-shikemeng@huaweicloud.com> <20230719094421.GI1901145@kernel.org> From: Kemeng Shi Message-ID: Date: Thu, 20 Jul 2023 10:38:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20230719094421.GI1901145@kernel.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgBnHLAvnrhkPIJ+OQ--.56340S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKr4kCw1fCr4kJFyrZFykuFg_yoWkCwb_uw 1fJwnrGrs7KF9Iv3W29w47trWvkayrCr15Arn7GrWakryfJFZrZFnrtwsagFn5XrsIqF95 Gan8ZrnIvw129jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbzkYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2 j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7x kEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAK I48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7 xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xII jxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw2 0EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF 7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UE-erUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 072FA1C0006 X-Rspam-User: X-Stat-Signature: w9kf76zhtkzq9rpewxuc33j3m74uajsn X-Rspamd-Server: rspam03 X-HE-Tag: 1689820726-173477 X-HE-Meta: U2FsdGVkX1+h8DQaycXQvLQ6d3wQQx+/KNG0fZ9GMZwAlf6GDRPuW2VNpUQynYOyVkCk9KxywnvSwvBcuQqfIuixPi1LYe4sEI6g/TWG9BAaIGDkJiK3p5gSEleSSnVxPvLwaTV2uvJgjl1Jth7/T0EjtnYsJ+XR+Vtpbpy4x8egj2Prf/Yj2ntzYydbxKOeUzPMTowYIhGUy4ALu4j78D3MBszux2cj68Z4w9fn6qxGpLLaC8ZrPlPSTAD7tQkuPyC0Xq5DQa2XFdVRjKYydYYkPyPh0vcKdP0e9BXALFLfR7CkRQ7UzolMW4Ga2YoYFivpVCnqvPJ7Rt6zeWF87VOEcGS02SJsojbsSgrnV97X8w4iX5TQJpnVIBO5N2OyxhkH70Du5inQI1pHfz/a/g8X6ik1/ZKLv+y1AdqEYUp7fljK9Zb3oAPqTVidwdJCGCpLmgpPymG+BMHlvFx1YEoUg8ZZXnibGEKVDEUfVwAaeAKsfHLI7I2rMkKJRUznJZJiEo70iXFSIoJ4FZ/PwbFTpnrK41ZXRs+UwacW+QLnR+fCpU6yQiYYBhr0enJdq3fCdJ94sj0V52fwSiSh70hJ8r/dQT8ff9lQkkGVDW0kbqHEblV/0B2aMLccSdbRUR9+6DL564/I5Xn3yQBvlPnt6MADyexOJya2OiHtQZezVDfT1zTgYndWW+fAhXVNITTN0hOIFQ+p7M18RcA4+KRPmv6YF5+v/8F2UcwbAYc+iZq/Yf/znUtKj1vtGGRFRhRVdcoIAiO9uRMf1QnGJpLBIOoxYUTFLsvdounarzaQlkum5Qurf+/fH2JDnj4s0rA6TK1zOsL3i6tCzyvfbcS2bkFXxcoDzG2fFIVVLdkzMLAXXjosYwCIUdWLIkYRMHpqmwrPjOkC8lgFieSlUfhaqClnerKOCzHB5Oa8A6xB85a1k2nsQdP9WOzlUvlV1fTuGSke937MO5pWJui ai3rnSfY a+4PHoKFsLv35rgxxfqU7owDl4LDMpeqGdMTvpo/oOEfjPl6+jaYKWe7c3VGocPP5h4q0m7H94jVWA8HnUGNi9bxDH0FTG80Jw7sCNr7kEEJun44C9Q1vbWmjSPosO7Cs3SZTOamN0yx3YLzICh0f+/Thdh4n4gWGeF+yP03bzHxJEmC9XkhEBfJuRRcjF7qwCzWdHLMIU9+ypyrFUbsl4c+Ta0ZfvlZabVVibJ3BD5WdUbg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: on 7/19/2023 5:44 PM, Mike Rapoport wrote: > On Tue, Jul 18, 2023 at 10:58:09PM +0800, Kemeng Shi wrote: >> Current client get data from page_ext by adding offset which is auto >> generated in page_ext core and expose the data layout design insdie >> page_ext core. This series adds a page_ext_data to hide offset from >> client. Thanks! > > Implementers of page_ext_operations are anyway intimately related to > page_ext, so I'm not convinced this has any value. > Hi Mike, thanks for reply. I thinks page_ext_operations can be futher splited into public part which used by client to simply register and private part which only page_ext core cares and should not be accessed by client directly to reduce decoupling. This series makes offset to be private which client doesn't really care to hide data layout inside page_ext core from client. There are some concrete gains I can list for now: 1. Future client cound call page_ext_data directly instead of define a new function like get_page_owner to get it's data. 2. No change to client if layout of page_ext data change. I hope this could be more convincing to you now. Thanks! -- Best wishes Kemeng Shi