From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C68CFC25B06 for ; Mon, 15 Aug 2022 00:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B73698D0002; Sun, 14 Aug 2022 20:03:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B230E8D0001; Sun, 14 Aug 2022 20:03:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EADF8D0002; Sun, 14 Aug 2022 20:03:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8C9488D0001 for ; Sun, 14 Aug 2022 20:03:26 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 613EDA01A8 for ; Mon, 15 Aug 2022 00:03:26 +0000 (UTC) X-FDA: 79799877612.12.7573E58 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf20.hostedemail.com (Postfix) with ESMTP id EF0991C0089 for ; Mon, 15 Aug 2022 00:03:25 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id gj1so5680612pjb.0 for ; Sun, 14 Aug 2022 17:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc; bh=sWYaAoKHy8vkkdIn1YWYFARyaRpOfkzs3KNPHc6tA04=; b=QQ38N2MmN0T+8nJStiRkwAIK115eu9z0Tg55P5VKOGj5pJ/U0k0QYnsVKliO/ELmWj P9qQDHALak40yxEu2HHHn0QzSHfWPPQPADLTnL5YFFwce9Jtylsucf7z8OUaL/BkoUhw hZbZtgyvPzOIxDESB6hlvIB0LP/pLqT57B/tVa5M2ZlUIwJ2C4LxVm01CeZ7luKC2anw wyRsoSKRwMm47kDBacgvf/ZwTus48BMIFNZejcKcZBBYTaYQ4sNG5lYHpeUTSam5rpI2 mFjYb5aE9gAnR43ACWCGNxT/s2Jo4er+pFA3tJPX1LtPNS62e9sTPPFfeaRNveWwOF8x 1eqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc; bh=sWYaAoKHy8vkkdIn1YWYFARyaRpOfkzs3KNPHc6tA04=; b=c8q2um/ccHnu07RAq4/1a11jsep95g+Hun4gFze4bHSRlGD8Pprysl8Ne9o/eTmJCm 5lf2rC2AaqWfcPgjhbxWRK0WG3042xmv4aYtzqNrp6ok5S7HqM7Whnzd1RhfqhZxGF1K 9TNzxMnRD/meaCfCHtF7bgoR30OEzrGwueoz0HylXFh57MweTPkysiljl8+j5duwErr7 muZDenDCbkXudls83kXaOXM0PFqbApqDelUd7tMuky3S/DUC3zxg99A9/9g/7ZhYRdRd wngK5Hgr1U3i59siTo6eKyy6/W8rvPMUzldWThbEhIGLN5eZwM+5vhw8z54uDTFymGRH qUfA== X-Gm-Message-State: ACgBeo3fSo7bYAGy0GRsObPdryRGmH0xEoeC5RxWjBd6RvVyKm3V4ZE1 vlZFuZRiNlPTdi08c6w/0z2kXQ== X-Google-Smtp-Source: AA6agR52YRboV8Khy4otX1FmHnQOK1YaZwUAKZt8DnG4wQUlYhhFscs4i9ZlD4Aa/R74RSuvHjGiYw== X-Received: by 2002:a17:90b:4c8c:b0:1f4:f6e8:2de0 with SMTP id my12-20020a17090b4c8c00b001f4f6e82de0mr15063944pjb.36.1660521804781; Sun, 14 Aug 2022 17:03:24 -0700 (PDT) Received: from [2620:15c:29:203:2fe6:b086:54db:d870] ([2620:15c:29:203:2fe6:b086:54db:d870]) by smtp.gmail.com with ESMTPSA id x3-20020aa79563000000b005321340753fsm5586430pfq.103.2022.08.14.17.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Aug 2022 17:03:23 -0700 (PDT) Date: Sun, 14 Aug 2022 17:03:22 -0700 (PDT) From: David Rientjes To: Vlastimil Babka cc: Rongwei Wang , Christoph Lameter , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, Sebastian Andrzej Siewior , Thomas Gleixner , Mike Galbraith Subject: Re: [PATCH 4/5] mm/slub: convert object_map_lock to non-raw spinlock In-Reply-To: <20220812091426.18418-5-vbabka@suse.cz> Message-ID: References: <20220812091426.18418-1-vbabka@suse.cz> <20220812091426.18418-5-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660521806; a=rsa-sha256; cv=none; b=xbFYNpjsq9iF1LiP0ppRYjhoQujHu6lYgiXS8eqfmTJy5F+LmdNWn2gT4F3ht8xVjg0lqx HblUjQYRmhGiBqnl91vL9bWFp6beiW+0AN92J45jK5e1AmZltpq2nEb8KBLwOJVMiW8CSR kckhxD+y+AXQ9Z1dhtxSSoo7cGy+FGQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QQ38N2Mm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of rientjes@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660521806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sWYaAoKHy8vkkdIn1YWYFARyaRpOfkzs3KNPHc6tA04=; b=5B5P4xcQ7Gc5HPxXqlLd7W7+RQzEc93Zpy6cJ/WqQ6P/A7GRYg+j9EC2cWpunIm9DAxCaz ++cDapAYRUHT6yI38RkScN62Oi71WpBfKCXzln05ZDAb3Xgv3tKePeYg68aohJZ1IYwsLo SwUXtI/feVUSIUwEBD+//OsKv3N3Yyg= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EF0991C0089 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QQ38N2Mm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of rientjes@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=rientjes@google.com X-Stat-Signature: uwgk3hk8omc4weuqixxa4mxd17wtydao X-Rspam-User: X-HE-Tag: 1660521805-871969 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 12 Aug 2022, Vlastimil Babka wrote: > The only remaining user of object_map_lock is list_slab_objects(). > Obtaining the lock there used to happen under slab_lock() which implied > disabling irqs on PREEMPT_RT, thus it's a raw_spinlock. With the > slab_lock() removed, we can convert it to a normal spinlock. > > Also remove the get_map()/put_map() wrappers as list_slab_objects() > became their only remaining user. > > Signed-off-by: Vlastimil Babka I don't see a benefit to keeping the VM_BUG_ON(!irqs_disabled()); around either. Acked-by: David Rientjes