From: David Rientjes <rientjes@google.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Rongwei Wang <rongwei.wang@linux.alibaba.com>,
Christoph Lameter <cl@linux.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Pekka Enberg <penberg@kernel.org>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-mm@kvack.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH 4/5] mm/slub: convert object_map_lock to non-raw spinlock
Date: Sun, 14 Aug 2022 17:03:22 -0700 (PDT) [thread overview]
Message-ID: <aa1cb468-fd72-631d-8b7b-1b68e799872c@google.com> (raw)
In-Reply-To: <20220812091426.18418-5-vbabka@suse.cz>
On Fri, 12 Aug 2022, Vlastimil Babka wrote:
> The only remaining user of object_map_lock is list_slab_objects().
> Obtaining the lock there used to happen under slab_lock() which implied
> disabling irqs on PREEMPT_RT, thus it's a raw_spinlock. With the
> slab_lock() removed, we can convert it to a normal spinlock.
>
> Also remove the get_map()/put_map() wrappers as list_slab_objects()
> became their only remaining user.
>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
I don't see a benefit to keeping the VM_BUG_ON(!irqs_disabled()); around
either.
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2022-08-15 0:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 9:14 [PATCH 0/5] fix validation races and cleanup locking Vlastimil Babka
2022-08-12 9:14 ` [PATCH 2/5] mm/slub: restrict sysfs validation to debug caches and make it safe Vlastimil Babka
2022-08-14 14:39 ` Hyeonggon Yoo
2022-08-23 16:39 ` Vlastimil Babka
2022-08-12 9:16 ` [PATCH 0/5] fix validation races and cleanup locking Vlastimil Babka
[not found] ` <20220812091426.18418-5-vbabka@suse.cz>
2022-08-15 0:03 ` David Rientjes [this message]
2022-08-15 12:53 ` [PATCH 4/5] mm/slub: convert object_map_lock to non-raw spinlock Hyeonggon Yoo
[not found] ` <20220812091426.18418-2-vbabka@suse.cz>
2022-08-14 13:42 ` [PATCH 1/5] mm/slub: move free_debug_processing() further Hyeonggon Yoo
2022-08-15 0:03 ` David Rientjes
[not found] ` <20220812091426.18418-4-vbabka@suse.cz>
2022-08-14 14:54 ` [PATCH 3/5] mm/slub: remove slab_lock() usage for debug operations Hyeonggon Yoo
2022-08-15 0:04 ` David Rientjes
[not found] ` <20220812091426.18418-6-vbabka@suse.cz>
2022-08-15 0:04 ` [PATCH 5/5] mm/slub: simplify __cmpxchg_double_slab() and slab_[un]lock() David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa1cb468-fd72-631d-8b7b-1b68e799872c@google.com \
--to=rientjes@google.com \
--cc=42.hyeyoo@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=cl@linux.com \
--cc=efault@gmx.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=rongwei.wang@linux.alibaba.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox