From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1AD7ECE58E for ; Mon, 7 Oct 2019 16:50:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6D022070B for ; Mon, 7 Oct 2019 16:50:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=android.com header.i=@android.com header.b="lJsltAwB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6D022070B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=android.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 238E88E0005; Mon, 7 Oct 2019 12:50:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E9A08E0003; Mon, 7 Oct 2019 12:50:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B0268E0005; Mon, 7 Oct 2019 12:50:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id D94BC8E0003 for ; Mon, 7 Oct 2019 12:50:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 438DC180AD803 for ; Mon, 7 Oct 2019 16:50:35 +0000 (UTC) X-FDA: 76017577230.09.stick18_511d1c5da905 X-HE-Tag: stick18_511d1c5da905 X-Filterd-Recvd-Size: 4282 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Oct 2019 16:50:34 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id j11so7155498plk.3 for ; Mon, 07 Oct 2019 09:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+w6HGwIeJz41HW0Pum9Qvdf3wavqkNbTaRf9Bcybxb4=; b=lJsltAwBXOB7dzBNHRpXWNUxozcGk6hPiEnSnYGI2AGONfo3Tz+aNwgBqtQj8Hwk/1 AGAy6E+fMSLqf4xqAgfjfRQ0JJG1SD+7XAORxZzNsdSuFUVqP2Njj0W81UoVYxvKaoOi Ch3KQ+MtptGeBccMUkJD1OkVksmM2nIzJjk3YK46o79KJ2tqlbT9YWIQgWXHdXNCOzLv yWXkSTfWYSUqyMQCEQMWgBas7nGOZ+GURuYNGsOnD3j68YyyA+Qraj7xocqUO+ZfHwpT hMdSXfvr+tfcnP/ZXXnEogDA8CxA6I7a7fAaQCG6vp/aCtsYpkd1NRX90yOTPZawQ17U oYlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+w6HGwIeJz41HW0Pum9Qvdf3wavqkNbTaRf9Bcybxb4=; b=hu5sdOs6+4sfrlpHEPkd1Wdkl3j7pAv6EDO6O7ULLeZHhfnr4pSdUFwedR9SA6IuRm QzoQeXCVN1RddxHeY1AbHanV1iEMrp6gZYerVnXwe0h7zmAq7BzgUGf2JX0BKJGSXO6C HWZIZXeSPdOQsO3l691vsx7YqF6yfGDrvvh4IvrWMbA8dBoCJBTLF/7d2YYHRoy8j+Kq 8UThTJm6dOXDn+c88E9UP5SyqLosTqb81Np7Xf7I0MiTCpQIi0e7KkCA4wcgSDlKKRWG nLnXfCd3iOLeTXSKCJrEzwq/RM+ndykRluwEUs+8NuMnGxKfxxFElhzE5bwBkZk45z56 nX7A== X-Gm-Message-State: APjAAAXTaW/AUrQeYSQ+NfhW+vsjiX4Fdc2tfQ+3D8TrmHw7g9w9ln5C eYFC9UVNyrwCjP1tQSC/ZKgCbA== X-Google-Smtp-Source: APXvYqyqhgEmYg2SNMgR0qFTRxWnC5C0Pd3FzJLguS6YtT9AKzecBtSMeeO78IlNFu5TcTfGadfDhg== X-Received: by 2002:a17:902:9b84:: with SMTP id y4mr31341979plp.189.1570467033479; Mon, 07 Oct 2019 09:50:33 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id w11sm880349pgl.82.2019.10.07.09.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2019 09:50:32 -0700 (PDT) Subject: Re: [PATCH] mm: export cma alloc and release To: Christoph Hellwig , Catalin Marinas Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Andrew Morton , Yue Hu , Mike Rapoport , Will Deacon , Thomas Gleixner , Ryohei Suzuki , Doug Berger , Andrey Konovalov , Peng Fan , linux-mm@kvack.org, Robin Murphy References: <20191002212257.196849-1-salyzyn@android.com> <20191003085528.GB21629@arrakis.emea.arm.com> <20191005083753.GA14691@lst.de> From: Mark Salyzyn Message-ID: Date: Mon, 7 Oct 2019 09:50:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191005083753.GA14691@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/5/19 1:37 AM, Christoph Hellwig wrote: > On Thu, Oct 03, 2019 at 09:55:28AM +0100, Catalin Marinas wrote: >> Aren't drivers supposed to use the DMA API for such allocations rather >> than invoking cma_*() directly? > Yes, they are. We have an engineer assigned to rewriting the ion memory driver to use dma_buf interfaces. Hopefully that effort will solve the problem of requiring these interfaces to be exported so that that driver (and others) can be modularized. Thanks for the reviews, drop this patch from the list and we will regroup, and accept that standing code in the kernel can not be modularized for the moment. Sincerely -- Mark Salyzyn