From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 424F4D339A9 for ; Mon, 28 Oct 2024 17:26:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB42F6B0095; Mon, 28 Oct 2024 13:26:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B62FB6B0096; Mon, 28 Oct 2024 13:26:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DC606B0098; Mon, 28 Oct 2024 13:26:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7FA056B0095 for ; Mon, 28 Oct 2024 13:26:48 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E920B160D9C for ; Mon, 28 Oct 2024 17:26:47 +0000 (UTC) X-FDA: 82723690434.04.35BC30D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 13A2580006 for ; Mon, 28 Oct 2024 17:26:00 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EZmZ7eiK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730136277; a=rsa-sha256; cv=none; b=SMnazoZleqEETsGKiNvbKYk3tsDl+htGQw/M443RMxZxFku8gZqDng3+i0tWRayYuOiEvn gCPFubUFN4W/NViv2HbGHOgh/y3fW6vdVinM90dDB1XN+9sR07GSgW687O+iq+y2wk+FsN uXU980bpxiI2JS89Qhb7Z0SluzDKbDk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EZmZ7eiK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730136277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9UdB2rePe9j8NgmiBvbEzEGN/wd2cHKxjDUNBVkCuIY=; b=74veOGM6pvmAZja7JQVHeiWnxliVk64W2HuvXlwLaXfbNtLW4CGsKUYMVEKJDUKSRSuMjG t+1POpEc2THTnzpBPP21Pdq7w0sq9NUrJb0LWcRaEZ8gC38kLJPHLI4Io0aDvjMmHwn9lJ TQHKh1FUta/cfXc7cPmbBelJonuFMRQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730136405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9UdB2rePe9j8NgmiBvbEzEGN/wd2cHKxjDUNBVkCuIY=; b=EZmZ7eiKlHUCvlDL6wvLzicplQYOQLKFNqbkKnoEdpySCvDH409CgOTYcrRU76l27cifCG 5RX1+7VAXdVvU9t2iB3Kr/RTR6aa2dt0O9aWKXQY9zXIrGqdIDdcZ/AthYFhuEBNX0EjzL mFmie45Ap4norZxL4rBp/is+JW4vgxE= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-327-0Q-pB9vZMzi00y1gx7b7SQ-1; Mon, 28 Oct 2024 13:26:41 -0400 X-MC-Unique: 0Q-pB9vZMzi00y1gx7b7SQ-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-539e294566dso3492189e87.3 for ; Mon, 28 Oct 2024 10:26:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730136400; x=1730741200; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9UdB2rePe9j8NgmiBvbEzEGN/wd2cHKxjDUNBVkCuIY=; b=Wv6E8rDMi0tit80jDXmRQGVPnU4iRaCoPp77FNT+q8He1Ptd1wXSRTsl2NO0L1xDpk 8fMg2aa9hj90aIOq9kspxFpSQsPIbs16l8MTQKNTVJU55kHOFfd1m9LRuhGzHNlJnCV4 s5AxU7o6Y3GzH0hWvU84Tw96A+fw6wM4eZlRkHj0MXIljVXkKDtSv7qZPYNVz6sRk2Tu WFO5UeSvtQTDwO9tc983PH4+wg+0EYlV9OJN11z9RNKI+kd7dT0krzB5VYPww0cnFZ8S y1QpqsuT3aGAZX4NIURHzWRpdEulTo4ZpiwR7woLO3A4hVAkUzaRifZWck6TpfuZZXQv IkaQ== X-Forwarded-Encrypted: i=1; AJvYcCXfDqlMwlORRE5F0fZ49yP+VT6dbjYIlv326vp8an5iMHFsr8aNtgGOZlgyJtDGZevxIfcNneLkiQ==@kvack.org X-Gm-Message-State: AOJu0YyN0+rLEDdYy1dPoF9aBMGQiz515EDZTPZdyi148yDZ5GDmQPrR sVcIt1QFOlx/P4KUKbOjQ8KQ5foIaYBcnBoktvVxHeWqa12OsUj+2I2GOv2fMH0PEL1kTCowkZs /FqEpCIy/tScgXNFEL0PqGbzoV+neQkKJS5EgRTRMusyvBrVQ X-Received: by 2002:a05:6512:b02:b0:539:9720:99d4 with SMTP id 2adb3069b0e04-53b348d7013mr4511323e87.28.1730136400272; Mon, 28 Oct 2024 10:26:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/Gw3rOIQM579xou8kP4HxdK21C7Lo6mDQjFGb967ZJXzwgz92d2vXILeNtEnTGi2poFBlkA== X-Received: by 2002:a05:6512:b02:b0:539:9720:99d4 with SMTP id 2adb3069b0e04-53b348d7013mr4511310e87.28.1730136399815; Mon, 28 Oct 2024 10:26:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c722:3c00:70fc:90a8:2c65:79b4? (p200300cbc7223c0070fc90a82c6579b4.dip0.t-ipconnect.de. [2003:cb:c722:3c00:70fc:90a8:2c65:79b4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b47946sm10112152f8f.47.2024.10.28.10.26.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 10:26:38 -0700 (PDT) Message-ID: Date: Mon, 28 Oct 2024 18:26:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hotfix v2 2/2] mm/thp: fix deferred split unqueue naming and locking To: Hugh Dickins Cc: Andrew Morton , Usama Arif , Yang Shi , Wei Yang , "Kirill A. Shutemov" , Matthew Wilcox , Johannes Weiner , Baolin Wang , Barry Song , Kefeng Wang , Ryan Roberts , Nhat Pham , Zi Yan , Chris Li , Shakeel Butt , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <81e34a8b-113a-0701-740e-2135c97eb1d7@google.com> <8dc111ae-f6db-2da7-b25c-7a20b1effe3b@google.com> <154430c4-7b17-443f-8628-ef3bb7738ae9@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 13A2580006 X-Stat-Signature: ra69ij57wxwammahhupsgh8czf5hh6db X-Rspam-User: X-HE-Tag: 1730136360-300424 X-HE-Meta: U2FsdGVkX1+L66pJnL71kl1U2UohWut2PEe0PB8GQmJpQPET2WwuKusfX7Onhx0PeEvD36elRbLnSqrxtLXpSw8nhHPXVPzcGnSmxbU1Uy6CYU58r6kd5CPy7iCHM5BP4E1p9EPmD5ivgiLHFpNxky3dDVNObjz5TcfIVvWQPd8sHYVZu9n5ClkraHizJ9FTG+yEr10wdRcFjoEk6C3qRIuLTCei0ed5QSFqI3dHYsf0ILGwNiAnNO1NQEjLwTUWhhDf1YPdBhrNYYvvlXs7ryGg56KctpxFNwsoij8n0vGrrg5frX9ILEoheJ3pZS4xaUDdV+iIRINUgS0p9WT35Tc3OAGjVzJICuKogwVaOriX/A8erJ3mT2SsNGchNv1rDVcjQILQlPU6yN9CoBIJz8e7TJnbL7ESd5z3KB0SOJ6HSgKhWfw/47ktOC5n/4NZsAx1S33NyfIyvNp05dvM4M9p75FTsZxpT96dBp9FYfKAuUaxdtmi6HosnK4Y6Kfaen1qGEyXyrx9paYNqQo3TpBHWYQJNSbLAemBOE+E78ENU8O5T5eZT1mhHMchTDVTPqrbEgWl5trFji3JytEeNEFNZ+tVqJwPuOmww6AZYPlnOc8FNIf5nheNhWWfrDdvEKGSjiSCLXiTJ+TFmgCQwXjkfTvTGxaufBwEL8GiqSywY21MRo17I0Ln4n052DnY+X6MDXCGVWfIxKbfC/NCaises7E5xu0Yk8tQap10e3sNfH0ztYTJxJJFdplERfUuV2vida3YlUJN9YDBlfGPjTZJDHDZR0PiOmHiN5rrSjBiJ/DmejWIHMm+u0tVmfPPSnVcNEp2pnMsEU9CeVd2OHya3ukTcuEKF50gz6NJQb5b5UeAWbp1xUcRThKRdXFriQbCYeYLE2X97KDFmf05/itV2WCTo4jTwu0O5E3zXEbSVr/LS5qiQAD3EgQlLB/tXF+OYnRe1wAukSiQUQG qr2MHtP0 Qg65eSOiHkWuIyxt73zVyDGnkp3j9HXaLY2M2H/B/goc38/7GFd4ZCMhxzpAjZqCnb/437BBIGBw2KnCgKW/1deX3VcvOmG17Vq1FqQikEfxy4HZ3xAvwfugGPO16PES7svpOlZ+tQJy945eAO4u75+qcRqSwCSSh6/JX4SoHORT3UKdWrjZNRURS/zrhthC9gW8hgZfOQU6qKfH8q5jr27Oh8/zXMKlw+KC0WH8pwodP5CyrtIES+l+Ll8JF/E+UCrdWeSuDHpJ7JXa9vfWtuWlzm91a7+9N3fyq9Z0rFUAUT6RQzXfQfk2iwq+I+QsQpS6I01ZKccePwLVVaWzpkfQnVk4cXVMY1CcpLyqyVbQwDkL0xPvyYPjWd1zBHGfXS0inEe2RYi6eSkMxi1ZAKTWoPavDRutJ7Nj6SgKKQGm/rgVsIjOF7aHVr+jq03VGivaBReehgnsvstQ3pTU2mHmlNJqLy4X1SDYanK7WcflL1PA/rl8ptHKuKS/KWod5EPyFV/onY9/aACo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> https://lkml.kernel.org/r/20241025012304.2473312-3-shakeel.butt@linux.dev >> >> So I wonder ... as a quick fix should we simply handle it like the code >> further down where we refuse PTE-mapped large folios completely? > > (I went through the same anxiety attack as you did, wondering what > happens to the large-but-not-PMD-large folios: then noticed it's safe > as you did. The v1 commit message had a paragraph pondering whether > the deprecated code will need a patch to extend it for the new feature: > but once Shakeel posted the ripout, I ripped out that paragraph - > no longer any need for an answer.) Ah, missed that. > >> >> "ignore such a partial THP and keep it in original memcg" >> >> ... >> >> and simply skip this folio similarly? I mean, it's a corner case either way. > > I certainly considered that option: it's known to give up like that > for many reasons. But my thinking (in the commit message) was "Not ideal, > but moving charge has been requested, and khugepaged should repair the THP > later" - if someone is still using move_charge_at_immigrate, I thought > this change would generate fewer surprises - that huge charge likely > to be moved as it used to be. Fair enough, I'd have kept it simpler for this almost-dead code :) Looks good to me, thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb