From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42D1C0219E for ; Tue, 11 Feb 2025 07:47:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 404DC28000A; Tue, 11 Feb 2025 02:47:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B4CA280008; Tue, 11 Feb 2025 02:47:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27C6828000A; Tue, 11 Feb 2025 02:47:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 08EBB280008 for ; Tue, 11 Feb 2025 02:47:58 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A89E8A11F3 for ; Tue, 11 Feb 2025 07:47:57 +0000 (UTC) X-FDA: 83106884994.16.86A3A79 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf20.hostedemail.com (Postfix) with ESMTP id 422801C0003 for ; Tue, 11 Feb 2025 07:47:55 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=gjJwPjn5; spf=pass (imf20.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739260075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YOxJUR1r6moJ1nFDgHvdggcLKQEb9GI98orRGi6n50c=; b=EYttD3uYFG8zelQBXxlq/DWvdUSUofG7gZ58P46NM6TYjPZuvT1ZsPSJHUpQ3KCcl2G2nO QYRo4WrMnMqMBEva0+pE7i2x8RTEJXXqn4D95AUhqDec9k0mxEQ/00+X5/A8E/vxKKo5cu w/bAEYyZbCZ3iA8XwybCeltWzRQewI4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=gjJwPjn5; spf=pass (imf20.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739260075; a=rsa-sha256; cv=none; b=bPzBa0wsmYTryuI79Joo1rK/JCD7jC3kr3j+zkUcCf6NDRTGqFPAkNVXelB0ecPy2d24lN AEgzy3AyfoRrWtRxpMrbANiYGLqZMetbC8oTcdKGj6Mr1N5SS0tM/t883pyJ0jqNRXlHZx 64NzLmz5VilD2fkgjE7XPIJ+/MxsDpo= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-21f48ebaadfso86668075ad.2 for ; Mon, 10 Feb 2025 23:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1739260074; x=1739864874; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YOxJUR1r6moJ1nFDgHvdggcLKQEb9GI98orRGi6n50c=; b=gjJwPjn5vtWQ20oy9Zqk7Sfx5d5kl4dTQl2iklosjq1Ql9PdvNoOCND44m15hs+W2T xxuKPQtudP0PJQPQFA3EvCSEe7gCrjelQI1ueMEhvL4TNEBjuOpN1A4aR7rnc5X2nSoj rJJpkQouAizImBd37iS7Yf6m3sGA3DF5yn/to9hA+JUMegvu0LX76lqXAtRS01OxXMxb OFBZj+gdz/4W/p1PJhX3r5DdrD5poQqYWb5h1s93HFmgT1tNo/OMD5zE/YnFHVqrd+CF 3Wf/+GdsH2O0oCywOPGf1xfa3MwF1GBax8gRqPW3rswDI9lVbkpuHFRx2e3W/Q1/mVQe 7org== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739260074; x=1739864874; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YOxJUR1r6moJ1nFDgHvdggcLKQEb9GI98orRGi6n50c=; b=Yb3yrW5ushnCKB4/AdS2ES2m+0gmKVH3VJGh27YZPTiiPCEaz8tHUIKKC2/FjFd7ki jLv+G3h+U1ePXez3BkiYA9nVwrvJV/4xZWu3AioCS/YHO9EoH5rB3K1hMc/9DmNAiICf M+wTyRjo0ijpReNzvBAd9OTxvH5xvPfznic7kK9S1XhrLqITHphnm7/ezn5HNx+HgjY/ olOw/KiJSvapseCd/TZZBtfvqnCykLGug/iGUNBA5NyMfRE4sfkyU9tcgn5TlHllWMKo 2vkUPbKZLCRFnQDxqgM5Pkt9q14Lqp+EqXn4zfzOJ3in8CWYbEQoCmzJU+fRCAJpUjLq PKdw== X-Gm-Message-State: AOJu0YwcyfQ78tyB7De7+TSiwiyxM9yiDhWsdBdD87mtOhhsknXyx4hM H7shfRNXkc2SfymNYjd3n+WUMk6Jhg56oM8AB+I3XMZ3kLKf70Q99RGPF6ngLEk= X-Gm-Gg: ASbGnctk/DU2PjpyY5ZYaoHYewBe3VGUdBxmHAwhZ0dh3163Le4zkvqBbEkPjm4uqU4 RK/pLI3lRESw1GKZitKTS4x5n79uZGvk+wU7bvJOk46hcJiuDckVRleEQ1qaVlEeDPKRr51Av5p G8dkMoZe38BHD8lFOTifT2ON4tTCG5MocchXRD5Nmj9hHpqqyWS1A83zIOF0CzwBbc2UiW57++9 KmpvWcoGU5HOa5WKlYFlPRloA4iObn7U/yj/eGCCEi+TzAvj3mzfRyL6H3Wl8Du0uVaHsWfdUBV 90pgnqpUFd1nawD/M3jsKQuEsEcMmZEH2wSi2gm7vw== X-Google-Smtp-Source: AGHT+IEoxxPYXOWq1VEr2O9B36RIJecPKfV2ThBHPe9LsevuG0MSxUMQSOIpMfUYtJpsJ2pcKeMrCw== X-Received: by 2002:a17:902:da86:b0:215:a039:738 with SMTP id d9443c01a7336-21f4e1cbb68mr256165615ad.5.1739260074055; Mon, 10 Feb 2025 23:47:54 -0800 (PST) Received: from [10.84.150.121] ([203.208.167.150]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3653bfb2sm90969865ad.67.2025.02.10.23.47.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 23:47:53 -0800 (PST) Message-ID: Date: Tue, 11 Feb 2025 15:47:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/mmu_gather: clean up the stale code comment Content-Language: en-US To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, peterz@infradead.org, linux-kernel@vger.kernel.org References: <20250211034348.39531-1-bhe@redhat.com> <20250211034348.39531-2-bhe@redhat.com> From: Qi Zheng In-Reply-To: <20250211034348.39531-2-bhe@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 422801C0003 X-Stat-Signature: pq7uzuufzz8fbra1eaty1ihm57qznbs3 X-HE-Tag: 1739260075-43967 X-HE-Meta: U2FsdGVkX1+1OXq/h57/4EkOLy8yvSpC871G4KfU3xR3j1aNSDKdioXVZFNG9kix3yH0NhLgvlCDZVTB70lVL8oooiD4UTdqvu6uPqBGq0Yg6+GRmxAv5JS+kDoCi6rMjz8h6t6TKRgh+kK5IZquufp5MRTvCzZ20NqsJxu/mD8Y0wpWojer67HVw0HUGBTAwOUphTbdDirCMy1scti2Cj9SqVKC8EXawhSWY4I+dSGlnoMyMFHCyi1GO++xkpFSkA/Y6s5KxZNKpDvjH6YlBHkWAyhJOan9vUYgIO1b1vrDoFAQ0vsNAFYS/HQwM8FtJMKwDC+pq5L12WJLPEFFDPW/Rl8rIu9HqQWV9CGIsLwVWqCQRmSFhsWmw0v69lrrzkHUUAFFvCA/Drmx5CuWBqqBFYGlwLvQoRywJJtirXd/k0kc6kvGKYjouYO99WeTfn6KTu12R4WsRwnF5w2MBvEMw5ue66u/oS4fxqgWupc8KSSUQk67LmqGoYNTl13XSiJVzewPB/Yr8Lsha3UU4U34KUDgp4gxiywF1trzarhCF/J+sevlUhqg7mImBEcYxK/mfgp+PI0eNkZxbiETIMFoU3Xb2mFv2wHieTfMQdwg5pS+VDeTT/S/8cYAK5CGvBwsb+ZxST+ThBR21WP10vChwEGzPTW4rH7+QW/vyHnntcplJXz2+Esx04n92GKId7W0+tSrIklP84I9806YRrNgDPCQ21xVqoS9kvyqhUU36H1xQLtKYsDmbKUkByHbKxL9n7qZg0rf3tuvxoo3KXhWih9DT05uAAP1H8ogh56xZHPlI2+6Oi/5SM0+x+1LT98oYv5rHkggb6xWu64BWFiUEK8Kg/6IBqtg0SNeBKYRzlcGGyCEE93l4sIXqmjKZ9yQxQEIaNLb2nmkMkaS+E6Vd19qOE5ytlTMEkiN96Ms9/0OIk44X5cKE+CO8rZYvedGebqS6QCPoD09pj8 Wp+ondCA OThPre5GFvW0Gok/4dXPXV68Odc8V8t/drfJ+jrlqTglz88P3Nr9dpzZLGBbx9vgjWktBb0A7XT+zJvkM1VICzwJr3fslbXjDazPoquFWCBe2UknbNUJwKLPp2EeoH0k/3YGv+8JVV8YtbHW/P5VRp1zYkTlDYUG6i+ix+x4bBguG6rFTvhgWuY0L44w7PTAYLxyDvI24VgtVcMR0JJgFQOgLE1IbVJ61EU+ye5xGdTEWFa5pJ3n0AHHWjYvTOZLiTllqMDn7GmhKmEXUPk1cScNMlnmapzGRyrmUksKKLgSnQxb6EjcSaQl4NPpRGCPGEyZPiTnXO5zRt5JA8FzCoSpIWgUmyYNpzlLGx0oR9aQBFfZhkOWN81Zt6TmB+PgNLdibCM/n7mKFgeNzhGnHCJc2I+lYVPF/Qdb6f0oJTiPoneU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/11 11:43, Baoquan He wrote: > In commit d7f861b9c43a ("mm/mmu_gather: add __tlb_remove_folio_pages()"), > helper function __tlb_remove_folio_pages_size() was added. And based on > the helper, wrapper functions __tlb_remove_folio_pages() and > __tlb_remove_page_size() are created and used by upper level functions. > > So let's update the code comment to reflect the current code about > tlb_remove_page()/tlb_remove_page_size(), etc. > > Signed-off-by: Baoquan He > --- > include/asm-generic/tlb.h | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) Reviewed-by: Qi Zheng Thanks! > > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > index 9ae4ca02f29f..5f99b3cf73fc 100644 > --- a/include/asm-generic/tlb.h > +++ b/include/asm-generic/tlb.h > @@ -67,22 +67,21 @@ > * > * See also MMU_GATHER_TABLE_FREE and MMU_GATHER_RCU_TABLE_FREE. > * > - * - tlb_remove_page() / __tlb_remove_page() > - * - tlb_remove_page_size() / __tlb_remove_page_size() > - * - __tlb_remove_folio_pages() > + * - tlb_remove_page() / tlb_remove_page_size() > + * - __tlb_remove_folio_pages() / __tlb_remove_page_size() > + * - __tlb_remove_folio_pages_size() > * > - * __tlb_remove_page_size() is the basic primitive that queues a page for > - * freeing. __tlb_remove_page() assumes PAGE_SIZE. Both will return a > - * boolean indicating if the queue is (now) full and a call to > - * tlb_flush_mmu() is required. > + * __tlb_remove_folio_pages_size() is the basic primitive that queues pages > + * for freeing. It will return a boolean indicating if the queue is (now) > + * full and a call to tlb_flush_mmu() is required. > * > * tlb_remove_page() and tlb_remove_page_size() imply the call to > * tlb_flush_mmu() when required and has no return value. > * > - * __tlb_remove_folio_pages() is similar to __tlb_remove_page(), however, > - * instead of removing a single page, remove the given number of consecutive > - * pages that are all part of the same (large) folio: just like calling > - * __tlb_remove_page() on each page individually. > + * __tlb_remove_folio_pages() is similar to __tlb_remove_page_size(), > + * however, instead of removing a single page, assume PAGE_SIZE and remove > + * the given number of consecutive pages that are all part of the > + * same (large) folio. > * > * - tlb_change_page_size() > *