From: Mike Rapoport <rppt@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@kernel.org>,
linux-efi@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: Re: [PATCH] x86/efi: defer freeing of boot services memory
Date: Tue, 24 Feb 2026 11:56:15 +0200 [thread overview]
Message-ID: <aZ11vw7mYmX1onEL@kernel.org> (raw)
In-Reply-To: <aZ11J7D_iBuG_qjC@kernel.org>
On Tue, Feb 24, 2026 at 11:53:50AM +0200, Mike Rapoport wrote:
> On Tue, Feb 24, 2026 at 10:29:59AM +0100, Ard Biesheuvel wrote:
> >
> >
> > On Tue, 24 Feb 2026, at 10:28, Mike Rapoport wrote:
> > > On Mon, Feb 23, 2026 at 01:18:41PM +0100, Ard Biesheuvel wrote:
> > >> On Mon, 23 Feb 2026, at 12:40, Mike Rapoport wrote:
> > >> > On Mon, Feb 23, 2026 at 12:17:22PM +0100, Ard Biesheuvel wrote:
> > >> >>
> > >> >> > I wasn't sure it's Ok to only unmap them, but leave in efi.memmap, that's
> > >> >> > why I didn't use the existing EFI memory map.
> > >> >> >
> > >> >> > Now thinking about it, if the unmapping can happen later, maybe we'll just
> > >> >> > move the entire efi_free_boot_services() to an initcall?
> > >> >>
> > >> >> As long as it is pre-SMP, as that code also contains a quirk to allocate
> > >> >> the real mode trampoline if all memory below 1 MB is used for boot
> > >> >> services.
> > >> >
> > >> > initcall is long after SMP. It the real mode trampoline allocation is the
> > >> > only thing that should happen pre-SMP?
> > >>
> > >> early_initcall() should be early enough, those run before SMP init.
> > >
> > > I don't think so. All initcalls run quite late in boot, early ones just run
> > > before the others.
> > >
> >
> > It is documented as running before SMP. If that is no longer true, we should fix the documentation.
>
> Ah, my bad, it is running before SMP.
But then it also runs before page_alloc_init_late(), and it's too early for
free reserved memory with CONFIG_DEFERRED_STRUCT_INIT=y :(
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-02-24 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 7:52 Mike Rapoport
2026-02-23 8:08 ` Ard Biesheuvel
2026-02-23 10:55 ` Mike Rapoport
2026-02-23 11:17 ` Ard Biesheuvel
2026-02-23 11:40 ` Mike Rapoport
2026-02-23 12:18 ` Ard Biesheuvel
2026-02-24 9:28 ` Mike Rapoport
2026-02-24 9:29 ` Ard Biesheuvel
2026-02-24 9:53 ` Mike Rapoport
2026-02-24 9:56 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ11vw7mYmX1onEL@kernel.org \
--to=rppt@kernel.org \
--cc=ardb@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox