From: Matthew Wilcox <willy@infradead.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Brian Geffon <bgeffon@google.com>, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org, Richard Chang <richardycc@google.com>,
David Stevens <stevensd@google.com>
Subject: Re: [PATCH] zram: drop slot trylock and miss_free
Date: Tue, 10 Feb 2026 14:29:35 +0000 [thread overview]
Message-ID: <aYtAz5vQTod7DXqV@casper.infradead.org> (raw)
In-Reply-To: <20260210035045.3817297-1-senozhatsky@chromium.org>
On Tue, Feb 10, 2026 at 12:50:37PM +0900, Sergey Senozhatsky wrote:
> @@ -1943,15 +1927,9 @@ static ssize_t debug_stat_show(struct device *dev,
> {
> int version = 1;
> struct zram *zram = dev_to_zram(dev);
> - ssize_t ret;
>
> guard(rwsem_read)(&zram->dev_lock);
> - ret = sysfs_emit(buf,
> - "version: %d\n0 %8llu\n",
> - version,
> - (u64)atomic64_read(&zram->stats.miss_free));
> -
> - return ret;
> + return sysfs_emit(buf, "version: %d\n0 0\n", version);
> }
You don't need the dev_lock any more to just report the version.
And should the version be changed now that you've changed the format to
not include miss_free?
next prev parent reply other threads:[~2026-02-10 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 3:50 Sergey Senozhatsky
2026-02-10 4:10 ` Sergey Senozhatsky
2026-02-10 14:29 ` Matthew Wilcox [this message]
2026-02-11 3:07 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYtAz5vQTod7DXqV@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bgeffon@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=richardycc@google.com \
--cc=senozhatsky@chromium.org \
--cc=stevensd@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox