From: Matthew Wilcox <willy@infradead.org>
To: xu.xin16@zte.com.cn
Cc: david@kernel.org, akpm@linux-foundation.org,
chengming.zhou@linux.dev, hughd@google.com,
wang.yaxin@zte.com.cn, yang.yang29@zte.com.cn,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: ksm: initialize rmap values directly and make them const
Date: Fri, 6 Feb 2026 15:29:07 +0000 [thread overview]
Message-ID: <aYYIw3h35HOqodAb@casper.infradead.org> (raw)
In-Reply-To: <202602061522548871ohgXN8z0qq87sTSX-yZc@zte.com.cn>
On Fri, Feb 06, 2026 at 03:22:54PM +0800, xu.xin16@zte.com.cn wrote:
> make them const to make code more robust. Besides, since KSM folios are always
> order-0, so folio_nr_pages(KSM folio) is always 1, so the line:
>
> "pgoff_end = pgoff_start + folio_nr_pages(folio) - 1;"
>
> becomes directly:
>
> "pgoff_end = pgoff_start;"
How do you know KSM folios will always be order 0? I don't. NAK this
change.
next prev parent reply other threads:[~2026-02-06 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 7:22 xu.xin16
2026-02-06 8:18 ` David Hildenbrand (Arm)
2026-02-06 8:38 ` xu.xin16
2026-02-06 8:46 ` David Hildenbrand (Arm)
2026-02-06 15:39 ` Andrew Morton
2026-02-06 15:29 ` Matthew Wilcox [this message]
2026-02-06 17:34 ` David Hildenbrand (Arm)
2026-02-06 18:09 ` David Hildenbrand (Arm)
2026-02-06 18:49 ` Matthew Wilcox
2026-02-06 18:57 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYYIw3h35HOqodAb@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wang.yaxin@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox