From: Christoph Hellwig <hch@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Harry Yoo" <harry.yoo@oracle.com>,
"Vernon Yang" <vernon2gm@gmail.com>, 李龙兴 <coregee2000@gmail.com>,
syzkaller@googlegroups.com, akpm@linux-foundation.org,
cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [Kernel Bug] WARNING in mempool_alloc_noprof
Date: Tue, 3 Feb 2026 08:59:02 -0800 [thread overview]
Message-ID: <aYIpVq-jTKyTQE8G@infradead.org> (raw)
In-Reply-To: <6f5881df-0e0b-4278-808b-7c0cffa12a30@suse.cz>
On Tue, Feb 03, 2026 at 05:55:27PM +0100, Vlastimil Babka wrote:
> On 2/3/26 17:27, Christoph Hellwig wrote:
> > On Tue, Feb 03, 2026 at 06:52:39PM +0900, Harry Yoo wrote:
> >> Maybe the changelog could be rephrased a bit,
> >> but overall LGTM, thanks!
> >
> >
> > No, that does not make sense. If mempool is used with __GFP_RECLAIM in
> > the flags it won't fail, and if it isn't, GFP_NOFAIL can't work.
>
> So that means as long as there's __GFP_RECLAIM, __GFP_NOFAIL isn't wrong,
> just redundant.
Given how picky the rest of the mm is about __GFP_NOFAIL, silently
accepting it where it has no (or a weird and unexpected) effect
seems like a disservice to the users.
next prev parent reply other threads:[~2026-02-03 16:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 6:40 李龙兴
2026-02-02 8:39 ` Harry Yoo
2026-02-03 3:47 ` Vernon Yang
2026-02-03 9:52 ` Harry Yoo
2026-02-03 16:27 ` Christoph Hellwig
2026-02-03 16:55 ` Vlastimil Babka
2026-02-03 16:59 ` Christoph Hellwig [this message]
2026-02-03 18:30 ` Vlastimil Babka
2026-02-03 23:01 ` Eric Biggers
2026-02-03 6:44 ` Lance Yang
2026-02-03 8:44 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYIpVq-jTKyTQE8G@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=coregee2000@gmail.com \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=syzkaller@googlegroups.com \
--cc=vbabka@suse.cz \
--cc=vernon2gm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox