linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Balbir Singh <balbirs@nvidia.com>
Cc: oe-kbuild@lists.linux.dev, "Alistair Popple" <apopple@nvidia.com>,
	lkp@intel.com, oe-kbuild-all@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Linux Memory Management List" <linux-mm@kvack.org>,
	"Björn Töpel" <bjorn@rivosinc.com>,
	"Jason Gunthorpe" <jgg@nvidia.com>
Subject: Re: lib/test_hmm.c:932 dmirror_migrate_to_system() error: uninitialized symbol 'ret'.
Date: Tue, 3 Feb 2026 17:44:54 +0300	[thread overview]
Message-ID: <aYIJ5qttFNmL_Roq@stanley.mountain> (raw)
In-Reply-To: <ba7dea85-4bd4-42f7-be04-c23afff5b34b@nvidia.com>

On Tue, Feb 03, 2026 at 09:34:40PM +1100, Balbir Singh wrote:
> > 4c2e0f764eb4444 Alex Sierra     2022-07-15  928  out:
> > 4c2e0f764eb4444 Alex Sierra     2022-07-15  929  	mmap_read_unlock(mm);
> > 4c2e0f764eb4444 Alex Sierra     2022-07-15  930  	mmput(mm);
> > 4c2e0f764eb4444 Alex Sierra     2022-07-15  931  
> > 4c2e0f764eb4444 Alex Sierra     2022-07-15 @932  	return ret;
> > 4c2e0f764eb4444 Alex Sierra     2022-07-15  933  }
> > 
> 
> The code looks older than the current top of master? The smatch warning is still valid though. I was wondering
> did smatch get new heuristics to catch this?

Sorry, I can't explain what happened here.  I had seen the warning before
years ago and not reported it.  :(  I don't know why the zero-day bot is
only complaining now though, or why it blames that specific commit.

regards,
dan carpenter


      reply	other threads:[~2026-02-03 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-18 12:04 Dan Carpenter
2026-02-03 10:34 ` Balbir Singh
2026-02-03 14:44   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYIJ5qttFNmL_Roq@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=balbirs@nvidia.com \
    --cc=bjorn@rivosinc.com \
    --cc=jgg@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox