From: Kiryl Shutsemau <kas@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>, Mike Rapoport <rppt@kernel.org>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Thomas Gleixner <tglx@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
x86@kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Moritz Sanft <ms@edgeless.systems>
Subject: Re: [PATCH 1/2] efi: Fix reservation of unaccepted memory table
Date: Fri, 13 Feb 2026 17:20:14 +0000 [thread overview]
Message-ID: <aY9c80nXefdXjGXh@thinkstation> (raw)
In-Reply-To: <6d6dd421-774c-4f29-84d5-3e449240eb93@intel.com>
On Fri, Feb 13, 2026 at 08:46:55AM -0800, Dave Hansen wrote:
> On 2/13/26 08:14, Kiryl Shutsemau wrote:
> >> The memblock code seems to be able to handle arbitrary alignment just fine.
> > Memblock will track it, but, as the comment says, anything smaller than
> > page size will not be mapped, but we need the table to be accessible by
> > kernel.
>
> That seems really, really fragile.
>
> We should first make sure this is intentional memblock behavior and not
> a bug before we go add more hacks on top of it.
>
> Why would you even present a byte-level reservation interface if it is
> free to just silently ignore some of the ranges by rounding them off later?
+Mike.
My guess that multiple memblock_add() calls might add up to the full
page size.
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2026-02-13 17:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 15:48 [PATCH 0/2] efi: Fix alignenment issues in unaccepted memory code Kiryl Shutsemau (Meta)
2026-02-13 15:48 ` [PATCH 1/2] efi: Fix reservation of unaccepted memory table Kiryl Shutsemau (Meta)
2026-02-13 16:01 ` Dave Hansen
2026-02-13 16:14 ` Kiryl Shutsemau
2026-02-13 16:46 ` Dave Hansen
2026-02-13 17:20 ` Kiryl Shutsemau [this message]
2026-02-14 15:51 ` Mike Rapoport
2026-02-16 14:22 ` Kiryl Shutsemau
2026-02-16 14:51 ` Mike Rapoport
2026-02-16 15:53 ` Dave Hansen
2026-02-16 16:19 ` Mike Rapoport
2026-02-13 15:48 ` [PATCH 2/2] efi: Align unaccepted memory range to page boundary Kiryl Shutsemau (Meta)
2026-02-16 14:51 ` Tom Lendacky
2026-02-16 15:33 ` Kiryl Shutsemau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aY9c80nXefdXjGXh@thinkstation \
--to=kas@kernel.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=ms@edgeless.systems \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox