linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: "Cheatham, Benjamin" <benjamin.cheatham@amd.com>
Cc: linux-mm@kvack.org, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-team@meta.com,
	david@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org,
	rafael@kernel.org, dakr@kernel.org, akpm@linux-foundation.org,
	lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
	vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH] mm: name the anonymous MMOP enum as enum mmop
Date: Thu, 12 Feb 2026 11:33:44 -0500	[thread overview]
Message-ID: <aY4A6CgqvVKyCw5H@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <35db57ae-64cd-40ed-8353-7d3b64069471@amd.com>

On Wed, Feb 11, 2026 at 04:18:45PM -0600, Cheatham, Benjamin wrote:
> On 2/11/2026 3:54 PM, Gregory Price wrote:
> >  
> > @@ -77,7 +78,7 @@ enum memory_block_state {
> >  struct memory_block {
> >  	unsigned long start_section_nr;
> >  	enum memory_block_state state;	/* serialized by the dev->lock */
> > -	int online_type;		/* for passing data to online routine */
> > +	enum mmop online_type;	/* for passing data to online routine */
> 
> Comment looks unaligned.
> 

Ah yeah was already unaligned. Bleh.

Probably not worth a full v2 unless Andrew prefers that.

~Gregory


  reply	other threads:[~2026-02-12 16:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 21:54 Gregory Price
2026-02-11 22:18 ` Cheatham, Benjamin
2026-02-12 16:33   ` Gregory Price [this message]
2026-02-12  8:56 ` David Hildenbrand (Arm)
2026-02-12 16:03 ` Dave Jiang
2026-02-12 18:13 ` Davidlohr Bueso
2026-02-19 11:18 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aY4A6CgqvVKyCw5H@gourry-fedora-PF4VCD3F \
    --to=gourry@gourry.net \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=benjamin.cheatham@amd.com \
    --cc=dakr@kernel.org \
    --cc=david@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathan.cameron@huawei.com \
    --cc=kernel-team@meta.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=rafael@kernel.org \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox