From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
akpm@linux-foundation.org,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 0/3] Convert x86/mm/pat to ptdescs
Date: Wed, 28 Jan 2026 11:17:17 -0800 [thread overview]
Message-ID: <aXpgvYe1BySUXnKf@fedora> (raw)
In-Reply-To: <aXn4i6Zo8OKyVoCL@kernel.org>
On Wed, Jan 28, 2026 at 01:52:43PM +0200, Mike Rapoport wrote:
> Hi Vishal,
>
> On Mon, Jan 26, 2026 at 04:51:37PM -0800, Vishal Moola (Oracle) wrote:
> > x86/mm/pat should be using ptdescs. One line has already been
> > converted to pagetable_free(), while the allocation sites use
> > get_free_pages(). This causes issues separately allocating ptdescs
> > from struct page.
> >
> > These patches convert the allocation/free sites to use ptdescs. In
> > the short term, this helps enable Matthew's work to allocate frozen
> > pagetables. And in the long term, this will help us cleanly split
> > ptdesc allocations from struct page.
> >
> > ------
> >
> > Based on current mm-new.
> >
> > Vishal Moola (Oracle) (3):
> > x86/mm/pat: Convert pte code to use ptdescs
> > x86/mm/pat: Convert pmd code to use ptdescs
>
> There are still get_zeroed_page() calls in populate_pgd(). I think they
> also should be converted to pagetable_alloc().
Thanks, I missed those. They should be converted too, so I'll add those
in v2.
> Other than that LGTM.
>
> > x86/mm/pat: Convert split_large_page() to use ptdescs
> >
> > arch/x86/mm/pat/set_memory.c | 37 +++++++++++++++++++-----------------
> > 1 file changed, 20 insertions(+), 17 deletions(-)
> >
> > --
> > 2.52.0
> >
>
> --
> Sincerely yours,
> Mike.
prev parent reply other threads:[~2026-01-28 19:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 0:51 Vishal Moola (Oracle)
2026-01-27 0:51 ` [PATCH 1/3] x86/mm/pat: Convert pte code to use ptdescs Vishal Moola (Oracle)
2026-01-27 0:51 ` [PATCH 2/3] x86/mm/pat: Convert pmd " Vishal Moola (Oracle)
2026-01-27 0:51 ` [PATCH 3/3] x86/mm/pat: Convert split_large_page() " Vishal Moola (Oracle)
2026-01-28 11:52 ` [PATCH 0/3] Convert x86/mm/pat to ptdescs Mike Rapoport
2026-01-28 19:17 ` Vishal Moola (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXpgvYe1BySUXnKf@fedora \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox