From: Breno Leitao <leitao@debian.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Alexander Graf <graf@amazon.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
linux-mm@kvack.org, usamaarif642@gmail.com, rmikey@meta.com,
clm@fb.com, riel@surriel.com, SeongJae Park <sj@kernel.org>,
kernel-team@meta.com
Subject: Re: [PATCH v5 2/4] kho: rename fdt parameter to blob in kho_add/remove_subtree()
Date: Tue, 27 Jan 2026 05:41:22 -0800 [thread overview]
Message-ID: <aXi_ppb4P1QFSqR7@gmail.com> (raw)
In-Reply-To: <aXhovDdoLqcmSWVW@kernel.org>
Helo Mike,
On Tue, Jan 27, 2026 at 09:26:52AM +0200, Mike Rapoport wrote:
> On Mon, Jan 26, 2026 at 08:07:24AM -0800, Breno Leitao wrote:
> > Since kho_add_subtree() now accepts arbitrary data blobs (not just
> > FDTs), rename the parameter from 'fdt' to 'blob' to better reflect
> > its purpose. Apply the same rename to kho_remove_subtree() for
> > consistency.
>
> So if we are doing renames, let's take care of kho_debugfs_fdt_*() as well.
Sure. I am happy to do it. I will update the functions name as well,
basically s/fdt/blob in the function defition.
Something like:
kho_debugfs_blob_add(struct kho_debugfs *dbg, const char *name,
const void *blob, size_t size, bool root)
void kho_debugfs_blob_remove(struct kho_debugfs *dbg, void *blob);
Thanks for the review,
--breno
next prev parent reply other threads:[~2026-01-27 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 16:07 [PATCH v5 0/4] kho: history: track previous kernel version and kexec boot count Breno Leitao
2026-01-26 16:07 ` [PATCH v5 1/4] kho: add size parameter to kho_add_subtree() Breno Leitao
2026-01-27 7:23 ` Mike Rapoport
2026-01-27 7:25 ` Mike Rapoport
2026-01-26 16:07 ` [PATCH v5 2/4] kho: rename fdt parameter to blob in kho_add/remove_subtree() Breno Leitao
2026-01-27 7:26 ` Mike Rapoport
2026-01-27 13:41 ` Breno Leitao [this message]
2026-01-26 16:07 ` [PATCH v5 3/4] kho: kexec-metadata: track previous kernel chain Breno Leitao
2026-01-27 7:31 ` Mike Rapoport
2026-01-26 16:07 ` [PATCH v5 4/4] kho: document kexec-metadata tracking feature Breno Leitao
2026-01-27 7:32 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXi_ppb4P1QFSqR7@gmail.com \
--to=leitao@debian.org \
--cc=clm@fb.com \
--cc=graf@amazon.com \
--cc=kernel-team@meta.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=riel@surriel.com \
--cc=rmikey@meta.com \
--cc=rppt@kernel.org \
--cc=sj@kernel.org \
--cc=usamaarif642@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox