linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Tycho Andersen <tycho@kernel.org>
Cc: Alexander Graf <graf@amazon.com>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	kexec@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kho: fix doc for kho_restore_pages()
Date: Sun, 25 Jan 2026 13:50:58 +0200	[thread overview]
Message-ID: <aXYDov8RruYZszaQ@kernel.org> (raw)
In-Reply-To: <20260123190506.1058669-1-tycho@kernel.org>

On Fri, Jan 23, 2026 at 12:05:06PM -0700, Tycho Andersen wrote:
> From: "Tycho Andersen (AMD)" <tycho@kernel.org>
> 
> This function returns NULL if kho_restore_page() returns NULL, which
> happens in a couple of corner cases. It never returns an error code.
> 
> Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>

Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
>  kernel/liveupdate/kexec_handover.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index d4482b6e3cae..4c38ea7987c8 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -281,7 +281,7 @@ EXPORT_SYMBOL_GPL(kho_restore_folio);
>   * Restore a contiguous list of order 0 pages that was preserved with
>   * kho_preserve_pages().
>   *
> - * Return: 0 on success, error code on failure
> + * Return: the first page on success, NULL on failure.
>   */
>  struct page *kho_restore_pages(phys_addr_t phys, unsigned int nr_pages)
>  {
> 
> base-commit: c072629f05d7bca1148ab17690d7922a31423984
> -- 
> 2.52.0
> 

-- 
Sincerely yours,
Mike.


  reply	other threads:[~2026-01-25 11:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23 19:05 Tycho Andersen
2026-01-25 11:50 ` Mike Rapoport [this message]
2026-01-26 12:48 ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXYDov8RruYZszaQ@kernel.org \
    --to=rppt@kernel.org \
    --cc=graf@amazon.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    --cc=tycho@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox