From: Christoph Hellwig <hch@infradead.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] f2fs: improve readahead for POSIX_FADV_WILLNEED
Date: Thu, 22 Jan 2026 00:34:28 -0800 [thread overview]
Message-ID: <aXHhFN-feFYFcKYu@infradead.org> (raw)
In-Reply-To: <aSCpzRW8mUhNnjHB@google.com>
On Fri, Nov 21, 2025 at 06:05:01PM +0000, Jaegeuk Kim wrote:
> On 11/20, Christoph Hellwig wrote:
> > On Fri, Nov 21, 2025 at 01:42:01AM +0000, Jaegeuk Kim wrote:
> > > This patch boosts readahead for POSIX_FADV_WILLNEED.
> >
> > How? That's not a good changelog.
> >
> > Also open coding the read-ahead logic is not a good idea. The only
> > f2fs-specific bits are the compression check, and the extent precaching,
> > but you surely should be able to share a read-ahead helper with common
> > code instead of duplicating the logic.
>
> Ok, let me try to write up and post a generic version of the changes.
Did this go anywhere?
next prev parent reply other threads:[~2026-01-22 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251121014202.1969909-1-jaegeuk@kernel.org>
2025-11-21 6:49 ` Christoph Hellwig
2025-11-21 18:05 ` Jaegeuk Kim
2026-01-22 8:34 ` Christoph Hellwig [this message]
2026-01-22 23:26 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXHhFN-feFYFcKYu@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox