linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@linux.dev>
To: ranxiaokai627@163.com
Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org,
	corbet@lwn.net,  david@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,  linux-mm@kvack.org,
	lorenzo.stoakes@oracle.com, mhocko@suse.com,
	 ran.xiaokai@zte.com.cn, rppt@kernel.org, surenb@google.com,
	vbabka@suse.cz
Subject: Re: [PATCH] alloc_tag: remove sysctl prefix from mem_profiling boot parameter
Date: Mon, 12 Jan 2026 22:50:06 -0500	[thread overview]
Message-ID: <aWXAaiLXn2tXr8nU@moria.home.lan> (raw)
In-Reply-To: <20260113032735.161838-1-ranxiaokai627@163.com>

On Tue, Jan 13, 2026 at 03:27:35AM +0000, ranxiaokai627@163.com wrote:
> >On Fri, Jan 09, 2026 at 06:24:19AM +0000, ranxiaokai627@163.com wrote:
> >> From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> >> 
> >> Boot parameters prefixed with "sysctl." are processed separately
> >> during the final stage of system initialization via kernel_init()->
> >> do_sysctl_args(). Since mem_profiling support should be parsed
> >> in early boot stage, it is unsuitable for centralized handling
> >> in do_sysctl_args().
> >> Also, when CONFIG_MEM_ALLOC_PROFILING_DEBUG is enabled,
> >> the sysctl.vm.mem_profiling entry is not writable and will cause
> >> a warning. To prevent duplicate processing of sysctl.vm.mem_profiling,
> >> rename the boot parameter to "mem_profiling".
> >> 
> >> Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> >
> >How was this observed/detected?
> 
> Actually no kernel bug or funtional defect was observed through testing.
> Via code reading, i found after commit [1],
> boot parameters prefixed with sysctl is processed redundantly.

When bcachefs was in the kernel, I spent an inordinate amount of time in
code reviews trying to convince people that yes, they really do need to
be testing their code.

Strangely enough, I have never had this issue with project contributors
who did not come to the project by way of the kernel community... :)


      reply	other threads:[~2026-01-13  3:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09  6:24 ranxiaokai627
2026-01-11  2:12 ` Andrew Morton
2026-01-11  2:33 ` Kent Overstreet
2026-01-11 19:50   ` Suren Baghdasaryan
2026-01-12 17:00     ` Suren Baghdasaryan
2026-01-13  3:27   ` ranxiaokai627
2026-01-13  3:50     ` Kent Overstreet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWXAaiLXn2tXr8nU@moria.home.lan \
    --to=kent.overstreet@linux.dev \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=ran.xiaokai@zte.com.cn \
    --cc=ranxiaokai627@163.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox