* [PATCH] mm: numa,memblock: include <asm/numa.h> for 'numa_nodes_parsed'
@ 2026-01-08 10:15 Ben Dooks
2026-01-08 18:52 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2026-01-08 10:15 UTC (permalink / raw)
To: akpm, linux-kernel, linux-mm; +Cc: rppt, Ben Dooks
The 'numa_nodes_parsed' is defined in <asm/numa.h> but this file
is not included in mm/numa_memblks.c (build x86_64) so add this
to the incldues to fix the following sparse warning:
mm/numa_memblks.c:13:12: warning: symbol 'numa_nodes_parsed' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
mm/numa_memblks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c
index 5b009a9cd8b4..8f5735fda0a2 100644
--- a/mm/numa_memblks.c
+++ b/mm/numa_memblks.c
@@ -7,6 +7,8 @@
#include <linux/numa.h>
#include <linux/numa_memblks.h>
+#include <asm/numa.h>
+
int numa_distance_cnt;
static u8 *numa_distance;
--
2.37.2.352.g3c44437643
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: numa,memblock: include <asm/numa.h> for 'numa_nodes_parsed'
2026-01-08 10:15 [PATCH] mm: numa,memblock: include <asm/numa.h> for 'numa_nodes_parsed' Ben Dooks
@ 2026-01-08 18:52 ` Andrew Morton
2026-01-11 9:05 ` Mike Rapoport
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2026-01-08 18:52 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, linux-mm, rppt
On Thu, 8 Jan 2026 10:15:39 +0000 Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The 'numa_nodes_parsed' is defined in <asm/numa.h> but this file
> is not included in mm/numa_memblks.c (build x86_64) so add this
> to the incldues to fix the following sparse warning:
>
> mm/numa_memblks.c:13:12: warning: symbol 'numa_nodes_parsed' was not declared. Should it be static?
>
huh, I wonder how that snuck through and survived more than a
year.
Thanks, I'll add
Fixes: 87482708210f ("mm: introduce numa_memblks")
Cc: <stable@vger.kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: numa,memblock: include <asm/numa.h> for 'numa_nodes_parsed'
2026-01-08 18:52 ` Andrew Morton
@ 2026-01-11 9:05 ` Mike Rapoport
0 siblings, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2026-01-11 9:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: Ben Dooks, linux-kernel, linux-mm
On Thu, Jan 08, 2026 at 10:52:20AM -0800, Andrew Morton wrote:
> On Thu, 8 Jan 2026 10:15:39 +0000 Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> > The 'numa_nodes_parsed' is defined in <asm/numa.h> but this file
> > is not included in mm/numa_memblks.c (build x86_64) so add this
> > to the incldues to fix the following sparse warning:
> >
> > mm/numa_memblks.c:13:12: warning: symbol 'numa_nodes_parsed' was not declared. Should it be static?
> >
>
> huh, I wonder how that snuck through and survived more than a
> year.
Probably most configs include <asm/numa.h> as other header dependencies and
Ben's config does not for some reason.
> Thanks, I'll add
>
> Fixes: 87482708210f ("mm: introduce numa_memblks")
> Cc: <stable@vger.kernel.org>
and please add
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-11 9:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-08 10:15 [PATCH] mm: numa,memblock: include <asm/numa.h> for 'numa_nodes_parsed' Ben Dooks
2026-01-08 18:52 ` Andrew Morton
2026-01-11 9:05 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox