From: Matthew Wilcox <willy@infradead.org>
To: Zhiguo Zhou <zhiguo.zhou@intel.com>
Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org,
david@kernel.org, gang.deng@intel.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, lorenzo.stoakes@oracle.com, mhocko@suse.com,
muchun.song@linux.dev, osalvador@suse.de, rppt@kernel.org,
surenb@google.com, tianyou.li@intel.com,
tim.c.chen@linux.intel.com, vbabka@suse.cz
Subject: Re: [PATCH v2 0/2] mm/readahead: batch folio insertion to improve performance
Date: Mon, 19 Jan 2026 14:15:26 +0000 [thread overview]
Message-ID: <aW48fk0IVus32QtW@casper.infradead.org> (raw)
In-Reply-To: <20260119100301.922922-1-zhiguo.zhou@intel.com>
On Mon, Jan 19, 2026 at 06:02:57PM +0800, Zhiguo Zhou wrote:
> This patch series improves readahead performance by batching folio
> insertions into the page cache's xarray, reducing the cacheline transfers,
> and optimizing the execution efficiency in the critical section.
1. Don't resend patches immediately. Wait for feedback.
2. Don't send v2 as a reply to v1. New thread.
3. This is unutterably ugly.
4. Passing boolean parameters to functions is an antipattern. You
never know at the caller site what 'true' or 'false' means.
5. Passing 'is_locked' is specifically an antipattern of its own.
6. You've EXPORTed a symbol that has no in-tree modular user.
7. Do you want to keep trying to do this or do you want me to do it
properly? I don't have much patience for doing development by patch
feedback, not for something as sensitive as the page cache.
prev parent reply other threads:[~2026-01-19 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 6:50 [PATCH " Zhiguo Zhou
2026-01-19 6:50 ` [PATCH 1/2] mm/filemap: refactor __filemap_add_folio to separate critical section Zhiguo Zhou
2026-01-19 8:34 ` kernel test robot
2026-01-19 9:16 ` kernel test robot
2026-01-19 6:50 ` [PATCH 2/2] mm/readahead: batch folio insertion to improve performance Zhiguo Zhou
2026-01-19 10:02 ` [PATCH v2 0/2] " Zhiguo Zhou
2026-01-19 10:02 ` [PATCH v2 1/2] mm/filemap: refactor __filemap_add_folio to separate critical section Zhiguo Zhou
2026-01-19 10:02 ` [PATCH v2 2/2] mm/readahead: batch folio insertion to improve performance Zhiguo Zhou
2026-01-19 10:38 ` [PATCH v2 0/2] mm/readahead: Changes since v1 Zhiguo Zhou
2026-01-19 14:15 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW48fk0IVus32QtW@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=gang.deng@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=tianyou.li@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vbabka@suse.cz \
--cc=zhiguo.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox