* Re: [PATCH] powerpc/kdump: pass dm-crypt keys to kdump kernel
[not found] <20251226140636.1378505-1-coxu@redhat.com>
@ 2025-12-27 14:35 ` kernel test robot
2026-01-06 7:46 ` Coiby Xu
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2025-12-27 14:35 UTC (permalink / raw)
To: Coiby Xu, kexec, linuxppc-dev
Cc: llvm, oe-kbuild-all, Thomas Staudt, Arnaud Lefebvre, Baoquan he,
Dave Young, Kairui Song, Pingfan Liu, Andrew Morton,
Linux Memory Management List, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy (CS GROUP),
linux-kernel
Hi Coiby,
kernel test robot noticed the following build errors:
[auto build test ERROR on ccd1cdca5cd433c8a5dff78b69a79b31d9b77ee1]
url: https://github.com/intel-lab-lkp/linux/commits/Coiby-Xu/powerpc-kdump-pass-dm-crypt-keys-to-kdump-kernel/20251226-220726
base: ccd1cdca5cd433c8a5dff78b69a79b31d9b77ee1
patch link: https://lore.kernel.org/r/20251226140636.1378505-1-coxu%40redhat.com
patch subject: [PATCH] powerpc/kdump: pass dm-crypt keys to kdump kernel
config: powerpc64-randconfig-001-20251227 (https://download.01.org/0day-ci/archive/20251227/202512272218.ghBaSjzO-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 4ef602d446057dabf5f61fb221669ecbeda49279)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251227/202512272218.ghBaSjzO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512272218.ghBaSjzO-lkp@intel.com/
All errors (new ones prefixed by >>):
>> arch/powerpc/kexec/elf_64.c:95:9: error: call to undeclared function 'crash_load_dm_crypt_keys'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
95 | ret = crash_load_dm_crypt_keys(image);
| ^
1 error generated.
vim +/crash_load_dm_crypt_keys +95 arch/powerpc/kexec/elf_64.c
27
28 static void *elf64_load(struct kimage *image, char *kernel_buf,
29 unsigned long kernel_len, char *initrd,
30 unsigned long initrd_len, char *cmdline,
31 unsigned long cmdline_len)
32 {
33 int ret;
34 unsigned long kernel_load_addr;
35 unsigned long initrd_load_addr = 0, fdt_load_addr;
36 void *fdt;
37 const void *slave_code;
38 struct elfhdr ehdr;
39 char *modified_cmdline = NULL;
40 struct crash_mem *rmem = NULL;
41 struct kexec_elf_info elf_info;
42 struct kexec_buf kbuf = { .image = image, .buf_min = 0,
43 .buf_max = ppc64_rma_size };
44 struct kexec_buf pbuf = { .image = image, .buf_min = 0,
45 .buf_max = ppc64_rma_size, .top_down = true,
46 .mem = KEXEC_BUF_MEM_UNKNOWN };
47
48 ret = kexec_build_elf_info(kernel_buf, kernel_len, &ehdr, &elf_info);
49 if (ret)
50 return ERR_PTR(ret);
51
52 if (IS_ENABLED(CONFIG_CRASH_DUMP) && image->type == KEXEC_TYPE_CRASH) {
53 /* min & max buffer values for kdump case */
54 kbuf.buf_min = pbuf.buf_min = crashk_res.start;
55 kbuf.buf_max = pbuf.buf_max =
56 ((crashk_res.end < ppc64_rma_size) ?
57 crashk_res.end : (ppc64_rma_size - 1));
58 }
59
60 ret = kexec_elf_load(image, &ehdr, &elf_info, &kbuf, &kernel_load_addr);
61 if (ret)
62 goto out;
63
64 kexec_dprintk("Loaded the kernel at 0x%lx\n", kernel_load_addr);
65
66 ret = kexec_load_purgatory(image, &pbuf);
67 if (ret) {
68 pr_err("Loading purgatory failed.\n");
69 goto out;
70 }
71
72 kexec_dprintk("Loaded purgatory at 0x%lx\n", pbuf.mem);
73
74 /* Load additional segments needed for panic kernel */
75 if (IS_ENABLED(CONFIG_CRASH_DUMP) && image->type == KEXEC_TYPE_CRASH) {
76 ret = load_crashdump_segments_ppc64(image, &kbuf);
77 if (ret) {
78 pr_err("Failed to load kdump kernel segments\n");
79 goto out;
80 }
81
82 /* Setup cmdline for kdump kernel case */
83 modified_cmdline = setup_kdump_cmdline(image, cmdline,
84 cmdline_len,
85 "elfcorehdr",
86 image->elf_load_addr);
87 if (!modified_cmdline) {
88 pr_err("Setting up cmdline for kdump kernel failed\n");
89 ret = -EINVAL;
90 goto out;
91 }
92 cmdline = modified_cmdline;
93 cmdline_len = strlen(cmdline) + 1;
94
> 95 ret = crash_load_dm_crypt_keys(image);
96 if (ret == -ENOENT) {
97 kexec_dprintk("No dm crypt key to load\n");
98 } else if (ret) {
99 pr_err("Failed to load dm crypt keys\n");
100 return ERR_PTR(ret);
101 }
102
103 if (image->dm_crypt_keys_addr != 0) {
104 modified_cmdline = setup_kdump_cmdline(image, cmdline,
105 cmdline_len,
106 "dmcryptkeys",
107 image->dm_crypt_keys_addr);
108 if (!modified_cmdline) {
109 pr_err("Setting up cmdline for kdump kernel failed\n");
110 ret = -EINVAL;
111 goto out;
112 }
113 cmdline = modified_cmdline;
114 }
115 }
116
117 if (initrd != NULL) {
118 kbuf.buffer = initrd;
119 kbuf.bufsz = kbuf.memsz = initrd_len;
120 kbuf.buf_align = PAGE_SIZE;
121 kbuf.top_down = false;
122 kbuf.mem = KEXEC_BUF_MEM_UNKNOWN;
123 ret = kexec_add_buffer(&kbuf);
124 if (ret)
125 goto out;
126 initrd_load_addr = kbuf.mem;
127
128 kexec_dprintk("Loaded initrd at 0x%lx\n", initrd_load_addr);
129 }
130
131 ret = get_reserved_memory_ranges(&rmem);
132 if (ret)
133 goto out;
134
135 fdt = of_kexec_alloc_and_setup_fdt(image, initrd_load_addr,
136 initrd_len, cmdline,
137 kexec_extra_fdt_size_ppc64(image, rmem));
138 if (!fdt) {
139 pr_err("Error setting up the new device tree.\n");
140 ret = -EINVAL;
141 goto out;
142 }
143
144 ret = setup_new_fdt_ppc64(image, fdt, rmem);
145 if (ret)
146 goto out_free_fdt;
147
148 if (!IS_ENABLED(CONFIG_CRASH_HOTPLUG) || image->type != KEXEC_TYPE_CRASH)
149 fdt_pack(fdt);
150
151 kbuf.buffer = fdt;
152 kbuf.bufsz = kbuf.memsz = fdt_totalsize(fdt);
153 kbuf.buf_align = PAGE_SIZE;
154 kbuf.top_down = true;
155 kbuf.mem = KEXEC_BUF_MEM_UNKNOWN;
156 ret = kexec_add_buffer(&kbuf);
157 if (ret)
158 goto out_free_fdt;
159
160 /* FDT will be freed in arch_kimage_file_post_load_cleanup */
161 image->arch.fdt = fdt;
162
163 fdt_load_addr = kbuf.mem;
164
165 kexec_dprintk("Loaded device tree at 0x%lx\n", fdt_load_addr);
166
167 slave_code = elf_info.buffer + elf_info.proghdrs[0].p_offset;
168 ret = setup_purgatory_ppc64(image, slave_code, fdt, kernel_load_addr,
169 fdt_load_addr);
170 if (ret)
171 pr_err("Error setting up the purgatory.\n");
172
173 goto out;
174
175 out_free_fdt:
176 kvfree(fdt);
177 out:
178 kfree(rmem);
179 kfree(modified_cmdline);
180 kexec_free_elf_info(&elf_info);
181
182 return ret ? ERR_PTR(ret) : NULL;
183 }
184
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread