linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Calvin Owens <calvin@wbinvd.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Shivank Garg <shivankg@amd.com>
Subject: Re: [BUG next-20260105] khugepaged: kernel BUG at ./include/linux/xarray.h:1441
Date: Mon, 5 Jan 2026 18:31:28 +0000	[thread overview]
Message-ID: <aVwDgMWsHqebuu0j@casper.infradead.org> (raw)
In-Reply-To: <aVv-nloKXjqyfrFP@mozart.vkv.me>

On Mon, Jan 05, 2026 at 10:10:38AM -0800, Calvin Owens wrote:
> On Monday 01/05 at 09:51 -0800, Andrew Morton wrote:
> > That's
> > 
> > static inline struct xa_state *XAS_INVALID(struct xa_state *xas)
> > {
> > 	XA_NODE_BUG_ON(xas->xa_node, xas_valid(xas));
> > 	return xas;
> > }
> > 
> > which was added by Willy's 43b00759f21b ("XArray: Add extra debugging
> > check to xas_lock and friends").  Maybe it found a bug.
> > 
> > I'm not actually sure how 43b00759f21b found its way into linux-next. 
> > It isn't in mainline.

It's in the xarray tree.  git://git.infradead.org/users/willy/xarray.git#main

> > I'm seeing no other changes to xarray.  mm.git's khugepaged does have a
> > bunch of changes which Shivank added, so I'll cc Shivank and hopefully
> > he can spot something?
> > 
> > Can you suggest how others could reproduce this?
> 
> It triggers immediately after boot for me on any QEMU VM, one of them is
> an empty husk that runs nothing but sshd.
> 
> FWIW (not much I guess), I disabled DEBUG_XARRAY, and the first VM has
> been happily running next-20260105 that way for about an hour. The
> workload is seeding distro install ISOs with transmission.

It's checking for something which _could_ be a problem.  So it'll catch
any sloppy uses, and doesn't necessarily mean it'll be a problem.
It may be as simple as moving a call to xas_reset() or adding one
(see the other fixes in 43b00759f21b particularly the ones which affect
the test suite).


  reply	other threads:[~2026-01-05 18:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05 17:24 Calvin Owens
2026-01-05 17:51 ` Andrew Morton
2026-01-05 18:10   ` Calvin Owens
2026-01-05 18:31     ` Matthew Wilcox [this message]
2026-01-05 18:24 ` Matthew Wilcox
2026-01-05 18:48   ` Calvin Owens
2026-01-05 19:22     ` Matthew Wilcox
2026-01-05 19:54       ` Shivank Garg
2026-01-05 21:02         ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aVwDgMWsHqebuu0j@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=calvin@wbinvd.org \
    --cc=david@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=shivankg@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox