From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: wujing <realwujing@qq.com>, Vlastimil Babka <vbabka@suse.cz>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Qiliang Yuan <yuanql9@chinatelecom.cn>
Subject: Re: [PATCH 1/1] mm/page_alloc: auto-tune min_free_kbytes on atomic allocation failure
Date: Mon, 5 Jan 2026 02:32:38 +0000 [thread overview]
Message-ID: <aVsixmk_D99cZqz5@casper.infradead.org> (raw)
In-Reply-To: <20260104101443.f10264bc9730de884b52c5a2@linux-foundation.org>
On Sun, Jan 04, 2026 at 10:14:43AM -0800, Andrew Morton wrote:
> On Sun, 4 Jan 2026 20:26:52 +0800 wujing <realwujing@qq.com> wrote:
>
> > Introduce a mechanism to dynamically increase vm.min_free_kbytes when
> > critical atomic allocations (GFP_ATOMIC, order-0) fail. This prevents
> > recurring network packet drops or other atomic failures by proactively
> > reserving more memory.
>
> Seems like a good idea, however it's very likely that the networking
> people have looked into this rather a lot. Can I suggest that you
> engage with them? netdev@vger.kernel.org.
Agreed, the networking people should definitely be brought into this.
I'm broadly in favour of something like this patch. We should do more
auto-tuning and less reliant on sysadmin intervention. I have two
questions:
1. Is doubling too aggressive? Would an increase of, say, 10% or 20%
be more appropriate?
2. Do we have to wait for failure before increasing? Could we schedule
the increase for when we get to within, say, 10% of the current limit?
> > The adjustment doubles min_free_kbytes upon upon failure (exponential backoff),
> > capped at 1% of total RAM.
>
> But no attempt to reduce it again after the load spike has gone away.
Hm, how would we do that? Automatically decay by 5%, 300 seconds after
increasing; then schedule another decay for 300 seconds after that until
we get down to something appropriately smaller?
> > + /* Auto-tuning: trigger boost if atomic allocation fails */
> > + if ((gfp_mask & GFP_ATOMIC) && order == 0)
> > + schedule_work(&boost_min_free_kbytes_work);
> > +
>
> Probably this should be selectable and tunable via a kernel boot
> parameter or a procfs tunable. But I suggest you not do that work
> until having discussed the approach with the networking developers.
Ugh, please, no new tunables. Let's just implement an algorithm that
works.
next prev parent reply other threads:[~2026-01-05 2:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 12:23 [PATCH 0/1] mm/page_alloc: dynamic min_free_kbytes adjustment wujing
2026-01-04 12:26 ` [PATCH 1/1] mm/page_alloc: auto-tune min_free_kbytes on atomic allocation failure wujing
2026-01-04 18:14 ` Andrew Morton
2026-01-05 2:32 ` Matthew Wilcox [this message]
2026-01-05 6:38 ` Lance Yang
2026-01-05 7:29 ` wujing
2026-01-05 16:47 ` Michal Hocko
2026-01-05 8:17 ` [PATCH v2 0/1] mm/page_alloc: dynamic min_free_kbytes adjustment wujing
2026-01-05 11:59 ` [PATCH v3 0/1] mm/page_alloc: dynamic watermark boosting wujing
[not found] ` <20260105115943.1361645-1-realwujing@qq.com>
2026-01-05 11:59 ` [PATCH v3 1/1] mm/page_alloc: auto-tune watermarks on atomic allocation failure wujing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVsixmk_D99cZqz5@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=realwujing@qq.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=yuanql9@chinatelecom.cn \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox