From: Klara Modin <klarasmodin@gmail.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alex Shi <alexs@kernel.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Andreas Larsson <andreas@gaisler.com>,
Borislav Petkov <bp@alien8.de>, Brian Cain <bcain@kernel.org>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Dave Hansen <dave.hansen@linux.intel.com>,
David Hildenbrand <david@kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Guo Ren <guoren@kernel.org>, Heiko Carstens <hca@linux.ibm.com>,
Helge Deller <deller@gmx.de>,
Huacai Chen <chenhuacai@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Johannes Berg <johannes@sipsolutions.net>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Jonathan Corbet <corbet@lwn.net>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Magnus Lindholm <linmag7@gmail.com>,
Matt Turner <mattst88@gmail.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Michal Hocko <mhocko@suse.com>, Michal Simek <monstr@monstr.eu>,
Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
Palmer Dabbelt <palmer@dabbelt.com>,
Pratyush Yadav <pratyush@kernel.org>,
Richard Weinberger <richard@nod.at>,
Russell King <linux@armlinux.org.uk>,
Stafford Horne <shorne@gmail.com>,
Suren Baghdasaryan <surenb@google.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Thomas Gleixner <tglx@linutronix.de>,
Vasily Gorbik <gor@linux.ibm.com>,
Vineet Gupta <vgupta@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, Will Deacon <will@kernel.org>,
x86@kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-mm@kvack.org, linux-openrisc@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
loongarch@lists.linux.dev, sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 22/28] arch, mm: consolidate initialization of nodes, zones and memory map
Date: Sat, 3 Jan 2026 00:33:29 +0100 [thread overview]
Message-ID: <aVhN2NgQEKe0yzva@soda.int.kasm.eu> (raw)
In-Reply-To: <20260102070005.65328-23-rppt@kernel.org>
Hi,
On 2026-01-02 08:59:58 +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> To initialize node, zone and memory map data structures every architecture
> calls free_area_init() during setup_arch() and passes it an array of zone
> limits.
>
> Beside code duplication it creates "interesting" ordering cases between
> allocation and initialization of hugetlb and the memory map. Some
> architectures allocate hugetlb pages very early in setup_arch() in certain
> cases, some only create hugetlb CMA areas in setup_arch() and sometimes
> hugetlb allocations happen mm_core_init().
>
> With arch_zone_limits_init() helper available now on all architectures it
> is no longer necessary to call free_area_init() from architecture setup
> code. Rather core MM initialization can call arch_zone_limits_init() in a
> single place.
>
> This allows to unify ordering of hugetlb vs memory map allocation and
> initialization.
>
> Remove the call to free_area_init() from architecture specific code and
> place it in a new mm_core_init_early() function that is called immediately
> after setup_arch().
>
> After this refactoring it is possible to consolidate hugetlb allocations
> and eliminate differences in ordering of hugetlb and memory map
> initialization among different architectures.
>
> As the first step of this consolidation move hugetlb_bootmem_alloc() to
> mm_core_early_init().
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
This breaks boot on my Raspberry Pi 1. The reason seems to be the use of
page_folio() when initializing the dynamically allocated zero page in
arm, which doesn't work when free_area_init() hasn't been called yet.
The following oopses are generated:
Booting Linux on physical CPU 0x0
Linux version 6.19.0-rc3-03898-g7975b0084358 (klara@soda.int.kasm.eu) (armv6j-unknown-linux-gnueabihf-gcc (Gentoo 15.2.1_p20251122 p3) 15.2.1 20251122, GNU ld (Gentoo 2.45.1 p1) 2.45.1) #451 Fri Jan 2 20:26:00 CET 2026
CPU: ARMv6-compatible processor [410fb767] revision 7 (ARMv7), cr=00c5387d
CPU: PIPT / VIPT nonaliasing data cache, VIPT nonaliasing instruction cache
OF: fdt: Machine model: Raspberry Pi Model B Rev 2
earlycon: pl11 at MMIO32 0x20201000 (options '')
printk: legacy bootconsole [pl11] enabled
Memory policy: Data cache writeback
Reserved memory: created CMA memory pool at 0x19400000, size 64 MiB
OF: reserved mem: initialized node linux,cma, compatible id shared-dma-pool
OF: reserved mem: 0x19400000..0x1d3fffff (65536 KiB) map reusable linux,cma
8<--- cut here ---
Unable to handle kernel paging request at virtual address 003dfb44 when read
[003dfb44] *pgd=00000000
Internal error: Oops: 5 [#1] ARM
CPU: 0 UID: 0 PID: 0 Comm: swapper Not tainted 6.19.0-rc3-03898-g7975b0084358 #451 NONE
Hardware name: BCM2835
PC is at paging_init (include/linux/page-flags.h:284 (discriminator 2) arch/arm/mm/mmu.c:1790 (discriminator 2))
LR is at paging_init (arch/arm/mm/mmu.c:1789 (discriminator 1))
pc : lr : psr: 600000d3
sp : c0d01ef8 ip : defdb000 fp : 0000000b
r10: 00200000 r9 : d9400000 r8 : ffe00000
r7 : c0d09050 r6 : c0d0902c r5 : c0d43d40 r4 : 0001efda
r3 : c0dab20c r2 : 00000000 r1 : 003dfb40 r0 : 00000000
Flags: nZCv IRQs off FIQs off Mode SVC_32 ISA ARM Segment none
Control: 00c5387d Table: 00004008 DAC: 00000051
Register r0 information: NULL pointer
Register r1 information: non-paged memory
Register r2 information: NULL pointer
Register r3 information:
8<--- cut here ---
Unable to handle kernel paging request at virtual address 0001b564 when read
[0001b564] *pgd=00000000
Internal error: Oops: 5 [#2] ARM
CPU: 0 UID: 0 PID: 0 Comm: swapper Not tainted 6.19.0-rc3-03898-g7975b0084358 #451 NONE
Hardware name: BCM2835
PC is at kmem_dump_obj (mm/slab.h:142 (discriminator 2) mm/slab.h:178 (discriminator 2) mm/slab_common.c:609 (discriminator 2))
LR is at 0x1
pc : lr : psr: 200001d3
sp : c0d01cc8 ip : 00000000 fp : 0000000b
r10: 00200000 r9 : c0dab1dc r8 : 00000000
r7 : 00000005 r6 : 00000dab r5 : 0001b560 r4 : c0dab20c
r3 : c0dc2058 r2 : 1f000000 r1 : 00c00000 r0 : 00000001
Flags: nzCv IRQs off FIQs off Mode SVC_32 ISA ARM Segment none
Control: 00c5387d Table: 00004008 DAC: 00000051
Register r0 information: non-paged memory
Register r1 information: non-paged memory
Register r2 information: non-paged memory
Register r3 information:
8<--- cut here ---
and the second one repeats for some time afterwards.
I experimented a little by allocating the zero page statically as many
other arches do which fixes the issue as it does not need to be
initialized at this point anymore, though I have no idea if that's
appropriate.
Regards,
Klara Modin
...
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index bdcc3639681f..a8f7b4084715 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -118,15 +118,6 @@ void __init arch_zone_limits_init(unsigned long *max_zone_pfn)
> #endif
> }
>
> -static void __init zone_sizes_init(unsigned long min, unsigned long max_low,
> - unsigned long max_high)
> -{
> - unsigned long max_zone_pfn[MAX_NR_ZONES] = { 0 };
> -
> - arch_zone_limits_init(max_zone_pfn);
> - free_area_init(max_zone_pfn);
> -}
> -
> #ifdef CONFIG_HAVE_ARCH_PFN_VALID
> int pfn_valid(unsigned long pfn)
> {
> @@ -222,13 +213,6 @@ void __init bootmem_init(void)
> * done after the fixed reservations
> */
> sparse_init();
> -
> - /*
> - * Now free the memory - free_area_init needs
> - * the sparse mem_map arrays initialized by sparse_init()
> - * for memmap_init_zone(), otherwise all PFNs are invalid.
> - */
> - zone_sizes_init(min_low_pfn, max_low_pfn, max_pfn);
> }
>
> /*
...
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 628c0e0ac313..64d6f9c15ef1 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -45,6 +45,7 @@ struct pt_regs;
> struct folio_batch;
>
> void arch_mm_preinit(void);
> +void mm_core_init_early(void);
> void mm_core_init(void);
> void init_mm_internals(void);
>
> @@ -3536,7 +3537,7 @@ static inline unsigned long get_num_physpages(void)
> }
>
> /*
> - * Using memblock node mappings, an architecture may initialise its
> + * FIXME: Using memblock node mappings, an architecture may initialise its
> * zones, allocate the backing mem_map and account for memory holes in an
> * architecture independent manner.
> *
> @@ -3551,7 +3552,6 @@ static inline unsigned long get_num_physpages(void)
> * memblock_add_node(base, size, nid, MEMBLOCK_NONE)
> * free_area_init(max_zone_pfns);
> */
> -void free_area_init(unsigned long *max_zone_pfn);
> void arch_zone_limits_init(unsigned long *max_zone_pfn);
> unsigned long node_map_pfn_alignment(void);
> extern unsigned long absent_pages_in_range(unsigned long start_pfn,
> diff --git a/init/main.c b/init/main.c
> index b84818ad9685..445b5643ecec 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -1025,6 +1025,7 @@ void start_kernel(void)
> page_address_init();
> pr_notice("%s", linux_banner);
> setup_arch(&command_line);
> + mm_core_init_early();
> /* Static keys and static calls are needed by LSMs */
> jump_label_init();
> static_call_init();
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index fc2a6f1e518f..ffc4a0f1fee9 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1810,7 +1810,6 @@ static void __init set_high_memory(void)
>
> /**
> * free_area_init - Initialise all pg_data_t and zone data
> - * @max_zone_pfn: an array of max PFNs for each zone
> *
> * This will call free_area_init_node() for each active node in the system.
> * Using the page ranges provided by memblock_set_node(), the size of each
> @@ -1821,17 +1820,14 @@ static void __init set_high_memory(void)
> * starts where the previous one ended. For example, ZONE_DMA32 starts
> * at arch_max_dma_pfn.
> */
> -void __init free_area_init(unsigned long *max_zone_pfn)
> +static void __init free_area_init(void)
> {
> + unsigned long max_zone_pfn[MAX_NR_ZONES] = { 0 };
> unsigned long start_pfn, end_pfn;
> int i, nid, zone;
> bool descending;
>
> - /* Record where the zone boundaries are */
> - memset(arch_zone_lowest_possible_pfn, 0,
> - sizeof(arch_zone_lowest_possible_pfn));
> - memset(arch_zone_highest_possible_pfn, 0,
> - sizeof(arch_zone_highest_possible_pfn));
> + arch_zone_limits_init(max_zone_pfn);
>
> start_pfn = PHYS_PFN(memblock_start_of_DRAM());
> descending = arch_has_descending_max_zone_pfns();
> @@ -2681,13 +2677,19 @@ void __init __weak mem_init(void)
> {
> }
>
> +void __init mm_core_init_early(void)
> +{
> + hugetlb_bootmem_alloc();
> +
> + free_area_init();
> +}
> +
> /*
> * Set up kernel memory allocators
> */
> void __init mm_core_init(void)
> {
> arch_mm_preinit();
> - hugetlb_bootmem_alloc();
>
> /* Initializations relying on SMP setup */
> BUILD_BUG_ON(MAX_ZONELISTS > 2);
> --
> 2.51.0
>
next prev parent reply other threads:[~2026-01-02 23:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 6:59 [PATCH v2 00/28] arch, mm: consolidate hugetlb early reservation Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 01/28] alpha: introduce arch_zone_limits_init() Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 02/28] arc: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 03/28] arm: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 04/28] arm64: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 05/28] csky: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 06/28] hexagon: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 07/28] loongarch: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 08/28] m68k: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 09/28] microblaze: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 10/28] mips: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 11/28] nios2: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 12/28] openrisc: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 13/28] parisc: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 14/28] powerpc: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 15/28] riscv: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 16/28] s390: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 17/28] sh: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 18/28] sparc: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 19/28] um: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 20/28] x86: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 21/28] xtensa: " Mike Rapoport
2026-01-02 6:59 ` [PATCH v2 22/28] arch, mm: consolidate initialization of nodes, zones and memory map Mike Rapoport
2026-01-02 23:33 ` Klara Modin [this message]
2026-01-02 6:59 ` [PATCH v2 23/28] arch, mm: consolidate initialization of SPARSE memory model Mike Rapoport
2026-01-02 7:00 ` [PATCH v2 24/28] mips: drop paging_init() Mike Rapoport
2026-01-02 7:00 ` [PATCH v2 25/28] x86: don't reserve hugetlb memory in setup_arch() Mike Rapoport
2026-01-02 7:00 ` [PATCH v2 26/28] mm, arch: consolidate hugetlb CMA reservation Mike Rapoport
2026-01-02 7:00 ` [PATCH v2 27/28] mm/hugetlb: drop hugetlb_cma_check() Mike Rapoport
2026-01-02 7:00 ` [PATCH v2 28/28] Revert "mm/hugetlb: deal with multiple calls to hugetlb_bootmem_alloc" Mike Rapoport
2026-01-02 18:03 ` [PATCH v2 00/28] arch, mm: consolidate hugetlb early reservation Frank van der Linden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVhN2NgQEKe0yzva@soda.int.kasm.eu \
--to=klarasmodin@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=andreas@gaisler.com \
--cc=bcain@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chleroy@kernel.org \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=deller@gmx.de \
--cc=dinguyen@kernel.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=guoren@kernel.org \
--cc=hca@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=mattst88@gmail.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=palmer@dabbelt.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=rppt@kernel.org \
--cc=shorne@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vbabka@suse.cz \
--cc=vgupta@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox