From: Matthew Wilcox <willy@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Pedro Falcato" <pfalcato@suse.de>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Hildenbrand" <david@redhat.com>,
amd-gfx@lists.freedesktop.org, linux-mm@kvack.org,
"Vlastimil Babka" <vbabka@suse.cz>,
"Jann Horn" <jannh@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v4 1/2] mm_take_all_locks: change -EINTR to -ERESTARTSYS
Date: Wed, 7 Jan 2026 20:55:23 +0000 [thread overview]
Message-ID: <aV7IO8-trMSI1twA@casper.infradead.org> (raw)
In-Reply-To: <20260107203224.969740802@debian4.vm>
On Wed, Jan 07, 2026 at 09:31:14PM +0100, Mikulas Patocka wrote:
> This commit changes -EINTR to -ERESTARTSYS, so that if the signal handler
> was installed with the SA_RESTART flag, the operation is automatically
> restarted.
No, this is bonkers. If you get a signal, you return -EINTR.
next prev parent reply other threads:[~2026-01-07 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 20:31 [PATCH v4 0/2] Fix failures with signals and AMD OpenCL Mikulas Patocka
2026-01-07 20:31 ` [PATCH v4 1/2] mm_take_all_locks: change -EINTR to -ERESTARTSYS Mikulas Patocka
2026-01-07 20:55 ` Matthew Wilcox [this message]
2026-01-07 21:29 ` Mikulas Patocka
2026-01-08 15:25 ` Lorenzo Stoakes
2026-01-08 15:33 ` Liam R. Howlett
2026-01-07 20:31 ` [PATCH v4 2/2] amdgpu: delete the "Failed to register MMU notifier" message Mikulas Patocka
2026-01-08 15:20 ` Lorenzo Stoakes
2026-01-08 15:30 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV7IO8-trMSI1twA@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=david@redhat.com \
--cc=jannh@google.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mpatocka@redhat.com \
--cc=pfalcato@suse.de \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox