From: Gregory Price <gourry@gourry.net>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>, hare@suse.de
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, osalvador@suse.de,
gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org,
akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com
Subject: Re: [RFC PATCH] memory,memory_hotplug: allow restricting memory blocks to zone movable
Date: Tue, 6 Jan 2026 13:06:57 -0500 [thread overview]
Message-ID: <aV1PQd3tyfSiH4xD@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <9575e042-39f4-4f01-80db-34aaaa9312e6@kernel.org>
On Tue, Jan 06, 2026 at 06:52:11PM +0100, David Hildenbrand (Red Hat) wrote:
> On 1/6/26 17:58, Gregory Price wrote:
> > On Tue, Jan 06, 2026 at 04:24:21PM +0100, David Hildenbrand (Red Hat) wrote:
> >
> > I'm not against this idea, but it also makes the sysfs a little more
> > confusing (`echo online` now does different things based on prior
> > state).
>
> Right, but only for the contig-zones policy.
>
> But maybe you really want the default for such memory to be "movable" even
> when not onlined beforehand? So I am not sure if the description of the
> problem here is accurate.
>
> Isn't one problem also udev racing with ndctl?
>
Yeah there's a bunch of races, the specific ones mentioned by Hannes i
need to go back and re-listen to the talk.
> > I preferred just failing if the block wasn't compatible with
> > the zone (maybe making it more clear with a dmesg print?)
>
> The thing is that this block is compatible with the zone, no?
>
> In a system where you would never want to offline that memory, why should we
> stop someone from onlining it to a kernel zone? I'm sure someone with a
> weird use case will show up later that will complain about this.
>
Presumably you wouldn't be setting the MHP flag that prevents the blocks
from being onlined in a kernel zone then - in which case this all just
works as intended today.
> But the patch is missing details on who would actually set MHP_MOVABLE_ONLY.
> A user should be posted alongside the core change.
>
This is fair and probably the obvious immediate user would be a dax
device with some kind of `dax0.0/protect_unplug` feature set.
(With a better name obviuosly).
I will defer to Hannes on his specific use case, but I could see the
CXL-DCD (Dynamic Capacity) set wanting something like this.
> >
> > Anyway, let me know what your preference is, happy to pivot however.
>
> Restricting memory to be movable-only to handle a user-space problem as
> described here sounds like the wrong approach to me. You really want the
> default of such memory to be "movable".
>
> Almost like an optimized "auto-movable" policy :)
>
> Or a new policy that will respect a provided default (MHP_DEFAULT_MOVABLE).
>
Fair, I'll revist this once Hannes gets a chance to chime in.
This was effective at getting the discussion started though :P
~Gregory
next prev parent reply other threads:[~2026-01-06 18:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 20:36 Gregory Price
2026-01-06 15:05 ` Michal Hocko
2026-01-06 16:53 ` Gregory Price
2026-01-06 19:49 ` Michal Hocko
2026-01-07 12:47 ` Hannes Reinecke
2026-01-07 17:17 ` Michal Hocko
2026-01-07 15:09 ` David Hildenbrand (Red Hat)
2026-01-07 16:00 ` Gregory Price
2026-01-07 17:19 ` Michal Hocko
2026-01-06 15:24 ` David Hildenbrand (Red Hat)
2026-01-06 16:58 ` Gregory Price
2026-01-06 17:52 ` David Hildenbrand (Red Hat)
2026-01-06 18:06 ` Gregory Price [this message]
2026-01-06 18:38 ` David Hildenbrand (Red Hat)
2026-01-06 19:59 ` Gregory Price
2026-01-06 20:22 ` David Hildenbrand (Red Hat)
2026-01-08 7:31 ` Hannes Reinecke
2026-01-08 14:16 ` David Hildenbrand (Red Hat)
2026-01-08 7:21 ` Hannes Reinecke
2026-01-08 7:22 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV1PQd3tyfSiH4xD@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dakr@kernel.org \
--cc=david@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox