From: Christoph Hellwig <hch@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
klourencodev@gmail.com, linux-mm@kvack.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] mm/mempool.c: set @elems slots to NULL once freed
Date: Thu, 8 Jan 2026 06:15:32 -0800 [thread overview]
Message-ID: <aV-8BFEtV-dMNCCl@infradead.org> (raw)
In-Reply-To: <aVzDVxhLp4tfAkKk@infradead.org>
On Tue, Jan 06, 2026 at 12:09:59AM -0800, Christoph Hellwig wrote:
> On Tue, Jan 06, 2026 at 09:00:21AM +0100, Vlastimil Babka wrote:
> > > Not sure. I hate the magic null skipping behavior in
> > > __alloc_pages_bulk()/release_pages(), but given that we try to stay
> > > compatible it might be best to do this.
> >
> > Well but release_pages() is null skipping but not NULL creating?
>
> True. Let me think about this a bit more.
I thought about this a bit, and can't think of any benefit in zeroing
the slot. So I think just updating the documentation here might be
the better choice.
prev parent reply other threads:[~2026-01-08 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 23:10 klourencodev
2025-12-23 23:47 ` Vlastimil Babka
2026-01-05 16:46 ` Vlastimil Babka
2026-01-06 6:22 ` Christoph Hellwig
2026-01-06 8:00 ` Vlastimil Babka
2026-01-06 8:09 ` Christoph Hellwig
2026-01-08 14:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV-8BFEtV-dMNCCl@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=klourencodev@gmail.com \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox