From: Matthew Wilcox <willy@infradead.org>
To: kernel test robot <oliver.sang@intel.com>
Cc: Vishal Moola <vishal.moola@gmail.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>,
linux-mm@kvack.org, Mel Gorman <mgorman@techsingularity.net>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [linus:master] [mm/vmalloc] a061578043: BUG:spinlock_trylock_failure_on_UP_on_CPU
Date: Fri, 19 Dec 2025 23:37:47 +0000 [thread overview]
Message-ID: <aUXhy1Jyv7_GccIp@casper.infradead.org> (raw)
In-Reply-To: <aUW05pyc9nZkvY-1@casper.infradead.org>
On Fri, Dec 19, 2025 at 08:26:14PM +0000, Matthew Wilcox wrote:
> Now, as I recall, we are very much doing this on purpose. We decided
> not to disable interrupts at this point for improved interrupt
> latency, accepting the possibility that we'd occasionally fail
> the trylock. Except on UP that's now an assertion failure.
This is stupid and wrong. If we have CONFIG_SMP=n and
CONFIG_DEBUG_SPINLOCK=n, then trylock always succeeds. And we'll end
up corrupting the data structure protected by the lock. So the warning
is real, and we need to fix this.
With my distro hat on, I do not give two hoots. We don't ship a nosmp
kernel. I suspect all other distros (except maybe something targetting
m68k?) are in the same boat.
next prev parent reply other threads:[~2025-12-19 23:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 6:10 kernel test robot
2025-12-10 23:30 ` Vishal Moola (Oracle)
2025-12-11 10:09 ` Uladzislau Rezki
2025-12-11 13:40 ` Oliver Sang
2025-12-11 13:53 ` Oliver Sang
2025-12-11 20:52 ` Vishal Moola (Oracle)
2025-12-11 20:47 ` Andrew Morton
2025-12-11 21:01 ` Vishal Moola (Oracle)
2025-12-19 20:26 ` Matthew Wilcox
2025-12-19 23:37 ` Matthew Wilcox [this message]
2025-12-22 16:11 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUXhy1Jyv7_GccIp@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mgorman@techsingularity.net \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox