linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com, akpm@linux-foundation.org, vbabka@suse.cz,
	surenb@google.com, mhocko@suse.com, jackmanb@google.com,
	ziy@nvidia.com, richard.weiyang@gmail.com, osalvador@suse.de,
	rientjes@google.com, david@redhat.com, joshua.hahnjy@gmail.com,
	fvdl@google.com
Subject: Re: [PATCH v5] page_alloc: allow migration of smaller hugepages during contig_alloc
Date: Thu, 18 Dec 2025 18:38:50 -0500	[thread overview]
Message-ID: <aUSQin8iN78L9gKU@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <aURXd7d1on5vxnnT@cmpxchg.org>

On Thu, Dec 18, 2025 at 02:35:19PM -0500, Johannes Weiner wrote:
> On Thu, Dec 18, 2025 at 02:08:31PM -0500, Gregory Price wrote:
> > +			page = compound_head(page);
> > +			order = compound_order(page);
> > +			if ((order >= MAX_FOLIO_ORDER) ||
> > +			    (nr_pages <= (1 << order)))
> > +				return false;
> 
> If you keep searching past it, you can step over the whole page to
> speed things up a bit:
> 
> 			i += (1 << order) - 1;

ack, good catch, added to v6

~Gregory


  reply	other threads:[~2025-12-18 23:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-18 19:08 Gregory Price
2025-12-18 19:35 ` Johannes Weiner
2025-12-18 23:38   ` Gregory Price [this message]
2025-12-18 19:45 ` Zi Yan
2025-12-18 20:42   ` Gregory Price
2025-12-18 21:17     ` Zi Yan
2025-12-18 21:32       ` Gregory Price
2025-12-18 21:07   ` Gregory Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUSQin8iN78L9gKU@gourry-fedora-PF4VCD3F \
    --to=gourry@gourry.net \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=fvdl@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=richard.weiyang@gmail.com \
    --cc=rientjes@google.com \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox