From: Matthew Wilcox <willy@infradead.org>
To: Jinchao Wang <wangjinchao600@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
Hannes Reinecke <hare@suse.de>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
syzbot+4d3cc33ef7a77041efa6@syzkaller.appspotmail.com,
syzbot+fdba5cca73fee92c69d6@syzkaller.appspotmail.com
Subject: Re: [PATCH] mm/readahead: read min folio constraints under invalidate lock
Date: Mon, 15 Dec 2025 14:22:23 +0000 [thread overview]
Message-ID: <aUAZn1ituYtbCEdd@casper.infradead.org> (raw)
In-Reply-To: <20251215141936.1045907-1-wangjinchao600@gmail.com>
On Mon, Dec 15, 2025 at 10:19:00PM +0800, Jinchao Wang wrote:
> page_cache_ra_order() and page_cache_ra_unbounded() read mapping minimum folio
> constraints before taking the invalidate lock, allowing concurrent changes to
> violate page cache invariants.
>
> Move the lookups under filemap_invalidate_lock_shared() to ensure readahead
> allocations respect the mapping constraints.
Why are the mapping folio size constraints being changed? They're
supposed to be set at inode instantiation and then never changed.
next prev parent reply other threads:[~2025-12-15 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 14:19 Jinchao Wang
2025-12-15 14:22 ` Matthew Wilcox [this message]
2025-12-16 1:37 ` Jinchao Wang
2025-12-16 2:42 ` Matthew Wilcox
2025-12-16 3:12 ` Jinchao Wang
2025-12-16 3:53 ` Matthew Wilcox
2025-12-18 4:03 ` Jinchao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUAZn1ituYtbCEdd@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=hare@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+4d3cc33ef7a77041efa6@syzkaller.appspotmail.com \
--cc=syzbot+fdba5cca73fee92c69d6@syzkaller.appspotmail.com \
--cc=wangjinchao600@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox