From: Matthew Wilcox <willy@infradead.org>
To: Jan Sokolowski <jan.sokolowski@intel.com>
Cc: linux-kernel@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC PATCH 1/1] idr: do not create idr if new id would be outside given range
Date: Thu, 27 Nov 2025 13:38:05 +0000 [thread overview]
Message-ID: <aShUPdV18CIxvV-G@casper.infradead.org> (raw)
In-Reply-To: <20251127092732.684959-2-jan.sokolowski@intel.com>
On Thu, Nov 27, 2025 at 10:27:32AM +0100, Jan Sokolowski wrote:
> @@ -88,6 +89,11 @@ int idr_alloc(struct idr *idr, void *ptr, int start, int end, gfp_t gfp)
> if (ret)
> return ret;
>
> + if (WARN_ON_ONCE(id < start || (id >= end && end != 0))) {
> + idr_remove(idr, id);
> + return -EINVAL;
> + }
This is certainly the wrong way to fix any problem that does exist.
And it should return -ENOSPC, not -EINVAL. -EINVAL is "the arguments
are wrong", not "the data structure is full".
I'll go read the thread now.
next prev parent reply other threads:[~2025-11-27 13:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 9:27 [RFC PATCH 0/1] IDR fix for potential id mismatch Jan Sokolowski
2025-11-27 9:27 ` [RFC PATCH 1/1] idr: do not create idr if new id would be outside given range Jan Sokolowski
2025-11-27 13:38 ` Matthew Wilcox [this message]
2025-11-27 13:54 ` Matthew Wilcox
2025-11-27 14:03 ` Christian König
2025-11-27 14:11 ` Matthew Wilcox
2025-11-27 14:55 ` Matthew Wilcox
2025-11-27 15:02 ` Christian König
2025-11-28 9:03 ` Sokolowski, Jan
2025-11-28 15:52 ` Matthew Wilcox
2025-11-28 16:47 ` Sokolowski, Jan
2025-11-28 17:50 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aShUPdV18CIxvV-G@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=christian.koenig@amd.com \
--cc=jan.sokolowski@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox