linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Harry Yoo <harry.yoo@oracle.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@gentwo.org>,
	David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	linux-mm@kvack.org, Alexander Potapenko <glider@google.com>,
	Marco Elver <elver@google.com>,
	kasan-dev@googlegroups.com
Subject: Re: [PATCH v4 01/16] slab: Reimplement page_slab()
Date: Mon, 24 Nov 2025 11:03:50 +0900	[thread overview]
Message-ID: <aSO9BroaxaNaC_hN@hyeyoo> (raw)
In-Reply-To: <20251113000932.1589073-2-willy@infradead.org>

On Thu, Nov 13, 2025 at 12:09:15AM +0000, Matthew Wilcox (Oracle) wrote:
> In order to separate slabs from folios, we need to convert from any page
> in a slab to the slab directly without going through a page to folio
> conversion first.
> 
> Up to this point, page_slab() has followed the example of other memdesc
> converters (page_folio(), page_ptdesc() etc) and just cast the pointer
> to the requested type, regardless of whether the pointer is actually a
> pointer to the correct type or not.
> 
> That changes with this commit; we check that the page actually belongs
> to a slab and return NULL if it does not.  Other memdesc converters will
> adopt this convention in future.
> 
> kfence was the only user of page_slab(), so adjust it to the new way
> of working.  It will need to be touched again when we separate slab
> from page.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Cc: Alexander Potapenko <glider@google.com>
> Cc: Marco Elver <elver@google.com>
> Cc: kasan-dev@googlegroups.com
> ---

Looks good to me,
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>

-- 
Cheers,
Harry / Hyeonggon


  parent reply	other threads:[~2025-11-24  2:04 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13  0:09 [PATCH v4 00/16] Prepare slab for memdescs Matthew Wilcox (Oracle)
2025-11-13  0:09 ` [PATCH v4 01/16] slab: Reimplement page_slab() Matthew Wilcox (Oracle)
2025-11-13 12:31   ` David Hildenbrand (Red Hat)
2025-11-13 14:02   ` Marco Elver
2025-11-24  2:03   ` Harry Yoo [this message]
2025-11-13  0:09 ` [PATCH v4 02/16] slab: Remove folio references from __ksize() Matthew Wilcox (Oracle)
2025-11-13 12:32   ` David Hildenbrand (Red Hat)
2025-11-24  2:31   ` Harry Yoo
2025-11-24  4:28     ` Matthew Wilcox
2025-11-24  5:18       ` Harry Yoo
2025-11-13  0:09 ` [PATCH v4 03/16] slab: Remove folio references in memcg_slab_post_charge() Matthew Wilcox (Oracle)
2025-11-13  0:09 ` [PATCH v4 04/16] slab: Remove folio references in slab alloc/free Matthew Wilcox (Oracle)
2025-11-13  0:09 ` [PATCH v4 05/16] slab: Remove folio references from ___kmalloc_large_node() Matthew Wilcox (Oracle)
2025-11-13  0:09 ` [PATCH v4 06/16] slab: Remove folio references from free_large_kmalloc() Matthew Wilcox (Oracle)
2025-11-13  0:09 ` [PATCH v4 07/16] slab: Remove folio references from kvfree_rcu_cb() Matthew Wilcox (Oracle)
2025-11-24  5:22   ` Harry Yoo
2025-11-13  0:09 ` [PATCH v4 08/16] slab: Remove folio references from kfree() Matthew Wilcox (Oracle)
2025-11-24  5:39   ` Harry Yoo
2025-11-24 13:53     ` Matthew Wilcox
2025-11-13  0:09 ` [PATCH v4 09/16] slab: Remove folio references from __do_krealloc() Matthew Wilcox (Oracle)
2025-11-24  5:55   ` Harry Yoo
2025-11-13  0:09 ` [PATCH v4 10/16] slab: Remove folio references from build_detached_freelist() Matthew Wilcox (Oracle)
2025-11-24  5:55   ` Harry Yoo
2025-11-13  0:09 ` [PATCH v4 11/16] slab: Remove folio references from kfree_rcu_sheaf() Matthew Wilcox (Oracle)
2025-11-24  5:58   ` Harry Yoo
2025-11-13  0:09 ` [PATCH v4 12/16] slab: Remove folio references from kfree_nolock() Matthew Wilcox (Oracle)
2025-11-24  5:59   ` Harry Yoo
2025-11-13  0:09 ` [PATCH v4 13/16] usercopy: Remove folio references from check_heap_object() Matthew Wilcox (Oracle)
2025-11-24  6:14   ` Harry Yoo
2025-11-24 21:06   ` Kees Cook
2025-11-13  0:09 ` [PATCH v4 14/16] memcg: Convert mem_cgroup_from_obj_folio() to mem_cgroup_from_obj_slab() Matthew Wilcox (Oracle)
2025-11-13 16:14   ` Johannes Weiner
2025-11-13 16:28     ` Vlastimil Babka
2025-11-13 19:42       ` Shakeel Butt
2025-11-13 20:33         ` Matthew Wilcox
2025-11-13 21:54           ` Shakeel Butt
2025-11-13 16:39     ` Matthew Wilcox
2025-11-13 19:16       ` Johannes Weiner
2025-11-13 19:26         ` Vlastimil Babka
2025-11-24  6:44       ` Harry Yoo
2025-11-13  0:09 ` [PATCH v4 15/16] kasan: Remove references to folio in __kasan_mempool_poison_object() Matthew Wilcox (Oracle)
2025-11-24  7:02   ` Harry Yoo
2025-11-13  0:09 ` [PATCH v4 16/16] slab: Remove references to folios from virt_to_slab() Matthew Wilcox (Oracle)
2025-11-24  7:09   ` Harry Yoo
2025-11-24 14:12     ` Matthew Wilcox
2025-11-13 11:28 ` [PATCH v4 00/16] Prepare slab for memdescs Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSO9BroaxaNaC_hN@hyeyoo \
    --to=harry.yoo@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@gentwo.org \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox