linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] ns: pad refcount
Date: Sun, 23 Nov 2025 19:58:30 +0100	[thread overview]
Message-ID: <aSNZVv6BZCZcRsgs@redhat.com> (raw)
In-Reply-To: <20251123063054.3502938-3-mjguzik@gmail.com>

On 11/23, Mateusz Guzik wrote:
>
>  struct ns_common {
> +	struct {
> +		refcount_t __ns_ref; /* do not use directly */
> +	} ____cacheline_aligned_in_smp;

Cough... stupid question. Why not just

	refcount_t __ns_ref ____cacheline_aligned_in_smp;

? why do we need the anonymous struct?

Oleg.



  reply	other threads:[~2025-11-23 18:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-23  6:30 [PATCH 0/3] further damage-control lack of clone scalability Mateusz Guzik
2025-11-23  6:30 ` [PATCH 1/3] idr: add idr_prealloc_many Mateusz Guzik
2025-11-23  6:30 ` [PATCH 2/3] ns: pad refcount Mateusz Guzik
2025-11-23 18:58   ` Oleg Nesterov [this message]
2025-11-23 19:47     ` Mateusz Guzik
2025-11-24 18:25       ` Oleg Nesterov
2025-11-23  6:30 ` [PATCH 3/3] pid: only take pidmap_lock once on alloc Mateusz Guzik
2025-11-23 20:09   ` Oleg Nesterov
2025-11-23 22:48     ` Mateusz Guzik
2025-11-23 15:00 ` [PATCH 0/3] further damage-control lack of clone scalability Matthew Wilcox
2025-11-23 16:39   ` Mateusz Guzik
2025-11-23 21:45     ` Matthew Wilcox
2025-11-23 22:33       ` Mateusz Guzik
2025-11-24  4:03         ` Mateusz Guzik
2025-12-03  8:37   ` Mateusz Guzik
2025-12-03  9:18     ` Mateusz Guzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSNZVv6BZCZcRsgs@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mjguzik@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox