* [PATCH next] mm/damon/tests/sysfs-kunit: fix use after free on error path
@ 2025-11-21 13:36 Dan Carpenter
2025-11-21 16:35 ` SeongJae Park
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-11-21 13:36 UTC (permalink / raw)
To: SeongJae Park
Cc: Andrew Morton, Dan Carpenter, damon, linux-mm, linux-kernel,
kernel-janitors
Re-order these frees to avoid dereferencing "sysfs_target" after it has
been freed.
Fixes: ee131696794c ("mm/damon/tests/sysfs-kunit: handle alloc failures on damon_sysfs_test_add_targets()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
mm/damon/tests/sysfs-kunit.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/tests/sysfs-kunit.h b/mm/damon/tests/sysfs-kunit.h
index ce7218469f20..0c665ed255a3 100644
--- a/mm/damon/tests/sysfs-kunit.h
+++ b/mm/damon/tests/sysfs-kunit.h
@@ -76,8 +76,8 @@ static void damon_sysfs_test_add_targets(struct kunit *test)
if (!ctx) {
kfree(sysfs_targets->targets_arr);
kfree(sysfs_targets);
- kfree(sysfs_target);
kfree(sysfs_target->regions);
+ kfree(sysfs_target);
kunit_skip(test, "ctx alloc fail");
}
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH next] mm/damon/tests/sysfs-kunit: fix use after free on error path
2025-11-21 13:36 [PATCH next] mm/damon/tests/sysfs-kunit: fix use after free on error path Dan Carpenter
@ 2025-11-21 16:35 ` SeongJae Park
0 siblings, 0 replies; 2+ messages in thread
From: SeongJae Park @ 2025-11-21 16:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: SeongJae Park, Andrew Morton, damon, linux-mm, linux-kernel,
kernel-janitors
On Fri, 21 Nov 2025 16:36:38 +0300 Dan Carpenter <dan.carpenter@linaro.org> wrote:
> Re-order these frees to avoid dereferencing "sysfs_target" after it has
> been freed.
Thank you for finding and fixing this!
>
> Fixes: ee131696794c ("mm/damon/tests/sysfs-kunit: handle alloc failures on damon_sysfs_test_add_targets()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-21 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-21 13:36 [PATCH next] mm/damon/tests/sysfs-kunit: fix use after free on error path Dan Carpenter
2025-11-21 16:35 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox