From: Matthew Wilcox <willy@infradead.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] mm/readahead: try to allocate high order pages for FADVISE_FAV_WILLNEED
Date: Tue, 2 Dec 2025 22:56:33 +0000 [thread overview]
Message-ID: <aS9uod21hG_qq7Rd@casper.infradead.org> (raw)
In-Reply-To: <20251202013212.964298-4-jaegeuk@kernel.org>
On Tue, Dec 02, 2025 at 01:30:13AM +0000, Jaegeuk Kim wrote:
> @@ -627,7 +628,7 @@ void page_cache_sync_ra(struct readahead_control *ractl,
> ra->size = min(contig_count + req_count, max_pages);
> ra->async_size = 1;
> readit:
> - ra->order = 0;
> + ra->order = mapping_max_folio_order(ractl->mapping);
> ractl->_index = ra->start;
> page_cache_ra_order(ractl, ra);
> }
I suspect this is in the wrong place, but I'm on holiday and not going
to go spelunking through the readahead code looking for the right place.
Also, going directly to max folio order is wrong, we should use the same
approach as the write order code, encapsulated in filemap_get_order().
See 4f6617011910
next prev parent reply other threads:[~2025-12-02 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 1:30 [PATCH 0/3 v2] improve fadvise(POSIX_FADV_WILLNEED) with large folio Jaegeuk Kim
2025-12-02 1:30 ` [PATCH 1/3] mm/readahead: fix the broken readahead for POSIX_FADV_WILLNEED Jaegeuk Kim
2025-12-02 1:30 ` [PATCH 2/3] mm/readahead: use page_cache_sync_ra for FADVISE_FAV_WILLNEED Jaegeuk Kim
2025-12-02 1:30 ` [PATCH 3/3] mm/readahead: try to allocate high order pages " Jaegeuk Kim
2025-12-02 22:56 ` Matthew Wilcox [this message]
2025-12-03 19:04 ` Jaegeuk Kim
2025-12-03 23:25 ` [PATCH 3/3 v2] " Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS9uod21hG_qq7Rd@casper.infradead.org \
--to=willy@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox