From: Mike Rapoport <rppt@kernel.org>
To: Swaraj Gaikwad <swarajgaikwad1925@gmail.com>
Cc: akpm@linux-foundation.org, david.hunter.linux@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH RFC] mm/memblock: Fix reserve_mem allocation overlapping KHO scratch regions
Date: Mon, 1 Dec 2025 08:50:24 +0200 [thread overview]
Message-ID: <aS06sCvwSkcn1XcE@kernel.org> (raw)
In-Reply-To: <20251130211540.582343-1-swarajgaikwad1925@gmail.com>
Hi Swaraj,
On Sun, Nov 30, 2025 at 09:15:39PM +0000, Swaraj Gaikwad wrote:
> Hi Mike,
>
> Thanks for the feedback.
>
> This patch was sent as an RFC because I wanted to confirm whether the
> overall approach is acceptable before preparing a fully tested version.
> I will send a properly tested patch once I get confirmation that this
> direction makes sense.
I didn't look into the details, but I think what you propose won't work.
The first kernel allocates KHO scratch after parsing reserve_mem and the
second kernel allocates everything from KHO scratch at the time
early_params are parsed.
> I’m reviewing how reserve_mem= paths are exercised so I can build an
> appropriate test setup. Any guidance on recommended testing for this
> area is appreciated.
In general to test changes to memblock and other early code I use qemu and
some scripts around it.
> Thanks,
> Swaraj
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2025-12-01 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-30 17:29 Swaraj Gaikwad
2025-11-30 15:03 ` Mike Rapoport
2025-11-30 21:15 ` Swaraj Gaikwad
2025-12-01 6:50 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS06sCvwSkcn1XcE@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david.hunter.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=skhan@linuxfoundation.org \
--cc=swarajgaikwad1925@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox