From: Boqun Feng <boqun.feng@gmail.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Uladzislau Rezki <urezki@gmail.com>,
Vitaly Wool <vitaly.wool@konsulko.se>,
linux-mm@kvack.org
Subject: Re: [PATCH 24/46] rust: mm: add __rust_helper to helpers
Date: Tue, 2 Dec 2025 17:43:10 -0800 [thread overview]
Message-ID: <aS-VrkRdQc0H6nSs@tardis.local> (raw)
In-Reply-To: <20251202-define-rust-helper-v1-24-a2e13cbc17a6@google.com>
On Tue, Dec 02, 2025 at 07:37:48PM +0000, Alice Ryhl wrote:
> This is needed to inline these helpers into Rust code.
>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
[...]
> --- a/rust/helpers/vmalloc.c
> +++ b/rust/helpers/vmalloc.c
> @@ -2,9 +2,10 @@
>
> #include <linux/vmalloc.h>
>
> -void * __must_check __realloc_size(2)
> -rust_helper_vrealloc_node_align(const void *p, size_t size, unsigned long align,
> - gfp_t flags, int node)
> +__rust_helper void *__must_check __realloc_size(2)
> + rust_helper_vrealloc_node_align(const void *p, size_t size,
The indent here seems to be incorrect?
Regards,
Boqun
> + unsigned long align, gfp_t flags,
> + int node)
> {
> return vrealloc_node_align(p, size, align, flags, node);
> }
>
> --
> 2.52.0.158.g65b55ccf14-goog
>
>
next prev parent reply other threads:[~2025-12-03 1:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 19:37 [PATCH 00/46] Allow inlining C helpers into Rust when using LTO Alice Ryhl
2025-12-02 19:37 ` [PATCH 23/46] rust: maple_tree: add __rust_helper to helpers Alice Ryhl
2025-12-04 21:07 ` Andrew Ballance
2025-12-02 19:37 ` [PATCH 24/46] rust: mm: " Alice Ryhl
2025-12-03 1:43 ` Boqun Feng [this message]
2025-12-03 9:03 ` Alice Ryhl
2025-12-02 19:38 ` [PATCH 46/46] rust: xarray: " Alice Ryhl
2025-12-03 1:47 ` [PATCH 00/46] Allow inlining C helpers into Rust when using LTO Boqun Feng
2025-12-03 14:33 ` Gary Guo
2025-12-04 10:05 ` (subset) " Christian Brauner
2025-12-15 13:59 ` Mark Brown
2025-12-15 21:40 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS-VrkRdQc0H6nSs@tardis.local \
--to=boqun.feng@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=vitaly.wool@konsulko.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox