linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com, akpm@linux-foundation.org, vbabka@suse.cz,
	surenb@google.com, mhocko@suse.com, jackmanb@google.com,
	hannes@cmpxchg.org, ziy@nvidia.com,
	Wei Yang <richard.weiyang@gmail.com>
Subject: Re: [PATCH v3] page_alloc: allow migration of smaller hugepages during contig_alloc.
Date: Thu, 6 Nov 2025 11:06:33 -0500	[thread overview]
Message-ID: <aQzHibKYKy0SQU1z@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <2de17512-3df3-4ee4-9912-8a8f7ca5b648@redhat.com>

On Mon, Oct 27, 2025 at 04:43:25PM +0100, David Hildenbrand wrote:
> On 24.10.25 21:28, Gregory Price wrote:
> > We presently skip regions with hugepages entirely when trying to do
> > contiguous page allocation.  Instead, if hugepage migration is enabled,
> > consider regions with hugepages smaller than the target contiguous
> > allocation request as valid targets for allocation.
> > 
> > isolate_migrate_pages_block() already expects requests with hugepages
> > to originate from alloc_contig, and hugetlb code also does a migratable
> > check when isolating in folio_isolate_hugetlb().
> > 
> > Suggested-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Gregory Price <gourry@gourry.net>
> > Reviewed-by: Zi Yan <ziy@nvidia.com>
> > Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
> > ---
> 
> Nit: trailing "." in subject
> 
> Acked-by: David Hildenbrand <david@redhat.com>
>

Hi David,

Do you think i should just staple these commits together at this point?

https://lore.kernel.org/linux-mm/20251009161515.422292-1-gourry@gourry.net/

If not i'll drop the '.' and just resubmit this with tags and just
update the commit message on movable_gigantic_pages to reference this
commit and your notes from there.

~Gregory


  reply	other threads:[~2025-11-06 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 19:28 Gregory Price
2025-10-26  4:46 ` David Rientjes
2025-10-27  9:55 ` Oscar Salvador
2025-10-27 15:43 ` David Hildenbrand
2025-11-06 16:06   ` Gregory Price [this message]
2025-11-21 19:15 Gregory Price
2025-11-21 19:31 ` Andrew Morton
2025-11-21 19:42   ` Gregory Price
2025-12-01 16:30 ` Joshua Hahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQzHibKYKy0SQU1z@gourry-fedora-PF4VCD3F \
    --to=gourry@gourry.net \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=richard.weiyang@gmail.com \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox